Skip to content

Commit 531888c

Browse files
CopilotSteake
andcommitted
Fix documentation issues from code review
Co-authored-by: Steake <530040+Steake@users.noreply.github.com>
1 parent acfcc38 commit 531888c

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

docs/issue-45.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ The BitCell system requires robust zero-knowledge proof circuits to ensure priva
4141

4242
### Technical Specifications
4343

44-
- **Proving System**: Groth16 (via arkworks-rs)
44+
- **Proving System**: Groth16 (via arkworks)
4545
- **Curve**: BN254 (Bn254)
4646
- **Field**: Fr (scalar field of BN254)
4747
- **Merkle Tree Depth**: 32
@@ -60,7 +60,7 @@ The circuits enforce the following constraints:
6060
4. `computed_new_root == new_root` - Verifies the new Merkle tree state
6161

6262
**NullifierCircuit Constraints:**
63-
1. `(computed_root == set_root) == is_member` - Membership verification
63+
1. `computed_root.is_eq(set_root) == is_member` - Verifies that the Merkle root equality check result matches the membership flag
6464

6565
### API Methods
6666

@@ -88,6 +88,6 @@ The implementation includes comprehensive tests:
8888
## References
8989

9090
- [Groth16 Paper](https://eprint.iacr.org/2016/260.pdf)
91-
- [Arkworks Documentation](https://arkworks.rs/)
91+
- [Arkworks Groth16 Documentation](https://docs.rs/ark-groth16/)
9292
- Implementation: `crates/bitcell-zkp/src/state_constraints.rs`
9393
- [GitHub Issue #45](https://github.com/Steake/BitCell/issues/45)

0 commit comments

Comments
 (0)