Skip to content

Commit 05ede2e

Browse files
author
Alexey Stukalov
committed
fixup SemEnsemble: SemML loss
1 parent 9f712c6 commit 05ede2e

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

src/loss/ML/ML.jl

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -92,20 +92,20 @@ function evaluate!(
9292
objective,
9393
gradient,
9494
hessian,
95-
ml::SemML{<:Any, <:SemImpliedSymbolic},
95+
loss::SemML{<:Any, <:SemImpliedSymbolic},
9696
par,
9797
)
98-
implied = SEM.implied(ml)
98+
implied = SEM.implied(loss)
9999

100100
if !isnothing(hessian)
101101
(MeanStruct(implied) === HasMeanStruct) &&
102102
throw(DomainError(H, "hessian of ML + meanstructure is not available"))
103103
end
104104

105105
Σ = implied.Σ
106-
Σₒ = obs_cov(observed(model))
107-
Σ⁻¹Σₒ = ml.Σ⁻¹Σₒ
108-
Σ⁻¹ = ml.Σ⁻¹
106+
Σₒ = obs_cov(observed(loss))
107+
Σ⁻¹Σₒ = loss.Σ⁻¹Σₒ
108+
Σ⁻¹ = loss.Σ⁻¹
109109

110110
copyto!(Σ⁻¹, Σ)
111111
Σ_chol = cholesky!(Symmetric(Σ⁻¹); check = false)
@@ -123,7 +123,7 @@ function evaluate!(
123123

124124
if MeanStruct(implied) === HasMeanStruct
125125
μ = implied.μ
126-
μₒ = obs_mean(observed(ml))
126+
μₒ = obs_mean(observed(loss))
127127
μ₋ = μₒ - μ
128128

129129
isnothing(objective) || (objective += dot(μ₋, Σ⁻¹, μ₋))
@@ -142,7 +142,7 @@ function evaluate!(
142142
mul!(gradient, ∇Σ', J')
143143
end
144144
if !isnothing(hessian)
145-
if HessianEval(ml) === ApproxHessian
145+
if HessianEval(loss) === ApproxHessian
146146
mul!(hessian, ∇Σ' * kron(Σ⁻¹, Σ⁻¹), ∇Σ, 2, 0)
147147
else
148148
∇²Σ = implied.∇²Σ

0 commit comments

Comments
 (0)