move Sem methods out of types.jl

Author: alyst

src/frontend/specification/Sem.jl

@@ -30,9 +30,42 @@ latent_vars(sem::AbstractSemSingle) = latent_vars(sem.imply)
 
 nsamples(sem::AbstractSemSingle) = nsamples(sem.observed)
 
+params(model::AbstractSem) = params(model.imply)
+
 # sum of samples in all sub-models
 nsamples(ensemble::SemEnsemble) = sum(nsamples, ensemble.sems)
 
+############################################################################################
+# additional methods
+############################################################################################
+"""
+    observed(model::AbstractSemSingle) -> SemObserved
+
+Returns the observed part of a model.
+"""
+observed(model::AbstractSemSingle) = model.observed
+
+"""
+    imply(model::AbstractSemSingle) -> SemImply
+
+Returns the imply part of a model.
+"""
+imply(model::AbstractSemSingle) = model.imply
+
+"""
+    loss(model::AbstractSemSingle) -> SemLoss
+
+Returns the loss part of a model.
+"""
+loss(model::AbstractSemSingle) = model.loss
+
+"""
+    optimizer(model::AbstractSemSingle) -> SemOptimizer
+
+Returns the optimizer part of a model.
+"""
+optimizer(model::AbstractSemSingle) = model.optimizer
+
 function SemFiniteDiff(;
     observed::O = SemObservedData,
     imply::I = RAM,

src/types.jl

@@ -13,13 +13,6 @@ abstract type AbstractSemCollection <: AbstractSem end
 "Supertype for all loss functions of SEMs. If you want to implement a custom loss function, it should be a subtype of `SemLossFunction`."
 abstract type SemLossFunction end
 
-"""
-    params(semobj)
-
-Return the vector of SEM model parameters.
-"""
-params(model::AbstractSem) = model.params
-
 """
     SemLoss(args...; loss_weights = nothing, ...)
 
@@ -225,37 +218,6 @@ Returns the optimizer part of an ensemble model.
 """
 optimizer(ensemble::SemEnsemble) = ensemble.optimizer
 
-############################################################################################
-# additional methods
-############################################################################################
-"""
-    observed(model::AbstractSemSingle) -> SemObserved
-
-Returns the observed part of a model.
-"""
-observed(model::AbstractSemSingle) = model.observed
-
-"""
-    imply(model::AbstractSemSingle) -> SemImply
-
-Returns the imply part of a model.
-"""
-imply(model::AbstractSemSingle) = model.imply
-
-"""
-    loss(model::AbstractSemSingle) -> SemLoss
-
-Returns the loss part of a model.
-"""
-loss(model::AbstractSemSingle) = model.loss
-
-"""
-    optimizer(model::AbstractSemSingle) -> SemOptimizer
-
-Returns the optimizer part of a model.
-"""
-optimizer(model::AbstractSemSingle) = model.optimizer
-
 """
 Base type for all SEM specifications.
 """