Skip to content

Commit 3bb9854

Browse files
committed
Expose reload_package_on_testing in local runner
Add --reload-package-on-testing to docker/sbin local runner CLI and pass it through to scheduled test options. Set reload_package_on_testing to false by default in generated schedule entries, so local runs avoid package reload unless explicitly requested.
1 parent 0a6a0c7 commit 3bb9854

3 files changed

Lines changed: 16 additions & 0 deletions

File tree

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ Useful options:
151151
- `--pattern test_foo.py --tests-dir tests/subdir`
152152
- `--coverage`
153153
- `--failfast`
154+
- `--reload-package-on-testing` (default: off)
154155
- `--scheduler-delay-ms 0` (default)
155156
- `--refresh-cache` (re-bootstrap cached `/root` state)
156157
- `--refresh-image` (rebuild local Docker image)

docker/run_tests.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ def main(argv: list[str] | None = None) -> int:
8181
scheduler_delay_ms=args.scheduler_delay_ms,
8282
coverage=args.coverage,
8383
failfast=args.failfast,
84+
reload_package_on_testing=args.reload_package_on_testing,
8485
tests_dir=tests_dir,
8586
pattern=pattern,
8687
)
@@ -121,6 +122,11 @@ def parse_args(argv: list[str] | None) -> argparse.Namespace:
121122
test_group.add_argument("--package-name", help="Override package name.")
122123
test_group.add_argument("--coverage", action="store_true", help="Enable coverage.")
123124
test_group.add_argument("--failfast", action="store_true", help="Stop on first failure.")
125+
test_group.add_argument(
126+
"--reload-package-on-testing",
127+
action="store_true",
128+
help="Reload package under test before running tests.",
129+
)
124130
test_group.add_argument(
125131
"--scheduler-delay-ms",
126132
type=int,
@@ -323,6 +329,7 @@ def build_docker_run_command(
323329
scheduler_delay_ms: int,
324330
coverage: bool,
325331
failfast: bool,
332+
reload_package_on_testing: bool,
326333
tests_dir: str | None,
327334
pattern: str | None,
328335
) -> list[str]:
@@ -349,6 +356,9 @@ def build_docker_run_command(
349356
if failfast:
350357
command.append("--failfast")
351358

359+
if reload_package_on_testing:
360+
command.append("--reload-package-on-testing")
361+
352362
if tests_dir:
353363
command.extend(["--tests-dir", tests_dir])
354364

sbin/run_tests.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,7 @@ def main(default_schedule_info):
203203
parser.add_option('--pattern')
204204
parser.add_option('--tests-dir')
205205
parser.add_option('--failfast', action='store_true')
206+
parser.add_option('--reload-package-on-testing', action='store_true')
206207

207208
options, remainder = parser.parse_args()
208209

@@ -218,6 +219,7 @@ def main(default_schedule_info):
218219
'syntax_compatibility': syntax_compatibility,
219220
'color_scheme_test': color_scheme_test,
220221
'coverage': coverage,
222+
'reload_package_on_testing': False,
221223
}
222224

223225
if options.pattern:
@@ -229,4 +231,7 @@ def main(default_schedule_info):
229231
if options.failfast:
230232
default_schedule_info['failfast'] = True
231233

234+
if options.reload_package_on_testing:
235+
default_schedule_info['reload_package_on_testing'] = True
236+
232237
main(default_schedule_info)

0 commit comments

Comments
 (0)