Skip to content

Commit 2b876d9

Browse files
steveshorttsteveshortt
committed
found bug running unit tests, reaffirming why it's impt to run unit tests /before/ publishing to nuget.
1 parent 5183508 commit 2b876d9

26 files changed

Lines changed: 487 additions & 279 deletions

‎Synapse.Common/Properties/AssemblyInfo.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,4 @@
3838
// by using the '*' as shown below:
3939
// [assembly: AssemblyVersion("1.0.*")]
4040
[assembly: AssemblyVersion( "1.0.0.0" )]
41-
[assembly: AssemblyFileVersion( "1.0.18258.0" )]
41+
[assembly: AssemblyFileVersion( "1.0.18258.1" )]

‎Synapse.Core/Classes/DynamicValue.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,15 @@ public class DynamicValue : SourceTarget
1515

1616
public bool TryGetDefaultValue(out object value)
1717
{
18-
bool ok = Default != null && (Default.Value != null || Default.AllowNull);
18+
bool ok = DefaultAllowNull;
1919
if( ok )
2020
value = Default.Value;
2121
else
2222
value = null;
2323

2424
return ok;
2525
}
26-
internal bool DefaultAllowNull { get { return Default.Value != null || Default.AllowNull; } }
26+
internal bool DefaultAllowNull { get { return Default != null && (Default.Value != null || Default.AllowNull); } }
2727

2828
public override string ToString()
2929
{

‎Synapse.Core/Properties/AssemblyInfo.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,4 @@
3636
// by using the '*' as shown below:
3737
// [assembly: AssemblyVersion("1.0.*")]
3838
[assembly: AssemblyVersion( "1.0.0.0" )]
39-
[assembly: AssemblyFileVersion( "1.0.18258.0" )]
39+
[assembly: AssemblyFileVersion( "1.0.18258.1" )]

‎Synapse.UnitTests/Core.cs‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,6 +146,7 @@ public void MergeParameters_Dynamic(string planFile)
146146
[Category( "Parameters" )]
147147
[Category( "Parameters_Inherit" )]
148148
[TestCase( "parameters_yaml_single.yaml" )]
149+
//[TestCase( "parameters_yaml_global.yaml" )]
149150
[TestCase( "parameters_json_single.yaml" )]
150151
[TestCase( "parameters_xml_single.yaml" )]
151152
public void MergeParameters_Inherit(string planFile)

‎Synapse.UnitTests/Plans/Plans/RunAs0_out.yaml‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Actions:
2828
StartInfo:
2929
ParentExitData: &o1
3030
CurrentPrincipal: LAPTOP-TK2D9TB6\synapse0
31-
InstanceId: 106
31+
InstanceId: 107
3232
RunAs: *o0
3333
RunAs: &o2
3434
Domain: LAPTOP-TK2D9TB6
@@ -49,12 +49,12 @@ Actions:
4949
Status: Complete
5050
ExitData:
5151
CurrentPrincipal: LAPTOP-TK2D9TB6\synapse1
52-
InstanceId: 109
52+
InstanceId: 110
5353
ParentExitData: *o1
5454
RunAs: *o2
5555
BranchStatus: Complete
5656
SecurityContext: LAPTOP-TK2D9TB6\synapse1
57-
InstanceId: 109
57+
InstanceId: 110
5858
- Name: 0.2
5959
Handler:
6060
Type: EchoHandler, Synapse.Core, Version=1.0.0.0, Culture=neutral, PublicKeyToken=a6de1cc56b73f982
@@ -67,18 +67,18 @@ Actions:
6767
Status: Complete
6868
ExitData:
6969
CurrentPrincipal: LAPTOP-TK2D9TB6\synapse0
70-
InstanceId: 110
70+
InstanceId: 111
7171
ParentExitData: *o1
7272
RunAs: *o0
7373
BranchStatus: Complete
7474
SecurityContext: LAPTOP-TK2D9TB6\synapse0
75-
InstanceId: 110
75+
InstanceId: 111
7676
Result:
7777
Status: Complete
7878
ExitData: *o1
7979
BranchStatus: Complete
8080
SecurityContext: LAPTOP-TK2D9TB6\synapse0
81-
InstanceId: 106
81+
InstanceId: 107
8282
- Name: 1
8383
Handler:
8484
Type: EchoHandler, Synapse.Core, Version=1.0.0.0, Culture=neutral, PublicKeyToken=a6de1cc56b73f982
@@ -111,12 +111,12 @@ Actions:
111111
Result:
112112
Status: Failed
113113
ExitData: The user name or password is incorrect
114-
InstanceId: 108
114+
InstanceId: 109
115115
Result:
116116
Status: Failed
117117
ExitData: The user name or password is incorrect
118118
BranchStatus: Failed
119-
InstanceId: 107
119+
InstanceId: 108
120120
RunAs:
121121
Domain: LAPTOP-TK2D9TB6
122122
UserName: synapse2
@@ -140,4 +140,4 @@ StartInfo: {}
140140
Result:
141141
Status: Failed
142142
BranchStatus: Failed
143-
LastModified: 8/26/2018 12:18:21 PM
143+
LastModified: 9/15/2018 9:25:44 PM

‎Synapse.UnitTests/Plans/Plans/RunAs1_out.yaml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Actions:
2121
StartInfo:
2222
ParentExitData: &o1
2323
CurrentPrincipal: LAPTOP-TK2D9TB6\synapse0
24-
InstanceId: 111
24+
InstanceId: 112
2525
RunAs: *o0
2626
RunAs: &o2
2727
IsInheritable: true
@@ -32,18 +32,18 @@ Actions:
3232
Status: Complete
3333
ExitData:
3434
CurrentPrincipal: LAPTOP-TK2D9TB6\Steve
35-
InstanceId: 112
35+
InstanceId: 113
3636
ParentExitData: *o1
3737
RunAs: *o2
3838
BranchStatus: Complete
3939
SecurityContext: LAPTOP-TK2D9TB6\Steve
40-
InstanceId: 112
40+
InstanceId: 113
4141
Result:
4242
Status: Complete
4343
ExitData: *o1
4444
BranchStatus: Complete
4545
SecurityContext: LAPTOP-TK2D9TB6\synapse0
46-
InstanceId: 111
46+
InstanceId: 112
4747
RunAs:
4848
Domain: LAPTOP-TK2D9TB6
4949
UserName: synapse2
@@ -54,4 +54,4 @@ StartInfo: {}
5454
Result:
5555
Status: Complete
5656
BranchStatus: Complete
57-
LastModified: 8/26/2018 12:18:21 PM
57+
LastModified: 9/15/2018 9:25:44 PM

‎Synapse.UnitTests/Plans/Plans/RunAs2_out.yaml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Actions:
2424
StartInfo:
2525
ParentExitData: &o1
2626
CurrentPrincipal: LAPTOP-TK2D9TB6\synapse1
27-
InstanceId: 113
27+
InstanceId: 114
2828
RunAs: *o0
2929
RunAs: &o2
3030
Domain: LAPTOP-TK2D9TB6
@@ -42,18 +42,18 @@ Actions:
4242
Status: Complete
4343
ExitData:
4444
CurrentPrincipal: LAPTOP-TK2D9TB6\synapse1
45-
InstanceId: 114
45+
InstanceId: 115
4646
ParentExitData: *o1
4747
RunAs: *o2
4848
BranchStatus: Complete
4949
SecurityContext: LAPTOP-TK2D9TB6\synapse1
50-
InstanceId: 114
50+
InstanceId: 115
5151
Result:
5252
Status: Complete
5353
ExitData: *o1
5454
BranchStatus: Complete
5555
SecurityContext: LAPTOP-TK2D9TB6\synapse1
56-
InstanceId: 113
56+
InstanceId: 114
5757
RunAs:
5858
Domain: LAPTOP-TK2D9TB6
5959
UserName: synapse1
@@ -64,4 +64,4 @@ StartInfo: {}
6464
Result:
6565
Status: Complete
6666
BranchStatus: Complete
67-
LastModified: 8/26/2018 12:18:21 PM
67+
LastModified: 9/15/2018 9:25:44 PM

‎Synapse.UnitTests/Plans/Plans/RunAs3_out.yaml‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Actions:
2424
StartInfo:
2525
ParentExitData: &o1
2626
CurrentPrincipal: LAPTOP-TK2D9TB6\synapse1
27-
InstanceId: 115
27+
InstanceId: 116
2828
RunAs: *o0
2929
RunAs: &o2
3030
Domain: LAPTOP-TK2D9TB6
@@ -41,18 +41,18 @@ Actions:
4141
Status: Complete
4242
ExitData:
4343
CurrentPrincipal: LAPTOP-TK2D9TB6\synapse1
44-
InstanceId: 116
44+
InstanceId: 117
4545
ParentExitData: *o1
4646
RunAs: *o2
4747
BranchStatus: Complete
4848
SecurityContext: LAPTOP-TK2D9TB6\synapse1
49-
InstanceId: 116
49+
InstanceId: 117
5050
Result:
5151
Status: Complete
5252
ExitData: *o1
5353
BranchStatus: Complete
5454
SecurityContext: LAPTOP-TK2D9TB6\synapse1
55-
InstanceId: 115
55+
InstanceId: 116
5656
RunAs:
5757
Domain: LAPTOP-TK2D9TB6
5858
UserName: synapse1
@@ -62,4 +62,4 @@ StartInfo: {}
6262
Result:
6363
Status: Complete
6464
BranchStatus: Complete
65-
LastModified: 8/26/2018 12:18:21 PM
65+
LastModified: 9/15/2018 9:25:44 PM

‎Synapse.UnitTests/Plans/Plans/RunAs4_out.yaml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,17 +51,17 @@ Actions:
5151
Result:
5252
Status: Failed
5353
ExitData: The user name or password is incorrect
54-
InstanceId: 119
54+
InstanceId: 120
5555
Result:
5656
Status: Failed
5757
ExitData: The user name or password is incorrect
5858
BranchStatus: Failed
59-
InstanceId: 118
59+
InstanceId: 119
6060
Result:
6161
Status: Failed
6262
ExitData: The user name or password is incorrect
6363
BranchStatus: Failed
64-
InstanceId: 117
64+
InstanceId: 118
6565
RunAs:
6666
Domain: LAPTOP-TK2D9TB6
6767
UserName: synapse1
@@ -71,4 +71,4 @@ StartInfo: {}
7171
Result:
7272
Status: Failed
7373
BranchStatus: Failed
74-
LastModified: 8/26/2018 12:18:21 PM
74+
LastModified: 9/15/2018 9:25:44 PM

‎Synapse.UnitTests/Plans/Plans/RunAs5_out.yaml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Actions:
3131
StartInfo:
3232
ParentExitData: &o1
3333
CurrentPrincipal: LAPTOP-TK2D9TB6\Steve
34-
InstanceId: 121
34+
InstanceId: 122
3535
ParentExitData: The user name or password is incorrect
3636
RunAs: *o0
3737
RunAs: &o2
@@ -42,23 +42,23 @@ Actions:
4242
Status: Complete
4343
ExitData:
4444
CurrentPrincipal: LAPTOP-TK2D9TB6\Steve
45-
InstanceId: 122
45+
InstanceId: 123
4646
ParentExitData: *o1
4747
RunAs: *o2
4848
BranchStatus: Complete
4949
SecurityContext: LAPTOP-TK2D9TB6\Steve
50-
InstanceId: 122
50+
InstanceId: 123
5151
Result:
5252
Status: Complete
5353
ExitData: *o1
5454
BranchStatus: Complete
5555
SecurityContext: LAPTOP-TK2D9TB6\Steve
56-
InstanceId: 121
56+
InstanceId: 122
5757
Result:
5858
Status: Failed
5959
ExitData: The user name or password is incorrect
6060
BranchStatus: Failed
61-
InstanceId: 120
61+
InstanceId: 121
6262
RunAs:
6363
Domain: LAPTOP-TK2D9TB6
6464
UserName: synapse1
@@ -68,4 +68,4 @@ StartInfo: {}
6868
Result:
6969
Status: Failed
7070
BranchStatus: Failed
71-
LastModified: 8/26/2018 12:18:21 PM
71+
LastModified: 9/15/2018 9:25:44 PM

0 commit comments

Comments
 (0)