fix: v1.9.6 — batch 38 route cleanup (10 crash bugs, ~80 lines dead code removed)

SysAdminDoc · SysAdminDoc · commit aa18ecc561ae · 2026-03-27T15:17:17.000-04:00
- Fix 10 remaining _p(pct, msg) closures missing msg="" default in audio.py (3),
  video_fx.py (5), captions.py (1), workflow.py (1) — all crashed with TypeError
- Remove redundant filepath re-validation from 9 @async_job routes that duplicated
  the decorator's built-in filepath validation (face_enhance, face_swap, upscale_run,
  remove_watermark, title_overlay, particle_apply, color_correct, color_convert,
  color_external_lut) — ~80 lines of dead code
- Remove unused validate_filepath import from video_specialty.py
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,12 @@
 # Changelog
 
+## [1.9.6] - 2026-03-27
+
+### Fixed (Batch 38 — Route Cleanup & Remaining Crash Bugs)
+- **10 remaining `_p(pct, msg)` closures missing `msg=""` default** — Found in `audio.py` (3), `video_fx.py` (5), `captions.py` (1), `workflow.py` (1). All core modules call `on_progress(pct)` with 1 arg, causing TypeError crash on every job using these routes. All now have `msg=""` default.
+- **Redundant filepath re-validation in 7 routes** — `face_enhance`, `face_swap`, `upscale_run`, `remove_watermark`, `title_overlay`, `particle_apply`, `color_correct`, `color_convert`, `color_external_lut` all re-read `data.get("filepath")` and re-validated despite `@async_job` already doing this. Removed ~80 lines of dead validation code, now using the decorator-provided `filepath` param directly.
+- **Unused `validate_filepath` import** — Removed from `video_specialty.py` after watermark/title routes stopped re-validating.
+
 ## [1.9.5] - 2026-03-27
 
 ### Fixed (Batch 37 — Infrastructure & Hardening)
diff --git a/CLAUDE.md b/CLAUDE.md
@@ -180,7 +180,7 @@
 - Lint: `ruff check opencut/` — codebase is fully clean, pre-commit enforces on every commit
 
 ## Version
-- Current: **v1.9.5**
+- Current: **v1.9.6**
 - All version strings: `pyproject.toml`, `__init__.py`, `CSXS/manifest.xml` (ExtensionBundleVersion + Version), `com.opencut.uxp/manifest.json`, `com.opencut.uxp/main.js` (VERSION const), `index.html` version display, README badge, `package.json`
 - Use `python scripts/sync_version.py --set X.Y.Z` to update all 19 targets at once (including UXP files and package.json)
 - Use `python scripts/sync_version.py --check` in CI to verify all targets match
@@ -919,6 +919,11 @@ enhance = ["resemble-enhance>=0.0.1"]
 - **10 duplicate class attributes in HTML** — 10 elements had two `class=` attributes; HTML parser silently ignores the second, losing spacing utilities (mt-xs, mt-sm, mb-sm, mt-md). All merged into single attributes.
 - **pip install permission denied** — `safe_pip_install()` failed on Windows when both normal and `--user` installs hit Errno 13 (Microsoft Store Python, OneDrive-synced user dirs, restrictive ACLs). Added `--target ~/.opencut/packages` as third fallback strategy. server.py adds `~/.opencut/packages` to `sys.path` at startup.
 
+## v1.9.6 Batch 38 Bug Fixes (Route Cleanup)
+- **10 remaining `_p(pct, msg)` closures** — audio.py (3), video_fx.py (5), captions.py (1), workflow.py (1) all crashed with TypeError when core modules called on_progress with 1 arg. Fixed all to `msg=""`.
+- **Redundant filepath re-validation in 7+ routes** — face_enhance, face_swap, upscale_run, remove_watermark, title_overlay, particle_apply, color_correct, color_convert, color_external_lut all re-read `data.get("filepath")` despite @async_job handling it. Removed ~80 lines of dead code.
+- **Unused validate_filepath import** — removed from video_specialty.py.
+
 ## v1.9.5 Batch 37 Bug Fixes (Infrastructure & Hardening)
 - **Bare ffprobe in 8 core modules** — audio_enhance, color_management, highlights, motion_graphics, scene_detect (2), shorts_pipeline, transitions_3d, video_ai all used `"ffprobe"` in subprocess. Fixed to `get_ffprobe_path()`.
 - **GPU VRAM check timeout** — `check_vram()` blocked forever on hung NVIDIA drivers. Added 5s timeout.
diff --git a/Install.ps1 b/Install.ps1
@@ -155,7 +155,7 @@ Write-Host "  \___/| .__/ \___|_| |_|\____\__,_|\__|" -ForegroundColor Cyan
 Write-Host "       |_|                               " -ForegroundColor Cyan
 Write-Host ""
 Write-Host "  Open Source Video Editing Automation" -ForegroundColor DarkGray
-Write-Host "  Installer v1.9.5" -ForegroundColor DarkGray
+Write-Host "  Installer v1.9.6" -ForegroundColor DarkGray
 
 $isAdmin = Test-IsAdmin
 if ($isAdmin) {
diff --git a/OpenCut.iss b/OpenCut.iss
@@ -2,7 +2,7 @@
 ; Fully self-contained installer — bundles server exe, ffmpeg, and CEP extension
 
 #define MyAppName "OpenCut"
-#define MyAppVersion "1.9.5"
+#define MyAppVersion "1.9.6"
 #define MyAppPublisher "SysAdminDoc"
 #define MyAppURL "https://github.com/SysAdminDoc/OpenCut"
 
diff --git a/extension/com.opencut.panel/CSXS/manifest.xml b/extension/com.opencut.panel/CSXS/manifest.xml
@@ -2,11 +2,11 @@
 <ExtensionManifest xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
                    Version="7.0"
                    ExtensionBundleId="com.opencut.panel"
-                   ExtensionBundleVersion="1.9.5"
+                   ExtensionBundleVersion="1.9.6"
                    ExtensionBundleName="OpenCut">
 
     <ExtensionList>
-        <Extension Id="com.opencut.panel.main" Version="1.9.5" />
+        <Extension Id="com.opencut.panel.main" Version="1.9.6" />
     </ExtensionList>
 
     <ExecutionEnvironment>
diff --git a/extension/com.opencut.panel/client/index.html b/extension/com.opencut.panel/client/index.html
@@ -3262,7 +3262,7 @@ <h1 class="content-title" id="contentTitle">Cut & Clean</h1>
                     <div class="card-header"><div class="card-title" data-i18n="settings.about">About OpenCut</div></div>
                     <div class="settings-row">
                         <span class="settings-label">Version</span>
-                        <span class="settings-value">1.9.5</span>
+                        <span class="settings-value">1.9.6</span>
                     </div>
                     <div class="about-links">
                         <a href="https://github.com/SysAdminDoc/opencut" class="about-link" target="_blank">GitHub</a>
diff --git a/extension/com.opencut.panel/client/main.js b/extension/com.opencut.panel/client/main.js
@@ -1,5 +1,5 @@
 /* ============================================================
-   OpenCut CEP Panel - Main Controller v1.9.5
+   OpenCut CEP Panel - Main Controller v1.9.6
    6-Tab Professional Toolkit
    ============================================================ */
 (function () {
diff --git a/extension/com.opencut.panel/client/style.css b/extension/com.opencut.panel/client/style.css
@@ -1,5 +1,5 @@
 /* ============================================================
-   OpenCut CEP Panel v1.9.5 - ULTRA PREMIUM EDITION
+   OpenCut CEP Panel v1.9.6 - ULTRA PREMIUM EDITION
    Next-Generation AI Editing Suite for Adobe Premiere Pro
    ============================================================ */
 
diff --git a/extension/com.opencut.panel/package.json b/extension/com.opencut.panel/package.json
@@ -1,6 +1,6 @@
 {
   "name": "opencut-panel",
-  "version": "1.9.5",
+  "version": "1.9.6",
   "private": true,
   "description": "OpenCut CEP Panel for Adobe Premiere Pro",
   "scripts": {
diff --git a/extension/com.opencut.uxp/index.html b/extension/com.opencut.uxp/index.html
@@ -16,7 +16,7 @@
           <path d="M4 2.5a3 3 0 00-1.76 5.43L7.33 11l-5.09 3.07A3 3 0 104.8 19.5a3 3 0 001.76-5.43L8.93 12.6 16.5 17V5L8.93 9.4 6.56 7.93A3 3 0 004 2.5z" fill="var(--accent)"/>
         </svg>
         <span class="oc-logo">OpenCut</span>
-        <span class="oc-version">v1.9.5</span>
+        <span class="oc-version">v1.9.6</span>
       </div>
       <div class="oc-header-right">
         <div class="oc-connection" id="connectionStatus" title="Backend connection status">
diff --git a/extension/com.opencut.uxp/main.js b/extension/com.opencut.uxp/main.js
@@ -26,7 +26,7 @@ const HEALTH_CHECK_MS  = 8000;
 const HEALTH_MAX_MS    = 60000;
 const MEDIA_SCAN_MS    = 30000;
 const SSE_AVAILABLE    = typeof EventSource !== "undefined";
-const VERSION          = "1.9.5";
+const VERSION          = "1.9.6";
 
 async function detectBackend() {
   // Try ports 5679-5689 like CEP panel does
diff --git a/extension/com.opencut.uxp/manifest.json b/extension/com.opencut.uxp/manifest.json
@@ -1,7 +1,7 @@
 {
   "id": "com.opencut.uxp",
   "name": "OpenCut UXP",
-  "version": "1.9.5",
+  "version": "1.9.6",
   "main": "index.html",
   "host": [
     {
diff --git a/install.py b/install.py
@@ -10,7 +10,7 @@
 import subprocess
 import platform
 
-VERS = "1.9.5"
+VERS = "1.9.6"
 CEP_EXT = "com.opencut.panel"
 WIN_CEP_DIR = os.path.expandvars(r"%APPDATA%\Adobe\CEP\extensions")
 MAC_CEP_DIR = os.path.expanduser("~/Library/Application Support/Adobe/CEP/extensions")
diff --git a/installer/src/OpenCut.Installer/Models/AppConstants.cs b/installer/src/OpenCut.Installer/Models/AppConstants.cs
@@ -3,7 +3,7 @@ namespace OpenCut.Installer.Models;
 public static class AppConstants
 {
     public const string AppName = "OpenCut";
-    public const string AppVersion = "1.9.5";
+    public const string AppVersion = "1.9.6";
     public const string AppDisplayName = $"{AppName} v{AppVersion}";
     public const string AppPublisher = "SysAdminDoc";
     public const string AppUrl = "https://github.com/SysAdminDoc/OpenCut";
diff --git a/installer/src/OpenCut.Installer/OpenCut.Installer.csproj b/installer/src/OpenCut.Installer/OpenCut.Installer.csproj
@@ -7,8 +7,8 @@
     <RootNamespace>OpenCut.Installer</RootNamespace>
     <AssemblyName>OpenCut-Setup</AssemblyName>
     <ApplicationIcon>Assets\logo.ico</ApplicationIcon>
-    <Version>1.9.5</Version>
-    <FileVersion>1.9.5.0</FileVersion>
+    <Version>1.9.6</Version>
+    <FileVersion>1.9.6.0</FileVersion>
     <AssemblyVersion>1.3.0.0</AssemblyVersion>
     <Company>SysAdminDoc</Company>
     <Product>OpenCut Installer</Product>
diff --git a/installer/src/OpenCut.Installer/Properties/app.manifest b/installer/src/OpenCut.Installer/Properties/app.manifest
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <assembly manifestVersion="1.0" xmlns="urn:schemas-microsoft-com:asm.v1">
-  <assemblyIdentity version="1.9.5.0" name="OpenCut.Installer" />
+  <assemblyIdentity version="1.9.6.0" name="OpenCut.Installer" />
   <trustInfo xmlns="urn:schemas-microsoft-com:asm.v2">
     <security>
       <requestedPrivileges xmlns="urn:schemas-microsoft-com:asm.v3">
diff --git a/opencut/__init__.py b/opencut/__init__.py
@@ -5,6 +5,6 @@
 and more. Exports Premiere Pro / DaVinci Resolve / FCP XML.
 """
 
-__version__ = "1.9.5"
+__version__ = "1.9.6"
 __author__ = "OpenCut Contributors"
 __license__ = "MIT"
diff --git a/opencut/routes/audio.py b/opencut/routes/audio.py
@@ -1234,7 +1234,7 @@ def music_ai_generate(job_id, filepath, data):
         raise ValueError("Another AI GPU operation is already running. Please wait.")
 
     try:
-        def _p(pct, msg):
+        def _p(pct, msg=""):
             _update_job(job_id, progress=pct, message=msg)
 
         d = data.get("output_dir", "")
@@ -1274,7 +1274,7 @@ def music_ai_ace_step(job_id, filepath, data):
         raise ValueError("Another AI GPU operation is already running. Please wait.")
 
     try:
-        def _p(pct, msg):
+        def _p(pct, msg=""):
             _update_job(job_id, progress=pct, message=msg)
 
         d = data.get("output_dir", "")
@@ -1309,7 +1309,7 @@ def music_ai_melody(job_id, filepath, data):
         raise ValueError("Another AI GPU operation is already running. Please wait.")
 
     try:
-        def _p(pct, msg):
+        def _p(pct, msg=""):
             _update_job(job_id, progress=pct, message=msg)
 
         d = data.get("output_dir", "")
diff --git a/opencut/routes/captions.py b/opencut/routes/captions.py
@@ -978,7 +978,7 @@ def animated_caption_render(job_id, filepath, data):
 
     from opencut.core.animated_captions import render_animated_captions
 
-    def _p(pct, msg):
+    def _p(pct, msg=""):
         _update_job(job_id, progress=pct, message=msg)
 
     d = _resolve_output_dir(filepath, data.get("output_dir", ""))
diff --git a/opencut/routes/video_ai.py b/opencut/routes/video_ai.py
@@ -362,24 +362,17 @@ def face_swap_capabilities():
 @async_job("face_enhance")
 def face_enhance_route(job_id, filepath, data):
     """Enhance/restore faces in video using GFPGAN or CodeFormer."""
-    fp = data.get("filepath", "").strip()
     _enhance_model = data.get("model", "gfpgan")
     if _enhance_model not in ("gfpgan", "codeformer"):
         _enhance_model = "gfpgan"
     _fidelity = safe_float(data.get("fidelity", 0.5), 0.5, min_val=0.0, max_val=1.0)
-    if not fp:
-        raise ValueError("File not found")
-    try:
-        fp = validate_filepath(fp)
-    except ValueError as e:
-        raise ValueError(str(e))
 
     from opencut.core.face_swap import enhance_faces
 
     def _p(pct, msg=""):
         _update_job(job_id, progress=pct, message=msg)
-    d = _resolve_output_dir(fp, data.get("output_dir", ""))
-    out = enhance_faces(fp, output_dir=d, model=_enhance_model, upscale=safe_int(data.get("upscale", 2), 2, min_val=1, max_val=4), fidelity=_fidelity, on_progress=_p)
+    d = _resolve_output_dir(filepath, data.get("output_dir", ""))
+    out = enhance_faces(filepath, output_dir=d, model=_enhance_model, upscale=safe_int(data.get("upscale", 2), 2, min_val=1, max_val=4), fidelity=_fidelity, on_progress=_p)
     return {"output_path": out}
 
 
@@ -388,27 +381,17 @@ def _p(pct, msg=""):
 @async_job("face_swap")
 def face_swap_route(job_id, filepath, data):
     """Swap faces in video with a reference image."""
-    fp = data.get("filepath", "").strip()
     ref = data.get("reference_face", "").strip()
-    if not fp:
-        raise ValueError("Video not found")
     if not ref:
         raise ValueError("Reference face not found")
-    try:
-        fp = validate_filepath(fp)
-    except ValueError as e:
-        raise ValueError(f"Video: {e}")
-    try:
-        ref = validate_filepath(ref)
-    except ValueError as e:
-        raise ValueError(f"Reference face: {e}")
+    ref = validate_filepath(ref)
 
     from opencut.core.face_swap import swap_face
 
     def _p(pct, msg=""):
         _update_job(job_id, progress=pct, message=msg)
-    d = _resolve_output_dir(fp, data.get("output_dir", ""))
-    out = swap_face(fp, ref, output_dir=d, on_progress=_p)
+    d = _resolve_output_dir(filepath, data.get("output_dir", ""))
+    out = swap_face(filepath, ref, output_dir=d, on_progress=_p)
     return {"output_path": out}
 
 
@@ -429,20 +412,12 @@ def upscale_capabilities():
 @async_job("upscale")
 def upscale_run(job_id, filepath, data):
     """Upscale video with quality preset."""
-    fp = data.get("filepath", "").strip()
-    if not fp:
-        raise ValueError("File not found")
-    try:
-        fp = validate_filepath(fp)
-    except ValueError as e:
-        raise ValueError(str(e))
-
     from opencut.core.upscale_pro import upscale_with_preset
 
     def _p(pct, msg=""):
         _update_job(job_id, progress=pct, message=msg)
-    d = _resolve_output_dir(fp, data.get("output_dir", ""))
-    out = upscale_with_preset(fp, preset=data.get("preset", "fast"),
+    d = _resolve_output_dir(filepath, data.get("output_dir", ""))
+    out = upscale_with_preset(filepath, preset=data.get("preset", "fast"),
                                scale=safe_int(data.get("scale", 2), 2, min_val=1, max_val=4),
                                output_dir=d, on_progress=_p)
     return {"output_path": out}
diff --git a/opencut/routes/video_fx.py b/opencut/routes/video_fx.py
diff --git a/opencut/routes/video_specialty.py b/opencut/routes/video_specialty.py
diff --git a/opencut/routes/workflow.py b/opencut/routes/workflow.py
diff --git a/pyproject.toml b/pyproject.toml
diff --git a/requirements.txt b/requirements.txt

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "opencut-panel",`
`3`		`- "version": "1.9.5",`
	`3`	`+ "version": "1.9.6",`
`4`	`4`	`"private": true,`
`5`	`5`	`"description": "OpenCut CEP Panel for Adobe Premiere Pro",`
`6`	`6`	`"scripts": {`