Skip to content

Commit 0b255bb

Browse files
committed
Added validation to Ideas and Feature Proposals
1 parent 6569618 commit 0b255bb

5 files changed

Lines changed: 22 additions & 2 deletions

File tree

src/main/java/edu/tamu/app/model/AbstractIdea.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ public abstract class AbstractIdea extends ValidatingBaseEntity {
3838

3939
public AbstractIdea() {
4040
super();
41-
this.modelValidator = new IdeaValidator();
4241
}
4342

4443
public AbstractIdea(String title, String description) {

src/main/java/edu/tamu/app/model/FeatureProposal.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
2121
import com.fasterxml.jackson.annotation.ObjectIdGenerators;
2222

23+
import edu.tamu.app.model.validation.FeatureProposalValidator;
24+
2325
@Entity
2426
@JsonIgnoreProperties(value = { "voters" }, allowGetters = true)
2527
public class FeatureProposal extends AbstractIdea {
@@ -41,6 +43,7 @@ public class FeatureProposal extends AbstractIdea {
4143

4244
public FeatureProposal() {
4345
super();
46+
this.modelValidator = new FeatureProposalValidator();
4447
setup();
4548
}
4649

src/main/java/edu/tamu/app/model/Idea.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import javax.persistence.Entity;
55

66
import edu.tamu.app.model.request.ServiceRequest;
7+
import edu.tamu.app.model.validation.IdeaValidator;
78

89
@Entity
910
public class Idea extends AbstractIdea {
@@ -13,6 +14,7 @@ public class Idea extends AbstractIdea {
1314

1415
public Idea() {
1516
super();
17+
this.modelValidator = new IdeaValidator();
1618
this.elevated = false;
1719
}
1820

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
package edu.tamu.app.model.validation;
2+
3+
import edu.tamu.weaver.validation.model.InputValidationType;
4+
import edu.tamu.weaver.validation.validators.BaseModelValidator;
5+
import edu.tamu.weaver.validation.validators.InputValidator;
6+
7+
public class FeatureProposalValidator extends BaseModelValidator {
8+
9+
public FeatureProposalValidator() {
10+
String titleProperty = "title";
11+
this.addInputValidator(new InputValidator(InputValidationType.required, "Feature Proposals require a title", titleProperty, true));
12+
}
13+
}
Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
11
package edu.tamu.app.model.validation;
22

3+
import edu.tamu.weaver.validation.model.InputValidationType;
34
import edu.tamu.weaver.validation.validators.BaseModelValidator;
5+
import edu.tamu.weaver.validation.validators.InputValidator;
46

57
public class IdeaValidator extends BaseModelValidator {
68

79
public IdeaValidator() {
8-
10+
String titleProperty = "title";
11+
this.addInputValidator(new InputValidator(InputValidationType.required, "Ideas require a title", titleProperty, true));
912
}
1013

1114
}

0 commit comments

Comments
 (0)