Skip to content

Commit a5145f6

Browse files
authored
Merge pull request #62 from TAMULib/sprint6-b03624-idea-state-enum
Created IdeaState enum and cleaned up elevated boolean
2 parents 8501ffe + 3f3d7f7 commit a5145f6

3 files changed

Lines changed: 25 additions & 14 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
package edu.tamu.app.enums;
2+
3+
public enum IdeaState {
4+
WAITING_ON_REVIEW, ELEVATED, SENT_TO_HELPDESK, REJECTED
5+
}

src/main/java/edu/tamu/app/model/Idea.java

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,25 +2,29 @@
22

33
import javax.persistence.Column;
44
import javax.persistence.Entity;
5+
import javax.persistence.EnumType;
6+
import javax.persistence.Enumerated;
57

8+
import edu.tamu.app.enums.IdeaState;
69
import edu.tamu.app.model.request.ServiceRequest;
710
import edu.tamu.app.model.validation.IdeaValidator;
811

912
@Entity
1013
public class Idea extends AbstractIdea {
1114

15+
@Enumerated(EnumType.STRING)
1216
@Column(nullable = false)
13-
private boolean elevated;
17+
private IdeaState state;
1418

1519
public Idea() {
1620
super();
1721
this.modelValidator = new IdeaValidator();
18-
this.elevated = false;
22+
this.state = IdeaState.WAITING_ON_REVIEW;
1923
}
2024

2125
public Idea(String title, String description) {
2226
super(title, description);
23-
this.elevated = false;
27+
this.state = IdeaState.WAITING_ON_REVIEW;
2428
}
2529

2630
public Idea(ServiceRequest serviceRequest) {
@@ -29,20 +33,21 @@ public Idea(ServiceRequest serviceRequest) {
2933

3034
public Idea(String title, String description, User author) {
3135
super(title, description, author);
32-
this.elevated = false;
36+
this.state = IdeaState.WAITING_ON_REVIEW;
3337
}
3438

3539
public Idea(String title, String description, User author, Service service) {
3640
super(title, description, author, service);
37-
this.elevated = false;
41+
this.state = IdeaState.WAITING_ON_REVIEW;
3842
}
3943

40-
public boolean isElevated() {
41-
return elevated;
44+
public IdeaState getState() {
45+
return state;
4246
}
4347

44-
public void setElevated(boolean elevated) {
45-
this.elevated = elevated;
48+
public void setState(IdeaState state) {
49+
this.state = state;
4650
}
47-
4851
}
52+
53+

src/main/java/edu/tamu/app/model/repo/impl/FeatureProposalRepoImpl.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import org.springframework.beans.factory.annotation.Autowired;
88
import org.springframework.messaging.simp.SimpMessagingTemplate;
99

10+
import edu.tamu.app.enums.IdeaState;
1011
import edu.tamu.app.exception.UserNotFoundException;
1112
import edu.tamu.app.model.FeatureProposal;
1213
import edu.tamu.app.model.Idea;
@@ -38,7 +39,7 @@ public FeatureProposal create(FeatureProposal featureProposal, Credentials crede
3839
if (user.isPresent()) {
3940
featureProposal.setAuthor(user.get());
4041
featureProposal.getIdeas().forEach(idea -> {
41-
idea.setElevated(true);
42+
idea.setState(IdeaState.ELEVATED);
4243
idea = ideaRepo.save(idea);
4344
simpMessagingTemplate.convertAndSend("/channel/ideas/update", new ApiResponse(SUCCESS, idea));
4445
});
@@ -51,7 +52,7 @@ public FeatureProposal create(FeatureProposal featureProposal, Credentials crede
5152

5253
@Override
5354
public FeatureProposal create(Idea idea) {
54-
idea.setElevated(true);
55+
idea.setState(IdeaState.ELEVATED);
5556
idea = ideaRepo.save(idea);
5657
simpMessagingTemplate.convertAndSend("/channel/ideas/update", new ApiResponse(SUCCESS, idea));
5758
FeatureProposal featureProposal = featureProposalRepo.save(new FeatureProposal(idea));
@@ -62,7 +63,7 @@ public FeatureProposal create(Idea idea) {
6263
@Override
6364
public FeatureProposal update(FeatureProposal featureProposal) {
6465
featureProposal.getIdeas().forEach(idea -> {
65-
idea.setElevated(true);
66+
idea.setState(IdeaState.ELEVATED);
6667
idea = ideaRepo.save(idea);
6768
simpMessagingTemplate.convertAndSend("/channel/ideas/update", new ApiResponse(SUCCESS, idea));
6869
});
@@ -74,7 +75,7 @@ public FeatureProposal update(FeatureProposal featureProposal) {
7475
@Override
7576
public void delete(FeatureProposal featureProposal) {
7677
featureProposal.getIdeas().forEach(idea -> {
77-
idea.setElevated(false);
78+
idea.setState(IdeaState.WAITING_ON_REVIEW);
7879
idea = ideaRepo.save(idea);
7980
simpMessagingTemplate.convertAndSend("/channel/ideas/update", new ApiResponse(SUCCESS, idea));
8081
});

0 commit comments

Comments
 (0)