Skip to content

Commit ca18c42

Browse files
authored
Merge pull request #92 from TAMULib/product-sprint6-staging
Product sprint6 staging
2 parents 6d47cc9 + 689cffc commit ca18c42

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

src/main/java/edu/tamu/app/controller/ServiceController.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,11 @@ public ApiResponse submitIssueRequest(@RequestBody ServiceRequest request, @Weav
9494
Service service = serviceRepo.findOne(request.getService());
9595
issueRequest.setService(service.getName());
9696
issueRequest.setCredentials(credentials);
97-
return productService.submitIssueRequest(issueRequest);
97+
ApiResponse response = productService.submitIssueRequest(issueRequest);
98+
if (response.getMeta().getStatus().equals(ApiStatus.SUCCESS)) {
99+
return new ApiResponse(SUCCESS, String.format("Your issue for %s has been submitted!", service.getName()), response.getPayload());
100+
}
101+
return response;
98102
}
99103

100104
@RequestMapping("/feature")
@@ -104,7 +108,7 @@ public ApiResponse submitFeatureRequest(@RequestBody ServiceRequest request, @We
104108
Idea idea = new Idea(request);
105109
idea.setService(service);
106110
ideaRepo.create(idea, credentials);
107-
return new ApiResponse(ApiStatus.SUCCESS, "Your feature request for " + service.getName() + " has been submitted as an idea!");
111+
return new ApiResponse(ApiStatus.SUCCESS, String.format("Your feature request for %s has been submitted as an idea!", service.getName()));
108112
}
109113

110114
}

src/test/java/edu/tamu/app/controller/ServiceControllerTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,15 +192,15 @@ public void submitIssueRequest() {
192192
ServiceRequest request = new ServiceRequest(AbstractRequest.RequestType.ISSUE, "Test feature request", "This is a test issue request on product 1", 1L);
193193
ApiResponse response = serviceController.submitIssueRequest(request, credentials);
194194
assertEquals("Response was not a success!", ApiStatus.SUCCESS, response.getMeta().getStatus());
195-
assertEquals("Response message was not correct!", "Successfully submitted " + request.getType().getName() + " request!", response.getMeta().getMessage());
195+
assertEquals("Response message was not correct!", String.format("Your issue for %s has been submitted!", TEST_SERVICE1_NAME), response.getMeta().getMessage());
196196
}
197197

198198
@Test
199199
public void submitFeatureRequest() throws UserNotFoundException {
200200
ServiceRequest request = new ServiceRequest(AbstractRequest.RequestType.FEATURE, "Test issue request", "This is a test issue request on product 1", 1L);
201201
ApiResponse response = serviceController.submitFeatureRequest(request, credentials);
202202
assertEquals("Response was not a success!", ApiStatus.SUCCESS, response.getMeta().getStatus());
203-
assertEquals("Response message was not correct!", "Your feature request for " + TEST_SERVICE1_NAME + " has been submitted as an idea!", response.getMeta().getMessage());
203+
assertEquals("Response message was not correct!", String.format("Your feature request for %s has been submitted as an idea!", TEST_SERVICE1_NAME), response.getMeta().getMessage());
204204
}
205205

206206
@After

0 commit comments

Comments
 (0)