Add missing tests for page methods for relevant controllers

Repeat the coverage fix for the ServiceController in all similar controllers.
The FeatureProposalController seems to be inconsistent and used other names than "page" for its method.

Author: kaladay

src/test/java/edu/tamu/app/controller/FeatureProposalControllerTest.java

@@ -17,6 +17,9 @@
 import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.MockitoAnnotations;
+import org.springframework.data.domain.Page;
+import org.springframework.data.domain.PageImpl;
+import org.springframework.data.domain.Pageable;
 import org.springframework.messaging.simp.SimpMessagingTemplate;
 import org.springframework.test.context.ActiveProfiles;
 import org.springframework.test.context.junit4.SpringRunner;
@@ -30,6 +33,8 @@
 import edu.tamu.app.model.repo.FeatureProposalRepo;
 import edu.tamu.app.model.repo.ServiceRepo;
 import edu.tamu.app.model.repo.UserRepo;
+import edu.tamu.app.model.repo.specification.FeatureProposalSpecification;
+import edu.tamu.app.model.request.FilteredPageRequest;
 import edu.tamu.weaver.auth.model.Credentials;
 import edu.tamu.weaver.response.ApiResponse;
 
@@ -56,6 +61,7 @@ public class FeatureProposalControllerTest {
     private static FeatureProposal TEST_FEATURE_PROPOSAL3 = new FeatureProposal(TEST_FEATURE_PROPOSAL_TITLE3, TEST_FEATURE_PROPOSAL_DESCRIPTION3, TEST_USER1);
     private static FeatureProposal TEST_MODIFIED_FEATURE_PROPOSAL = new FeatureProposal(TEST_MODIFIED_FEATURE_PROPOSAL_TITLE, TEST_MODIFIED_FEATURE_PROPOSAL_DESCRIPTION, TEST_USER2, TEST_SERVICE);
     private static List<FeatureProposal> mockFeatureProposalList = new ArrayList<FeatureProposal>(Arrays.asList(new FeatureProposal[] { TEST_FEATURE_PROPOSAL1, TEST_FEATURE_PROPOSAL2, TEST_FEATURE_PROPOSAL3 }));
+    private static Page<FeatureProposal> mockPageableFeatureProposalList = new PageImpl<FeatureProposal>(Arrays.asList(new FeatureProposal[] { TEST_FEATURE_PROPOSAL1, TEST_FEATURE_PROPOSAL2, TEST_FEATURE_PROPOSAL3 }));
 
     private static User user = new User("123456789");
 
@@ -80,11 +86,13 @@ public class FeatureProposalControllerTest {
     private FeatureProposalController featureProposalController;
 
     @Before
+    @SuppressWarnings("unchecked")
     public void setup() throws UserNotFoundException {
         MockitoAnnotations.initMocks(this);
         when(credentials.getUin()).thenReturn("123456789");
         when(userRepo.findByUsername(any(String.class))).thenReturn(Optional.of(user));
         when(featureProposalRepo.findAll()).thenReturn(mockFeatureProposalList);
+        when(featureProposalRepo.findAll(any(FeatureProposalSpecification.class), any(Pageable.class))).thenReturn(mockPageableFeatureProposalList);
         when(featureProposalRepo.findOne(any(Long.class))).thenReturn(TEST_FEATURE_PROPOSAL1);
         when(featureProposalRepo.create(any(FeatureProposal.class), any(Credentials.class))).thenReturn(TEST_FEATURE_PROPOSAL1);
         when(featureProposalRepo.create(any(Idea.class))).thenReturn(TEST_FEATURE_PROPOSAL1);
@@ -94,6 +102,17 @@ public void setup() throws UserNotFoundException {
         doNothing().when(featureProposalRepo).delete(any(FeatureProposal.class));
     }
 
+    @Test
+    @SuppressWarnings("unchecked")
+    public void testPage() {
+        FilteredPageRequest mockFilter = new FilteredPageRequest();
+        response = featureProposalController.getAllFeatureProposalsByService(mockFilter);
+        assertEquals("Not successful at getting paged FeatureProposals", SUCCESS, response.getMeta().getStatus());
+
+        Page<FeatureProposal> page = (Page<FeatureProposal>) response.getPayload().get("PageImpl");
+        assertEquals("The paged list of FeatureProposals is the wrong length", mockPageableFeatureProposalList.getSize(), page.getSize());
+    }
+
     @Test
     public void testFeatureProposal() {
         response = featureProposalController.getFeatureProposal(TEST_FEATURE_PROPOSAL1.getId());

src/test/java/edu/tamu/app/controller/IdeaControllerTest.java

@@ -17,6 +17,9 @@
 import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.MockitoAnnotations;
+import org.springframework.data.domain.Page;
+import org.springframework.data.domain.PageImpl;
+import org.springframework.data.domain.Pageable;
 import org.springframework.messaging.simp.SimpMessagingTemplate;
 import org.springframework.test.context.ActiveProfiles;
 import org.springframework.test.context.junit4.SpringRunner;
@@ -29,6 +32,8 @@
 import edu.tamu.app.model.repo.IdeaRepo;
 import edu.tamu.app.model.repo.ServiceRepo;
 import edu.tamu.app.model.repo.UserRepo;
+import edu.tamu.app.model.repo.specification.IdeaSpecification;
+import edu.tamu.app.model.request.FilteredPageRequest;
 import edu.tamu.weaver.auth.model.Credentials;
 import edu.tamu.weaver.response.ApiResponse;
 
@@ -55,6 +60,7 @@ public class IdeaControllerTest {
     private static Idea TEST_IDEA3 = new Idea(TEST_IDEA_TITLE3, TEST_IDEA_DESCRIPTION3, TEST_USER1);
     private static Idea TEST_MODIFIED_IDEA = new Idea(TEST_MODIFIED_IDEA_TITLE, TEST_MODIFIED_IDEA_DESCRIPTION, TEST_USER2, TEST_SERVICE);
     private static List<Idea> mockIdeaList = new ArrayList<Idea>(Arrays.asList(new Idea[] { TEST_IDEA1, TEST_IDEA2, TEST_IDEA3 }));
+    private static Page<Idea> mockPageableIdeaList = new PageImpl<Idea>(Arrays.asList(new Idea[] { TEST_IDEA1, TEST_IDEA2, TEST_IDEA3 }));
 
     private static User user = new User("123456789");
 
@@ -79,11 +85,13 @@ public class IdeaControllerTest {
     private IdeaController ideaController;
 
     @Before
+    @SuppressWarnings("unchecked")
     public void setup() throws UserNotFoundException {
         MockitoAnnotations.initMocks(this);
         when(credentials.getUin()).thenReturn("123456789");
         when(userRepo.findByUsername(any(String.class))).thenReturn(Optional.of(user));
         when(ideaRepo.findAll()).thenReturn(mockIdeaList);
+        when(ideaRepo.findAll(any(IdeaSpecification.class), any(Pageable.class))).thenReturn(mockPageableIdeaList);
         when(ideaRepo.findOne(any(Long.class))).thenReturn(TEST_IDEA1);
         when(ideaRepo.create(any(Idea.class), any(Credentials.class))).thenReturn(TEST_IDEA1);
         when(ideaRepo.update(any(Idea.class))).thenReturn(TEST_MODIFIED_IDEA);
@@ -92,6 +100,17 @@ public void setup() throws UserNotFoundException {
         doNothing().when(ideaRepo).delete(any(Idea.class));
     }
 
+    @Test
+    @SuppressWarnings("unchecked")
+    public void testPage() {
+        FilteredPageRequest mockFilter = new FilteredPageRequest();
+        response = ideaController.page(mockFilter);
+        assertEquals("Not successful at getting paged Ideas", SUCCESS, response.getMeta().getStatus());
+
+        Page<Idea> page = (Page<Idea>) response.getPayload().get("PageImpl");
+        assertEquals("The paged list of Ideas is the wrong length", mockPageableIdeaList.getSize(), page.getSize());
+    }
+
     @Test
     public void testIdea() {
         response = ideaController.getById(TEST_IDEA1.getId());

src/test/java/edu/tamu/app/controller/NoteControllerTest.java

@@ -17,6 +17,9 @@
 import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.MockitoAnnotations;
+import org.springframework.data.domain.Page;
+import org.springframework.data.domain.PageImpl;
+import org.springframework.data.domain.Pageable;
 import org.springframework.messaging.simp.SimpMessagingTemplate;
 import org.springframework.test.context.ActiveProfiles;
 import org.springframework.test.context.junit4.SpringRunner;
@@ -30,6 +33,8 @@
 import edu.tamu.app.model.repo.NoteRepo;
 import edu.tamu.app.model.repo.ServiceRepo;
 import edu.tamu.app.model.repo.UserRepo;
+import edu.tamu.app.model.repo.specification.NoteSpecification;
+import edu.tamu.app.model.request.FilteredPageRequest;
 import edu.tamu.weaver.auth.model.Credentials;
 import edu.tamu.weaver.response.ApiResponse;
 
@@ -52,6 +57,7 @@ public class NoteControllerTest {
     private static Note TEST_NOTE3 = new Note(TEST_NOTE_TITLE3, TEST_USER1);
     private static Note TEST_MODIFIED_NOTE = new Note(TEST_MODIFIED_NOTE_TITLE, TEST_USER2, NoteType.ISSUE, "", TEST_SERVICE);
     private static List<Note> mockNoteList = new ArrayList<Note>(Arrays.asList(new Note[] { TEST_NOTE1, TEST_NOTE2, TEST_NOTE3 }));
+    private static Page<Note> mockPageableNoteList = new PageImpl<Note>(Arrays.asList(new Note[] { TEST_NOTE1, TEST_NOTE2, TEST_NOTE3  }));
 
     private static User user = new User("123456789");
 
@@ -76,11 +82,13 @@ public class NoteControllerTest {
     private NoteController noteController;
 
     @Before
+    @SuppressWarnings("unchecked")
     public void setup() throws UserNotFoundException {
         MockitoAnnotations.initMocks(this);
         when(credentials.getUin()).thenReturn("123456789");
         when(userRepo.findByUsername(any(String.class))).thenReturn(Optional.of(user));
         when(noteRepo.findAll()).thenReturn(mockNoteList);
+        when(noteRepo.findAll(any(NoteSpecification.class), any(Pageable.class))).thenReturn(mockPageableNoteList);
         when(noteRepo.findOne(any(Long.class))).thenReturn(TEST_NOTE1);
         when(noteRepo.create(any(Note.class), any(Credentials.class))).thenReturn(TEST_NOTE1);
         when(noteRepo.update(any(Note.class))).thenReturn(TEST_MODIFIED_NOTE);
@@ -89,6 +97,17 @@ public void setup() throws UserNotFoundException {
         doNothing().when(noteRepo).delete(any(Note.class));
     }
 
+    @Test
+    @SuppressWarnings("unchecked")
+    public void testPage() {
+        FilteredPageRequest mockFilter = new FilteredPageRequest();
+        response = noteController.page(mockFilter);
+        assertEquals("Not successful at getting paged Notes", SUCCESS, response.getMeta().getStatus());
+
+        Page<Note> page = (Page<Note>) response.getPayload().get("PageImpl");
+        assertEquals("The paged list of Notes is the wrong length", mockPageableNoteList.getSize(), page.getSize());
+    }
+
     @Test
     public void testNote() {
         response = noteController.getById(TEST_NOTE1.getId());