Add PHP strict type (#3032)

* Set php strict_types

* Fix type bug in test room int access code

* Fix broken attestation

* Fix time type in factories ´

* Fix saml attribute type

* Fix time casting on db:upgrade

* Fix progress on db:import

* Fix bbb_logo and bbb_logo_dark attribute handling

* Enforce name length checks before valid name regex

* Fix room_auth_token_type type casting

* Fix time casting in provisioning

* Add type to scopeWithRole

* Require name parameter for user search

* Add types to GL2 and GL3 import models and tests

* Fix Greenlight import test helpers

* Add type hints to arrays

---------

Co-authored-by: Sebastian Neuser <pzkz@infra.run>

Author: samuelwei

app/Auth/ExternalUser.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Auth;
 
 use App\Models\Role;
@@ -51,9 +53,9 @@ public function createOrFindEloquentModel(string $authenticator): User
      * Add a value to an attribute.
      *
      * @param  string  $name  The name of the attribute.
-     * @param  mixed  $value  The value to add to the attribute.
+     * @param  string|null  $value  The value to add to the attribute.
      */
-    public function addAttributeValue($name, $value)
+    public function addAttributeValue(string $name, ?string $value)
     {
         if (! isset($this->attributes[$name])) {
             $this->attributes[$name] = [];

app/Auth/LDAP/LDAPController.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Auth\LDAP;
 
 use App\Auth\MissingAttributeException;

app/Auth/LDAP/LDAPProvider.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Auth\LDAP;
 
 use Illuminate\Auth\EloquentUserProvider;

app/Auth/LDAP/LDAPServiceProvider.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Auth\LDAP;
 
 use Illuminate\Log\LogManager;

app/Auth/LDAP/LDAPUser.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Auth\LDAP;
 
 use App\Auth\ExternalUser;

app/Auth/LDAP/LDAPUserObject.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Auth\LDAP;
 
 use LdapRecord\Models\Model;

app/Auth/Local/LocalProvider.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Auth\Local;
 
 use Illuminate\Auth\EloquentUserProvider;

app/Auth/MissingAttributeException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Auth;
 
 class MissingAttributeException extends \Exception

app/Auth/OIDC/AccessTokenHashChecker.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Auth\OIDC;
 
 use Jose\Component\Checker\ClaimChecker;

app/Auth/OIDC/EventsChecker.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Auth\OIDC;
 
 use Jose\Component\Checker\ClaimChecker;