Skip to content

Commit a17adc6

Browse files
committed
feat(QTDI-1914): Clean labels and icons after refactoring.
1 parent 45f93fd commit a17adc6

45 files changed

Lines changed: 234 additions & 122 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

sample-parent/sample-features/loading-analysis/loading-dependencies-common/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
1818
<modelVersion>4.0.0</modelVersion>
1919
<parent>
20-
<groupId>org.talend.sdk.component.loadinganalysis</groupId>
20+
<groupId>org.talend.sdk.component.loading-analysis</groupId>
2121
<artifactId>loading-analysis</artifactId>
2222
<version>1.89.0-SNAPSHOT</version>
2323
</parent>

sample-parent/sample-features/loading-analysis/loading-dependencies-common/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/service/AbstractDynamicDependenciesService.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,10 @@ private List<Record> loadStandardDependencies(final DynamicDependencyConfig dyna
109109
// Add a class that should be imported by a 'standard' dependency (not a dynamic one)
110110
// to have an example from which classloaded it is loaded
111111
// In that case the version doesn't matter.
112-
dependencies.add(new Dependency("org.talend.sdk.samplefeature.dynamicdependencies",
113-
"dynamic-dependencies-common",
112+
dependencies.add(new Dependency("org.talend.sdk.component.loading-analysis",
113+
"loading-dependencies-common",
114114
"N/A",
115-
"org.talend.sdk.component.sample.feature.dynamicdependencies.config.Dependency"));
115+
"org.talend.sdk.component.sample.feature.loadinganalysis.config.Dependency"));
116116

117117
// This is a hardcoded dependency to check how are loaded dependencies
118118
// provided by the runtime

sample-parent/sample-features/loading-analysis/loading-dependencies-common/src/test/java/org/talend/sdk/component/sample/feature/loadinganalysis/AbstractDynamicDependenciesServiceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ void setUp() {
5555
}
5656

5757
@Test
58-
void testloadIterator() {
58+
void testLoadIterator() {
5959
System.setProperty("talend.component.manager.m2.repository", "./lib/");
6060

6161
final Iterator<Record> result = getService().loadIterator(config);

sample-parent/sample-features/loading-analysis/loading-dependencies-with-dataprepRunAnnotation/pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<modelVersion>4.0.0</modelVersion>
1818

1919
<parent>
20-
<groupId>org.talend.sdk.component.loadinganalysis</groupId>
20+
<groupId>org.talend.sdk.component.loading-analysis</groupId>
2121
<artifactId>loading-analysis</artifactId>
2222
<version>1.89.0-SNAPSHOT</version>
2323
</parent>
@@ -28,13 +28,13 @@
2828

2929
<dependencies>
3030
<dependency>
31-
<groupId>org.talend.sdk.component.loadinganalysis</groupId>
31+
<groupId>org.talend.sdk.component.loading-analysis</groupId>
3232
<artifactId>loading-dependencies-common</artifactId>
3333
<version>${project.version}</version>
3434
</dependency>
3535
<!-- Test -->
3636
<dependency>
37-
<groupId>org.talend.sdk.component.loadinganalysis</groupId>
37+
<groupId>org.talend.sdk.component.loading-analysis</groupId>
3838
<artifactId>loading-dependencies-common</artifactId>
3939
<version>${project.version}</version>
4040
<type>test-jar</type>

sample-parent/sample-features/loading-analysis/loading-dependencies-with-dataprepRunAnnotation/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withDataprepRunAnnotation/package-info.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616
@Components(
17-
family = "DynamicDependenciesWithDataprepAnnotation",
17+
family = "LoadingDependenciesWithDataprepAnnotation",
1818
categories = "sample")
1919
@Icon(value = Icon.IconType.CUSTOM, custom = "icon")
2020
package org.talend.sdk.component.sample.feature.loadinganalysis.withDataprepRunAnnotation;

sample-parent/sample-features/loading-analysis/loading-dependencies-with-dataprepRunAnnotation/src/main/resources/icons/dark/icon.svg

Lines changed: 2 additions & 4 deletions
Loading

sample-parent/sample-features/loading-analysis/loading-dependencies-with-dataprepRunAnnotation/src/main/resources/icons/light/icon.svg

Lines changed: 2 additions & 4 deletions
Loading

sample-parent/sample-features/loading-analysis/loading-dependencies-with-dataprepRunAnnotation/src/main/resources/org/talend/sdk/component/sample/feature/loadinganalysis/withDataprepRunAnnotation/Messages.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@
1414
# Here you can change all your configuration display names to use more explicit labels
1515
# You can also translate your configuration by adding one file by local Messages_fr.properties for french for example
1616

17-
DynamicDependenciesWithDataprepAnnotation.datastore.dyndepsdso._displayName = Datastore for dynamic dependencies with datapreprun
18-
DynamicDependenciesWithDataprepAnnotation.dataset.dyndepsdse._displayName = Dataset for dynamic dependencies with datapreprun
17+
LoadingDependenciesWithDataprepAnnotation.datastore.dyndepsdso._displayName = Datastore for loading dependencies with datapreprun
18+
LoadingDependenciesWithDataprepAnnotation.dataset.dyndepsdse._displayName = Dataset for loading dependencies with datapreprun

sample-parent/sample-features/loading-analysis/loading-dependencies-with-dataprepRunAnnotation/src/main/resources/org/talend/sdk/component/sample/feature/loadinganalysis/withDataprepRunAnnotation/config/Messages.properties

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@
1717
Dataset.dso._displayName =
1818
Dataset.dependencies._displayName = Dynamic dependencies
1919
Config.dse._displayName =
20-
Config.dieOnError._displayName = Die on error
21-
Config.environmentInformation._displayName = Environment information
2220
Config.subConfig._displayName =
2321
SubConfig.dependencies._displayName = Dependencies
2422
SubConfig.connectors._displayName = Connectors dynamically loaded

sample-parent/sample-features/loading-analysis/loading-dependencies-with-dataprepRunAnnotation/src/main/resources/org/talend/sdk/component/sample/feature/loadinganalysis/withDataprepRunAnnotation/input/Messages.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@
1414
# Here you can change all your configuration display names to use more explicit labels
1515
# You can also translate your configuration by adding one file by local Messages_fr.properties for french for example
1616

17-
DynamicDependenciesWithDataprepAnnotation.Input._displayName = Dynamic Dependencies With DataprepRun annotation Input
17+
LoadingDependenciesWithDataprepAnnotation.Input._displayName = Loading Dependencies With DataprepRun annotation Input

0 commit comments

Comments
 (0)