Skip to content

Commit eca1d82

Browse files
committed
fix(query-devtools/Devtools): correct the Theme sub-trigger className from 'position' to 'theme'
1 parent 93e7d39 commit eca1d82

3 files changed

Lines changed: 17 additions & 13 deletions

File tree

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@tanstack/query-devtools': patch
3+
---
4+
5+
Fix the Theme sub-trigger's marker class in the devtools settings menu, which was incorrectly mirroring the Position sub-trigger's class so the two could not be styled independently.

packages/query-devtools/src/Devtools.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1192,7 +1192,7 @@ export const ContentView: Component<ContentViewProps> = (props) => {
11921192
class={cx(
11931193
styles().settingsSubTrigger,
11941194
'tsqd-settings-menu-sub-trigger',
1195-
'tsqd-settings-menu-sub-trigger-position',
1195+
'tsqd-settings-menu-sub-trigger-theme',
11961196
)}
11971197
>
11981198
<span>Theme</span>

packages/query-devtools/src/__tests__/Devtools.test.tsx

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1078,12 +1078,13 @@ describe('Devtools', () => {
10781078
key: 'Enter',
10791079
})
10801080

1081-
const themeTrigger = Array.from(
1082-
document.querySelectorAll<HTMLElement>(
1083-
'.tsqd-settings-menu-sub-trigger',
1084-
),
1085-
).find((el) => String(el.textContent).includes('Theme'))
1086-
expect(themeTrigger).not.toBeUndefined()
1081+
const themeTrigger = document.querySelector<HTMLElement>(
1082+
'.tsqd-settings-menu-sub-trigger-theme',
1083+
)
1084+
expect(themeTrigger).not.toBeNull()
1085+
expect(themeTrigger).not.toBe(
1086+
document.querySelector('.tsqd-settings-menu-sub-trigger-position'),
1087+
)
10871088
fireEvent.keyDown(themeTrigger!, { key: 'ArrowRight' })
10881089

10891090
expect(
@@ -1098,12 +1099,10 @@ describe('Devtools', () => {
10981099
key: 'Enter',
10991100
})
11001101

1101-
const themeTrigger = Array.from(
1102-
document.querySelectorAll<HTMLElement>(
1103-
'.tsqd-settings-menu-sub-trigger',
1104-
),
1105-
).find((el) => String(el.textContent).includes('Theme'))
1106-
expect(themeTrigger).not.toBeUndefined()
1102+
const themeTrigger = document.querySelector<HTMLElement>(
1103+
'.tsqd-settings-menu-sub-trigger-theme',
1104+
)
1105+
expect(themeTrigger).not.toBeNull()
11071106
fireEvent.keyDown(themeTrigger!, { key: 'ArrowRight' })
11081107

11091108
const themeMenu = document.querySelector(

0 commit comments

Comments
 (0)