Skip to content

Commit 5b8ea89

Browse files
committed
Simplify our code by using std::cout from ESP32-S3 runtime environment.
The runtime environment bundled within the [GCC Toolchain for Espressif ESP32-S3 Xtensa MCUs](https://registry.platformio.org/tools/espressif/toolchain-xtensa-esp32s3) apparently already maps `std::cout` to serial interface. No need to maintain our own version of it.
1 parent 7b7bf98 commit 5b8ea89

3 files changed

Lines changed: 2 additions & 72 deletions

File tree

lib/3rd_party_adapters/Arduino/SerialOutputStreamBuffer.cpp

Lines changed: 0 additions & 35 deletions
This file was deleted.

lib/3rd_party_adapters/Arduino/SerialOutputStreamBuffer.hpp

Lines changed: 0 additions & 31 deletions
This file was deleted.

lib/3rd_party_adapters/Arduino/serial_port.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,16 @@
1-
#include "SerialOutputStreamBuffer.hpp"
21
#include <Arduino.h>
2+
#include <iostream>
33
#include <iterator>
44
#include <serial_interface/serial_port.hpp>
55
#include <type_traits>
66

7-
static SerialOutputStreamBuffer::char_type serial_output_buffer[255];
8-
static SerialOutputStreamBuffer serialOutputStreamBuffer(std::begin(serial_output_buffer), std::end(serial_output_buffer));
9-
static std::basic_ostream<SerialOutputStreamBuffer::char_type> serialOutputStream(&serialOutputStreamBuffer);
10-
117
namespace serial_port
128
{
139
static_assert(std::is_same_v<CharType, std::remove_cv_t<std::remove_reference_t<decltype(*Serial.readString().c_str())>>>);
1410

1511
static StringHandler incomingStringHandler;
1612

17-
std::basic_ostream<CharType> &cout = serialOutputStream;
13+
std::basic_ostream<CharType> &cout = std::cout;
1814

1915
void initialize()
2016
{

0 commit comments

Comments
 (0)