Use static where applicable.

dhebbeker · dhebbeker · commit dac7266b5006 · 2024-06-01T20:11:11.000+02:00
diff --git a/lib/3rd_party_adapters/nlohmann/JsonGenerator.cpp b/lib/3rd_party_adapters/nlohmann/JsonGenerator.cpp
@@ -5,7 +5,7 @@
 #include <serial_protocol/TaskList.hpp>
 #include <serial_protocol/TaskObject.hpp>
 
-constexpr int defaultJsonIndent = 4;
+static constexpr int defaultJsonIndent = 4;
 
 template <>
 std::string toJsonString<task_tracker_systems::ProtocolVersionObject>(const task_tracker_systems::ProtocolVersionObject &object)
@@ -19,7 +19,7 @@ std::string toJsonString<task_tracker_systems::ProtocolVersionObject>(const task
 
 namespace task_tracker_systems
 {
-void to_json(nlohmann::json &jsonObject, const task_tracker_systems::TaskObject &object)
+static void to_json(nlohmann::json &jsonObject, const task_tracker_systems::TaskObject &object)
 {
     jsonObject["id"] = object.id;
     jsonObject["label"] = object.label;

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`#include <serial_protocol/TaskList.hpp>`
`6`	`6`	`#include <serial_protocol/TaskObject.hpp>`
`7`	`7`
`8`		`-constexpr int defaultJsonIndent = 4;`
	`8`	`+static constexpr int defaultJsonIndent = 4;`
`9`	`9`
`10`	`10`	`template <>`
`11`	`11`	`std::string toJsonString<task_tracker_systems::ProtocolVersionObject>(const task_tracker_systems::ProtocolVersionObject &object)`
`@@ -19,7 +19,7 @@ std::string toJsonString<task_tracker_systems::ProtocolVersionObject>(const task`
`19`	`19`
`20`	`20`	`namespace task_tracker_systems`
`21`	`21`	`{`
`22`		`-void to_json(nlohmann::json &jsonObject, const task_tracker_systems::TaskObject &object)`
	`22`	`+static void to_json(nlohmann::json &jsonObject, const task_tracker_systems::TaskObject &object)`
`23`	`23`	`{`
`24`	`24`	`jsonObject["id"] = object.id;`
`25`	`25`	`jsonObject["label"] = object.label;`