Use intermediate vector of iterators.

Author: dhebbeker

lib/3rd_party_adapters/nlohmann/JsonGenerator.cpp

@@ -39,7 +39,12 @@ std::string toJsonString<task_tracker_systems::TaskObject>(const task_tracker_sy
 template <>
 std::string toJsonString<device::TaskCollection>(const device::TaskCollection &object)
 {
-    nlohmann::json jsonObject(TaskObjectIterator(std::begin(object)), TaskObjectIterator(std::end(object)));
+    std::vector<TaskObjectIterator> itList;
+    for (auto it = std::cbegin(object); it != std::cend(object); ++it)
+    {
+        itList.emplace_back(it);
+    }
+    nlohmann::json jsonObject(itList);
     return jsonObject.dump(defaultJsonIndent);
 }
 

lib/application_business_rules/serial_interface/Protocol.cpp

@@ -28,11 +28,7 @@ static const auto info = []() {
 static const auto infoCmd = cli::makeCommand("info", std::function(info));
 
 // command for list
-static const auto list = []() { std::vector<TaskObjectIterator> itList;
-std::for_each(std::cbegin(device::tasks), std::cend(device::tasks), [&itList](auto it){
-    itList.emplace_back(it);
-});
-                                        serial_port::cout << toJsonString(itList) << std::endl; };
+static const auto list = []() { serial_port::cout << toJsonString(device::tasks) << std::endl; };
 static const auto listCmd = cli::makeCommand("list", std::function(list));
 
 // command for edit