replace serialEvent() (#126)

Resolves #115

Author: FiveTeethless

lib/3rd_party_adapters/Arduino/serial_port.cpp

@@ -44,12 +44,7 @@ void setCallbackForLineReception(const StringHandler &callback)
 
 } // namespace serial_port
 
-/*
-  SerialEvent occurs whenever a new data comes in the hardware serial RX. This
-  routine is run between each time loop() runs, so using delay inside loop can
-  delay response. Multiple bytes of data may be available.
-*/
-void serialEvent()
+void serial_port::readAndHandleInput()
 {
     while (Serial.available() > 0)
     {

lib/application_business_rules/serial_interface/serial_port.hpp

@@ -33,7 +33,7 @@ void initialize();
 /**
  * Reads a line from serial port.
  * 
- * Interprets the end of line as `\n`.
+ * Expects the end of line to be `\n`.
  * It will wait for data for the duration of the timeout.
  * \returns an empty string in case no data is read
  */
@@ -42,7 +42,7 @@ String readLine();
 /**
  * Gets a line from serial port.
  * 
- * Interprets the end of line as `\n`.
+ * Expects the end of line to be `\n`.
  * \returns an object that does not contain a value in case no data is already available.
  */
 std::optional<String> getLine();
@@ -58,6 +58,8 @@ typedef std::function<void(const String &)> StringHandler;
  */
 void setCallbackForLineReception(const StringHandler &callback);
 
+void readAndHandleInput();
+
 } // namespace serial_port
 
 /**

src/main.cpp

@@ -32,6 +32,8 @@ void loop()
     static Presenter presenter(singleMenu, board::getStatusIndicators());
     static ProcessHmiInputs processHmiInputs(presenter, board::getKeypad());
 
+    serial_port::readAndHandleInput();
+
     for (auto task : device::tasks)
     {
         serial_port::cout << task.second.getLabel() << " : " << std::boolalpha << task.second.isRunning()