Skip to content

Commit 4046995

Browse files
sujata-msujata-m
committed
Fixed review comments
1 parent ae4315b commit 4046995

3 files changed

Lines changed: 19 additions & 19 deletions

File tree

‎README.md‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -344,28 +344,28 @@ test_unknown_config_storage (test_config.test_cofig.TestUnknownConfig) ... ok
344344
test_unknown_config_storage_connection_default (test_config.test_cofig.TestUnknownConfig) ... ok
345345
test_unknown_config_topic (test_config.test_cofig.TestUnknownConfig) ... ok
346346
test_unknown_config_topic_connection_default (test_config.test_cofig.TestUnknownConfig) ... ok
347-
test_get_authorizer_no_config (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialization core.get_logger for provider: SIMULATED
347+
test_get_authorizer_no_config (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialize core.get_logger for provider: SIMULATED
348348
ok
349-
test_get_authorizer_with_config_hosted_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialization core.get_logger for provider: AZURE
349+
test_get_authorizer_with_config_hosted_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialize core.get_logger for provider: AZURE
350350
ok
351-
test_get_authorizer_with_config_simulated_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialization core.get_logger for provider: SIMULATED
351+
test_get_authorizer_with_config_simulated_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialize core.get_logger for provider: SIMULATED
352352
ok
353-
test_get_authorizer_with_config_unknown_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialization core.get_logger for provider: UNKNOWN
353+
test_get_authorizer_with_config_unknown_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialize core.get_logger for provider: UNKNOWN
354354
ok
355-
test_get_logger_azure_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialization core.get_logger for provider: AZURE
355+
test_get_logger_azure_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialize core.get_logger for provider: AZURE
356356
ok
357357
test_get_logger_local_provider (test_core.TestCore) ... ok
358-
test_get_logger_unknown_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialization core.get_logger for provider: UNKNOWN
358+
test_get_logger_unknown_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialize core.get_logger for provider: UNKNOWN
359359
ok
360-
test_get_storage_client_azure_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialization core.get_logger for provider: AZURE
360+
test_get_storage_client_azure_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialize core.get_logger for provider: AZURE
361361
ok
362362
test_get_storage_client_local_provider (test_core.TestCore) ... ok
363-
test_get_storage_client_unknown_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialization core.get_logger for provider: UNKNOWN
363+
test_get_storage_client_unknown_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialize core.get_logger for provider: UNKNOWN
364364
ok
365-
test_get_topic_azure_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialization core.get_logger for provider: AZURE
365+
test_get_topic_azure_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialize core.get_logger for provider: AZURE
366366
ok
367367
test_get_topic_local_provider (test_core.TestCore) ... ok
368-
test_get_topic_unknown_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialization core.get_logger for provider: UNKNOWN
368+
test_get_topic_unknown_provider (test_core.TestCore) ... 2023-07-03 18:07:41 ERROR Failed to initialize core.get_logger for provider: UNKNOWN
369369
ok
370370
test_add_request (test_logger.abstract.test_logger_abstract.TestLoggerAbstract) ... ok
371371
test_debug (test_logger.abstract.test_logger_abstract.TestLoggerAbstract) ... ok

‎src/python_ms_core/__init__.py‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def __init__(self, config=None):
2525
self.__check_health()
2626
else:
2727
self.config = UnknownConfig(provider=config)
28-
logging.error(f'Failed to initialization core.get_logger for provider: {config}')
28+
logging.error(f'Failed to initialize core.get_logger for provider: {config}')
2929
else:
3030
self.config = CoreConfig()
3131
self.__check_health()
@@ -37,7 +37,7 @@ def get_logger(self):
3737
elif logger_config.provider.upper() == AZURE_ENV:
3838
return Logger(config=logger_config)
3939
else:
40-
logging.error(f'Failed to initialization core.get_logger for provider: {logger_config.provider}')
40+
logging.error(f'Failed to initialize core.get_logger for provider: {logger_config.provider}')
4141

4242
def get_topic(self, topic_name: str):
4343
topic_config = self.config.topic()
@@ -46,7 +46,7 @@ def get_topic(self, topic_name: str):
4646
elif topic_config.provider.upper() == AZURE_ENV:
4747
return Topic(config=topic_config, topic_name=topic_name)
4848
else:
49-
logging.error(f'Failed to initialization core.get_topic for provider: {topic_config.provider}')
49+
logging.error(f'Failed to initialize core.get_topic for provider: {topic_config.provider}')
5050

5151
def get_storage_client(self):
5252
storage_config = self.config.storage()
@@ -55,7 +55,7 @@ def get_storage_client(self):
5555
elif storage_config.provider.upper() == AZURE_ENV:
5656
return AzureStorageClient(storage_config)
5757
else:
58-
logging.error(f'Failed to initialization core.get_storage_client for provider: {storage_config.provider}')
58+
logging.error(f'Failed to initialize core.get_storage_client for provider: {storage_config.provider}')
5959

6060
def get_authorizer(self, config: dict = None):
6161
if config is None:
@@ -69,7 +69,7 @@ def get_authorizer(self, config: dict = None):
6969
elif auth_config.provider.upper() == HOSTED_ENV:
7070
return HostedAuthorizer(config=auth_config)
7171
else:
72-
logging.error(f'Failed to initialization core.get_authorizer for provider: {auth_config.provider}')
72+
logging.error(f'Failed to initialize core.get_authorizer for provider: {auth_config.provider}')
7373

7474
def __check_health(self):
7575
print('\x1b[32m ------------------------- \x1b[0m')

‎tests/unit_tests/test_core.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ def test_get_logger_unknown_provider(self):
3535
with patch('logging.error') as mock_logging_error:
3636
logger = core.get_logger()
3737
mock_logging_error.assert_called_once_with(
38-
f'Failed to initialization core.get_logger for provider: {UNKNOWN_ENV}')
38+
f'Failed to initialize core.get_logger for provider: {UNKNOWN_ENV}')
3939

4040
def test_get_topic_local_provider(self):
4141
core = Core(config=LOCAL_ENV)
@@ -57,7 +57,7 @@ def test_get_topic_unknown_provider(self):
5757
with patch('logging.error') as mock_logging_error:
5858
topic = core.get_topic('mock_topic')
5959
mock_logging_error.assert_called_once_with(
60-
f'Failed to initialization core.get_topic for provider: {UNKNOWN_ENV}')
60+
f'Failed to initialize core.get_topic for provider: {UNKNOWN_ENV}')
6161

6262
def test_get_storage_client_local_provider(self):
6363
core = Core(config=LOCAL_ENV)
@@ -78,7 +78,7 @@ def test_get_storage_client_unknown_provider(self):
7878
with patch('logging.error') as mock_logging_error:
7979
storage_client = core.get_storage_client()
8080
mock_logging_error.assert_called_once_with(
81-
f'Failed to initialization core.get_storage_client for provider: {UNKNOWN_ENV}')
81+
f'Failed to initialize core.get_storage_client for provider: {UNKNOWN_ENV}')
8282

8383
def test_get_authorizer_no_config(self):
8484
core = Core(config=SIMULATED_ENV)
@@ -103,7 +103,7 @@ def test_get_authorizer_with_config_unknown_provider(self):
103103
with patch('logging.error') as mock_logging_error:
104104
authorizer = core.get_authorizer(config=config)
105105
mock_logging_error.assert_called_once_with(
106-
f'Failed to initialization core.get_authorizer for provider: {UNKNOWN_ENV}')
106+
f'Failed to initialize core.get_authorizer for provider: {UNKNOWN_ENV}')
107107

108108

109109
if __name__ == '__main__':

0 commit comments

Comments
 (0)