ci: Improved test reports

Author: NelsonBN

.github/workflows/tests.yml

@@ -22,6 +22,11 @@ jobs:
   test-project:
     name: "Test nuget"
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      issues: read
+      checks: write
+      pull-requests: write
 
     steps:
     - name: "Checkout"
@@ -42,10 +47,64 @@ jobs:
       run: dotnet build --configuration Release --no-restore
 
     - name: "Run tests"
-      run: dotnet test --configuration Release --no-build --verbosity normal --results-directory ${{ env.TEST_RESULTS_DIRECTORY }} --logger "junit;LogFileName=test-result-$(uuidgen).xml" --logger "console;verbosity=detailed"
+      run: dotnet test --configuration Release --no-build --verbosity normal --results-directory ${{ env.TEST_RESULTS_DIRECTORY }} --collect:"XPlat Code Coverage"
 
-    - name: "Publish test results"
-      uses: test-summary/action@v2
+    - name: "Combine Coverage Reports" # This is because one report is produced per project, and we want one result for all of them.
+      uses: danielpalme/ReportGenerator-GitHub-Action@5.2.4
+      with:
+        reports: "**/*.cobertura.xml" # REQUIRED # The coverage reports that should be parsed (separated by semicolon). Globbing is supported.
+        targetdir: "${{ github.workspace }}" # REQUIRED # The directory where the generated report should be saved.
+        reporttypes: "Cobertura" # The output formats and scope (separated by semicolon) Values: Badges, Clover, Cobertura, CsvSummary, Html, Html_Dark, Html_Light, Html_BlueRed, HtmlChart, HtmlInline, HtmlInline_AzurePipelines, HtmlInline_AzurePipelines_Dark, HtmlInline_AzurePipelines_Light, HtmlSummary, JsonSummary, Latex, LatexSummary, lcov, MarkdownSummary, MarkdownSummaryGithub, MarkdownDeltaSummary, MHtml, PngChart, SonarQube, TeamCitySummary, TextSummary, TextDeltaSummary, Xml, XmlSummary
+        verbosity: "Info" # The verbosity level of the log messages. Values: Verbose, Info, Warning, Error, Off
+        title: "Code Coverage" # Optional title.
+        tag: "${{ github.run_number }}_${{ github.run_id }}" # Optional tag or build version.
+        customSettings: "" # Optional custom settings (separated by semicolon). See: https://github.com/danielpalme/ReportGenerator/wiki/Settings.
+        toolpath: "reportgeneratortool" # Default directory for installing the dotnet tool.
+
+    - name: "Upload Combined Coverage"
+      uses: actions/upload-artifact@v4
+      with:
+        name: 'Coverage'
+        path: ${{ github.workspace }}/Cobertura.xml
+
+    - name: "Publish code coverage report"
+      uses: irongut/CodeCoverageSummary@v1.3.0
+      with:
+        filename: "Cobertura.xml"
+        badge: true
+        fail_below_min: false # just informative for now
+        format: markdown
+        hide_branch_rate: false
+        hide_complexity: false
+        indicators: true
+        output: both
+        thresholds: "10 30"
+
+    - name: "Add Coverage PR Comment"
+      uses: marocchino/sticky-pull-request-comment@v2
+      if: github.event_name == 'pull_request'
+      with:
+        recreate: true
+        path: code-coverage-results.md
+
+    - name: "Upload Test Results"
+      uses: actions/upload-artifact@v4
+      with:
+        name: 'TestResults'
+        path: ${{ env.TEST_RESULTS_DIRECTORY }}/**/*
+
+    - name: "Publish Test Tesults"
+      uses: dorny/test-reporter@v1
+      if: always()
+      with:
+        name: "Test Results"
+        path: "${{ env.TEST_RESULTS_DIRECTORY }}/**/*.trx"
+        reporter: dotnet-trx
+
+    - name: "Publish Test Summary"
+      uses: EnricoMi/publish-unit-test-result-action@v2.16.1
       if: always()
       with:
-        paths: "${{ env.TEST_RESULTS_DIRECTORY }}/**/*.xml"
+        check_name: "Test Summary"
+        # NOTE: using trx_files instead of files due to https://github.com/EnricoMi/publish-unit-test-result-action/issues/424
+        trx_files: "${{ env.TEST_RESULTS_DIRECTORY }}/**/*.trx"

tests/PowerUtils.AspNetCore.ErrorHandler.Tests/PowerUtils.AspNetCore.ErrorHandler.Tests.csproj

@@ -11,6 +11,7 @@
 
 
   <PropertyGroup>
+    <VSTestLogger>trx%3bLogFileName=$(MSBuildProjectName)_$(TargetFramework).trx</VSTestLogger>
     <DefaultItemExcludes>$(DefaultItemExcludes);coverage.*opencover.xml</DefaultItemExcludes>
   </PropertyGroup>
 
@@ -43,7 +44,6 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="JunitXml.TestLogger" Version="3.1.12" />
   </ItemGroup>
 
   <ItemGroup Condition=" '$(TargetFramework)' == 'net7.0' ">