fix: method to format properties to camel case when property end with . or is null

Author: NelsonBN

src/ProblemDetailsFactory.cs

@@ -74,12 +74,6 @@ private IDictionary<string, string> _mappingModelState(ModelStateDictionary mode
 
         private (string Property, string Error) _mappingModelStateError(KeyValuePair<string, ModelStateEntry> modelStateError)
         {
-            var error = modelStateError
-                .Value
-                .Errors
-                .Select(s => s.ErrorMessage)
-                .First();
-
             if(modelStateError.Key.StartsWith("$."))
             {
                 return (
@@ -88,6 +82,12 @@ private IDictionary<string, string> _mappingModelState(ModelStateDictionary mode
                 );
             }
 
+            var error = modelStateError
+                .Value
+                .Errors
+                .Select(s => s.ErrorMessage)
+                .First();
+
             return _checkRequestBody(modelStateError.Key, error);
         }
 
@@ -117,6 +117,11 @@ private string _formatPropertyName(string propertyName)
 
         private static string _formatPropertyToCamelCase(string propertyName)
         {
+            if(string.IsNullOrWhiteSpace(propertyName))
+            {
+                return "";
+            }
+
             var propertyParts = propertyName.Split('.');
             if(propertyParts.Length == 1)
             {
@@ -126,6 +131,12 @@ private static string _formatPropertyToCamelCase(string propertyName)
 
             for(var count = 0; count < propertyParts.Length; count++)
             {
+                // Prevent System.IndexOutOfRangeException: 'Index was outside the bounds of the array.' for cases "Hello."
+                if(propertyParts[count].Length == 0)
+                {
+                    continue;
+                }
+
                 propertyParts[count] = char.ToLowerInvariant(propertyParts[count][0]) + propertyParts[count][1..];
             }
 

tests/PowerUtils.AspNetCore.ErrorHandler.Tests/ProblemDetailsFactoryTests.cs

@@ -110,4 +110,96 @@ public void PropertyNamingPolicy_SnakeCase_FormattedCamelCase()
         // Assert
         act.Should().Be("prop_name.prop_value");
     }
+
+    [Fact(DisplayName = "Format to camel case null value - Should return empty")]
+    public void FormatPropertyToCamelCase_Null_Empty()
+    {
+        // Arrange
+        string propertyName = null;
+
+
+        // Act
+        var act = ObjectInvoker.Invoke<string>(typeof(ProblemDetailsFactory), "_formatPropertyToCamelCase", propertyName);
+
+
+        // Assert
+        act.Should().BeEmpty();
+    }
+
+    [Fact(DisplayName = "Format to camel case empty value - Should return empty")]
+    public void FormatPropertyToCamelCase_Empty_Empty()
+    {
+        // Arrange
+        var propertyName = "";
+
+
+        // Act
+        var act = ObjectInvoker.Invoke<string>(typeof(ProblemDetailsFactory), "_formatPropertyToCamelCase", propertyName);
+
+
+        // Assert
+        act.Should().BeEmpty();
+    }
+
+    [Fact(DisplayName = "Format to camel case white spaces value - Should return empty")]
+    public void FormatPropertyToCamelCase_WhiteSpaces_Empty()
+    {
+        // Arrange
+        var propertyName = "  ";
+
+
+        // Act
+        var act = ObjectInvoker.Invoke<string>(typeof(ProblemDetailsFactory), "_formatPropertyToCamelCase", propertyName);
+
+
+        // Assert
+        act.Should().BeEmpty();
+    }
+
+    [Fact(DisplayName = "Format to camel case white one character - Should return the character lowercase")]
+    public void FormatPropertyToCamelCase_OneCharacter_Lower()
+    {
+        // Arrange
+        var propertyName = "G";
+
+
+        // Act
+        var act = ObjectInvoker.Invoke<string>(typeof(ProblemDetailsFactory), "_formatPropertyToCamelCase", propertyName);
+
+
+        // Assert
+        act.Should().Be("g");
+    }
+
+    [Fact(DisplayName = "Format to camel case a text with only one dot - Should return a dot")]
+    public void FormatPropertyToCamelCase_OnlyOneDot_Dot()
+    {
+        // Arrange
+        var propertyName = ".";
+
+
+        // Act
+        var act = ObjectInvoker.Invoke<string>(typeof(ProblemDetailsFactory), "_formatPropertyToCamelCase", propertyName);
+
+
+        // Assert
+        act.Should().Be(".");
+    }
+
+
+
+    [Fact(DisplayName = "Format to camel case a text ended with an dot - Should format")]
+    public void FormatPropertyToCamelCase_EndWitDot_Format()
+    {
+        // Arrange
+        var propertyName = "Hello.";
+
+
+        // Act
+        var act = ObjectInvoker.Invoke<string>(typeof(ProblemDetailsFactory), "_formatPropertyToCamelCase", propertyName);
+
+
+        // Assert
+        act.Should().Be("hello.");
+    }
 }