Skip to content

Commit 74ac683

Browse files
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent aaa4169 commit 74ac683

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

content/1.posts/66.developer-experience-thoughts.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,4 +56,4 @@ With [Pulumi](https://www.pulumi.com/product/infrastructure-as-code/) you can au
5656

5757
I’m not saying you should use these technologies, it depends on your context and preferences. These are just 2 examples of technologies that I love, partly due to their developer experience and why it matters.
5858

59-
So, what’s next ? I want to start a new series of articles “Aspirations” talking about [Aspire](https://learn.microsoft.com/en-us/dotnet/aspire/get-started/aspire-overview?wt.mc_id=MVP_430820). Aspire primarily aims at improving the local development experience when developing modern .NET applications (distributed or not). That seems an interesting topic to keep talking about developer experience. See you in the next article, and keep learning.
59+
So, what’s next? I want to start a new series of articles “Aspirations” talking about [Aspire](https://learn.microsoft.com/en-us/dotnet/aspire/get-started/aspire-overview?wt.mc_id=MVP_430820). Aspire primarily aims at improving the local development experience when developing modern .NET applications (distributed or not). That seems an interesting topic to keep talking about developer experience. See you in the next article, and keep learning.

content/1.posts/71.aspire-open-telemetry.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ That's great, but if we want to see telemetry from our web application, we first
2727

2828
The [OpenTelemetry SDK for .NET](https://github.com/open-telemetry/opentelemetry-dotnet) includes everything we need to collect the telemetry data (logs, traces, metrics). So we could directly install the nuget packages in the `WebApi` project, and implement the code to configure the instrumentation and use the Aspire dashboard OTLP endpoint. It would work, and if you already have an app using OpenTelemetry, you likely only need to make a few configuration changes to make it compatible with the Aspire dashboard.
2929

30-
In our case, we will use instead a [Aspire service defaults project](https://learn.microsoft.com/en-us/dotnet/aspire/fundamentals/service-defaults?wt.mc_id=MVP_430820) to set everything up easily. The purpose of using this Aspire Shared project is to offer predefined extension methods that help configure things like OpenTelemetry, health check endpoints, retry policies, and more across the various services and resources that make up the application. Let’s create this project using the `aspire-servicedefaults` template (from the [Aspire template](https://learn.microsoft.com/en-us/dotnet/aspire/fundamentals/aspire-sdk-templates?pivots=dotnet-cli&wt.mc_id=MVP_430820)) and reference it in the `WebApi` project.
30+
In our case, we will use instead an [Aspire service defaults project](https://learn.microsoft.com/en-us/dotnet/aspire/fundamentals/service-defaults?wt.mc_id=MVP_430820) to set everything up easily. The purpose of using this Aspire Shared project is to offer predefined extension methods that help configure things like OpenTelemetry, health check endpoints, retry policies, and more across the various services and resources that make up the application. Let’s create this project using the `aspire-servicedefaults` template (from the [Aspire template](https://learn.microsoft.com/en-us/dotnet/aspire/fundamentals/aspire-sdk-templates?pivots=dotnet-cli&wt.mc_id=MVP_430820)) and reference it in the `WebApi` project.
3131

3232
```bash
3333
dotnet new aspire-servicedefaults -o ServiceDefaults
@@ -218,7 +218,7 @@ And with just that, we can now see both the traces from the `WebApi` and the `We
218218

219219
![Traces of the WebApi and WebApp in the Aspire dashboard.](/posts/images/71.aspire-otel_7.png){.rounded-lg.mx-auto}
220220

221-
![Details of a traces in the Aspire dashboard.](/posts/images/71.aspire-otel_8.png){.rounded-lg.mx-auto}
221+
![Details of a trace in the Aspire dashboard.](/posts/images/71.aspire-otel_8.png){.rounded-lg.mx-auto}
222222

223223
::callout{icon="i-heroicons-light-bulb"}
224224
Please note that traces are correlated when using client side rendering (like on the screenshot above), but not when using server side rendering. There is probably an additional thing to configure in the Nuxt instrumentation.

content/1.posts/73.aspire-devcert.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ What we would need instead is to use environment variables that contain these pa
5656

5757
That seems better. But now we need a way to ensure the certificate files exist, generate them if they don’t, and automatically inject these environment variables. Ideally, this would be configured in the `AppHost` by calling a specific method when defining the `WebApp` resource.
5858

59-
And guess what, there is an [issue](https://github.com/dotnet/aspire/issues/6890) on the Aspire GitHub repository discussing exactly such a method. Unfortunately, at the time of writing this method is not built-in but can be found in the [`aspire-samples` repository](https://github.com/dotnet/aspire-samples/blob/0c27e4e3bac5f102db1002fd2e0e1ba894e1009a/samples/Shared/DevCertHostingExtensions.cs). We just need to copy it and place it in our `AppHost` project
59+
And guess what, there is an [issue](https://github.com/dotnet/aspire/issues/6890) on the Aspire GitHub repository discussing exactly such a method. Unfortunately, at the time of writing this method is not built-in but can be found in the [`aspire-samples` repository](https://github.com/dotnet/aspire-samples/blob/0c27e4e3bac5f102db1002fd2e0e1ba894e1009a/samples/Shared/DevCertHostingExtensions.cs). We just need to copy it and place it in our `AppHost` project.
6060

6161
::collapsible{openText="Show the code of the" closeText="Hide the code of the" name="DevCertHostingExtensions.cs file"}
6262

0 commit comments

Comments
 (0)