Skip to content

Commit 1d94d71

Browse files
committed
jnr-unixsocket: Re-enabled some unit tests
1 parent e7f0ed6 commit 1d94d71

6 files changed

Lines changed: 6 additions & 10 deletions

File tree

dbus-java-utils/src/main/java/org/freedesktop/dbus/bin/Caller.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@
2020

2121
import org.freedesktop.dbus.Marshalling;
2222
import org.freedesktop.dbus.connections.BusAddress;
23-
import org.freedesktop.dbus.connections.Transport;
23+
import org.freedesktop.dbus.connections.transports.AbstractTransport;
24+
import org.freedesktop.dbus.connections.transports.TransportFactory;
2425
import org.freedesktop.dbus.errors.Error;
2526
import org.freedesktop.dbus.messages.Message;
2627
import org.freedesktop.dbus.messages.MethodCall;
@@ -34,7 +35,7 @@ private Caller() {
3435
public static void main(String[] args) {
3536
String addr = System.getenv("DBUS_SESSION_BUS_ADDRESS");
3637

37-
try (Transport conn = new Transport(new BusAddress(addr))) {
38+
try (AbstractTransport conn = TransportFactory.createTransport(new BusAddress(addr))) {
3839
if (args.length < 4) {
3940
System.out.println("Syntax: Caller <dest> <path> <interface> <method> [<sig> <args>]");
4041
System.exit(1);

dbus-java/src/main/java/org/freedesktop/dbus/connections/AbstractConnection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ protected AbstractConnection(String address) throws DBusException {
153153
} catch (IOException | DBusException ioe) {
154154
logger.debug("Error creating transport", ioe);
155155
disconnect();
156-
throw new DBusException("Failed to connect to bus " + ioe.getMessage(), ioe);
156+
throw new DBusException("Failed to connect to bus: " + ioe.getMessage(), ioe);
157157
}
158158
run = true;
159159

dbus-java/src/test/java/org/freedesktop/dbus/test/TestDisconnectStuff.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,11 @@
88
import org.freedesktop.dbus.exceptions.NotConnected;
99
import org.freedesktop.dbus.test.helper.SampleClass;
1010
import org.freedesktop.dbus.test.helper.interfaces.SampleRemoteInterface;
11-
import org.junit.jupiter.api.Disabled;
1211
import org.junit.jupiter.api.Test;
1312

1413
public class TestDisconnectStuff {
1514

1615
@Test
17-
@Disabled("Fails when run in maven combined with all other tests, but runs as standalone")
1816
public void testStuffAfterDisconnect() throws DBusException, InterruptedException {
1917

2018
DBusConnection serverConnection = DBusConnection.getConnection(DBusBusType.SESSION);

dbus-java/src/test/java/org/freedesktop/dbus/test/TestPeer2Peer.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import org.freedesktop.dbus.test.helper.P2pTestServer;
1313
import org.freedesktop.dbus.test.helper.SampleException;
1414
import org.freedesktop.dbus.test.helper.interfaces.SampleRemoteInterface;
15-
import org.junit.jupiter.api.Disabled;
1615
import org.junit.jupiter.api.Test;
1716

1817
public class TestPeer2Peer {
@@ -22,7 +21,6 @@ public class TestPeer2Peer {
2221
private static final String CONNECTION_ADDRESS = DirectConnection.createDynamicSession();
2322

2423
@Test
25-
@Disabled
2624
public void testP2p() throws InterruptedException {
2725
P2pServer p2pServer = new P2pServer();
2826
p2pServer.start();

dbus-java/src/test/java/org/freedesktop/dbus/test/TestTwoPart.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import org.freedesktop.dbus.test.helper.interfaces.TwoPartObject;
1212
import org.freedesktop.dbus.test.helper.twopart.TwoPartTestClient.TwoPartTestObject;
1313
import org.freedesktop.dbus.test.helper.twopart.TwoPartTestServer;
14-
import org.junit.jupiter.api.Disabled;
1514
import org.junit.jupiter.api.Test;
1615

1716
public class TestTwoPart {
@@ -20,13 +19,12 @@ public class TestTwoPart {
2019
private volatile boolean serverReady = false;
2120

2221
@Test
23-
@Disabled("sporadically fails due to timeout")
2422
public void testTwoPart() throws InterruptedException {
2523
TwoPartServer twoPartServer = new TwoPartServer();
2624
twoPartServer.start();
2725

2826
while (!serverReady) {
29-
Thread.sleep(500L);
27+
Thread.sleep(1500L);
3028
}
3129

3230
try {

dbus-java/src/test/resources/logback.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
<logger name="org.freedesktop.dbus.errors" level="INFO" />
1616
<logger name="org.freedesktop.dbus.messages" level="INFO" />
1717
<logger name="org.freedesktop.dbus.MessageWriter" level="INFO" />
18+
<logger name="org.freedesktop.dbus.connections.SASL" level="INFO" />
1819

1920
<logger name="org.freedesktop.dbus.bin" level="INFO" />
2021

0 commit comments

Comments
 (0)