Fix #287: terminate scheduler on abort to prevent HALT hang

Koan-Bot · claude · Koan-Bot · commit bf85ebc24801 · 2026-03-30T20:04:27.000-06:00
When abort() kills child jobs, the scheduler itself was not being
terminated. This left yath hanging after a BAIL_OUT event, requiring
ctrl+c to exit. Adding $self-&gt;terminate(1) after the kill loop
ensures the scheduler exits its main loop once abort completes.

Safe with --no-abort-on-bail: that flag gates job_update() (which
never calls abort()), not the abort() method itself.

Also replaces stub test files with real unit tests:
- Scheduler.t: 7 subtests covering abort, kill, terminate, and
  selective run abort behavior
- Command.t: base class behavior (name derivation, run, set_dot_args,
  constructor)
- Command/init.t: run() creates test.pl, overwrites generated files,
  rejects non-generated files
- Command/failed.t: run() parses JSONL logs, detects failures, brief
  mode, input validation
- Command/times.t: run() displays timing data, sorts by duration,
  input validation
- Command/help.t: run() produces command listing output

Adds integration test for BAIL_OUT termination.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/Makefile.PL b/Makefile.PL
@@ -150,7 +150,7 @@ my %WriteMakefileArgs = (
   },
   "VERSION" => "2.000010",
   "test" => {
-    "TESTS" => "t/*.t t/JUnit/*.t t/UI/*.t t/database/*.t t/integration/*.t t/integration/signals/*.t t/unit/App/*.t t/unit/App/Yath/*.t t/unit/App/Yath/Command/*.t t/unit/App/Yath/Command/client/*.t t/unit/App/Yath/Command/db/*.t t/unit/App/Yath/Options/*.t t/unit/App/Yath/Plugin/*.t t/unit/App/Yath/Renderer/*.t t/unit/App/Yath/Renderer/Default/*.t t/unit/App/Yath/Resource/*.t t/unit/App/Yath/Resource/SharedJobSlots/*.t t/unit/App/Yath/Schema/*.t t/unit/App/Yath/Schema/MariaDB/*.t t/unit/App/Yath/Schema/MySQL/*.t t/unit/App/Yath/Schema/Overlay/*.t t/unit/App/Yath/Schema/Percona/*.t t/unit/App/Yath/Schema/PostgreSQL/*.t t/unit/App/Yath/Schema/Result/*.t t/unit/App/Yath/Schema/SQLite/*.t t/unit/App/Yath/Server/*.t t/unit/App/Yath/Server/Controller/*.t t/unit/App/Yath/Server/Util/*.t t/unit/App/Yath/Theme/*.t t/unit/TAP/Harness/*.t t/unit/TAP/Harness/Yath/*.t t/unit/Test2/*.t t/unit/Test2/EventFacet/*.t t/unit/Test2/Formatter/*.t t/unit/Test2/Harness/*.t t/unit/Test2/Harness/Collector/*.t t/unit/Test2/Harness/Collector/Auditor/*.t t/unit/Test2/Harness/Collector/IOParser/*.t t/unit/Test2/Harness/IPC/*.t t/unit/Test2/Harness/IPC/Protocol/*.t t/unit/Test2/Harness/IPC/Protocol/AtomicPipe/*.t t/unit/Test2/Harness/IPC/Protocol/IPSocket/*.t t/unit/Test2/Harness/IPC/Protocol/UnixSocket/*.t t/unit/Test2/Harness/Instance/*.t t/unit/Test2/Harness/Log/*.t t/unit/Test2/Harness/Log/CoverageAggregator/*.t t/unit/Test2/Harness/Preload/*.t t/unit/Test2/Harness/Reloader/*.t t/unit/Test2/Harness/Resource/*.t t/unit/Test2/Harness/Run/*.t t/unit/Test2/Harness/Runner/*.t t/unit/Test2/Harness/Runner/Preloading/*.t t/unit/Test2/Harness/Scheduler/*.t t/unit/Test2/Harness/Util/*.t t/unit/Test2/Harness/Util/File/*.t t/unit/Test2/Tools/*.t"
+    "TESTS" => "t/*.t t/JUnit/*.t t/UI/*.t t/database/*.t t/integration/*.t t/integration/signals/*.t t/unit/App/*.t t/unit/App/Yath/*.t t/unit/App/Yath/Command/*.t t/unit/App/Yath/Command/client/*.t t/unit/App/Yath/Command/db/*.t t/unit/App/Yath/Options/*.t t/unit/App/Yath/Plugin/*.t t/unit/App/Yath/Renderer/*.t t/unit/App/Yath/Renderer/Default/*.t t/unit/App/Yath/Resource/*.t t/unit/App/Yath/Resource/SharedJobSlots/*.t t/unit/App/Yath/Schema/*.t t/unit/App/Yath/Schema/MariaDB/*.t t/unit/App/Yath/Schema/MySQL/*.t t/unit/App/Yath/Schema/Overlay/*.t t/unit/App/Yath/Schema/Percona/*.t t/unit/App/Yath/Schema/PostgreSQL/*.t t/unit/App/Yath/Schema/Result/*.t t/unit/App/Yath/Schema/SQLite/*.t t/unit/App/Yath/Server/*.t t/unit/App/Yath/Server/Controller/*.t t/unit/App/Yath/Server/Util/*.t t/unit/App/Yath/Theme/*.t t/unit/Getopt/Yath/*.t t/unit/Getopt/Yath/Option/*.t t/unit/Getopt/Yath/Settings/*.t t/unit/TAP/Harness/*.t t/unit/TAP/Harness/Yath/*.t t/unit/Test2/*.t t/unit/Test2/EventFacet/*.t t/unit/Test2/Formatter/*.t t/unit/Test2/Harness/*.t t/unit/Test2/Harness/Collector/*.t t/unit/Test2/Harness/Collector/Auditor/*.t t/unit/Test2/Harness/Collector/IOParser/*.t t/unit/Test2/Harness/IPC/*.t t/unit/Test2/Harness/IPC/Protocol/*.t t/unit/Test2/Harness/IPC/Protocol/AtomicPipe/*.t t/unit/Test2/Harness/IPC/Protocol/IPSocket/*.t t/unit/Test2/Harness/IPC/Protocol/UnixSocket/*.t t/unit/Test2/Harness/Instance/*.t t/unit/Test2/Harness/Log/*.t t/unit/Test2/Harness/Log/CoverageAggregator/*.t t/unit/Test2/Harness/Preload/*.t t/unit/Test2/Harness/Reloader/*.t t/unit/Test2/Harness/Resource/*.t t/unit/Test2/Harness/Run/*.t t/unit/Test2/Harness/Runner/*.t t/unit/Test2/Harness/Runner/Preloading/*.t t/unit/Test2/Harness/Scheduler/*.t t/unit/Test2/Harness/Util/*.t t/unit/Test2/Harness/Util/File/*.t t/unit/Test2/Tools/*.t"
   }
 );
 
diff --git a/lib/Test2/Harness/Scheduler.pm b/lib/Test2/Harness/Scheduler.pm
@@ -307,6 +307,9 @@ sub abort {
         CORE::kill('TERM', $pid);
         $job->{killed} = 1;
     }
+
+    # Also terminate the scheduler itself, as BAIL_OUT means we should exit
+    $self->terminate(1);
 }
 
 sub kill {
diff --git a/t/integration/bailout.t b/t/integration/bailout.t
@@ -0,0 +1,49 @@
+use Test2::V0;
+# HARNESS-DURATION-LONG
+
+use App::Yath::Tester qw/yath/;
+use Test2::Plugin::Immiscible(sub { $ENV{TEST2_HARNESS_ACTIVE} ? 1 : 0 });
+
+my $dir = __FILE__;
+$dir =~ s{\.t$}{}g;
+$dir =~ s{^\./}{};
+
+# Test that BAIL_OUT causes yath to exit (not hang)
+# Regression test for https://github.com/Test-More/Test2-Harness/issues/287
+yath(
+    command => 'test',
+    args    => [$dir, '--ext=tx'],
+    exit    => T(),
+    test    => sub {
+        my $out = shift;
+        ok($out->{exit}, "yath exits with non-zero when BAIL_OUT is encountered");
+        like($out->{output}, qr/BAIL_OUT|bail|halt/i, "output mentions bail/halt");
+    },
+);
+
+# Test that BAIL_OUT is ignored when --no-abort-on-bail is set
+yath(
+    command => 'test',
+    args    => [$dir, '--ext=tx', '--no-abort-on-bail'],
+    exit    => T(),
+    test    => sub {
+        my $out = shift;
+        # The test still fails (BAIL_OUT is a failure), but yath should
+        # not abort the entire suite — just the bailing test fails
+        ok($out->{exit}, "yath exits non-zero (test still fails)");
+    },
+);
+
+# Test that when BAIL_OUT is disabled via env, everything passes
+yath(
+    command => 'test',
+    args    => [$dir, '--ext=tx'],
+    env     => {BAILOUT_DO_PASS => 1},
+    exit    => 0,
+    test    => sub {
+        my $out = shift;
+        ok(!$out->{exit}, "yath exits cleanly when BAIL_OUT is not triggered");
+    },
+);
+
+done_testing;
diff --git a/t/integration/bailout/bail.tx b/t/integration/bailout/bail.tx
@@ -0,0 +1,11 @@
+use Test2::Tools::Tiny;
+use strict;
+use warnings;
+
+ok(1, "a passing test before bail");
+
+BAIL_OUT("Something went horribly wrong") unless $ENV{BAILOUT_DO_PASS};
+
+ok(1, "should not reach here");
+
+done_testing;
diff --git a/t/integration/bailout/pass.tx b/t/integration/bailout/pass.tx
@@ -0,0 +1,7 @@
+use Test2::Tools::Tiny;
+use strict;
+use warnings;
+
+ok(1, "this test always passes");
+
+done_testing;
diff --git a/t/unit/App/Yath/Command.t b/t/unit/App/Yath/Command.t
@@ -1,5 +1,84 @@
 use Test2::V0 -target => 'App::Yath::Command';
 
-skip_all "write me";
+subtest 'name() derives from package name' => sub {
+    is(CLASS->name, 'App::Yath::Command', 'base class returns full package name when no prefix match');
+
+    {
+        package App::Yath::Command::testcmd;
+        use parent 'App::Yath::Command';
+    }
+    is(App::Yath::Command::testcmd->name, 'testcmd', 'single-level subclass returns short name');
+
+    {
+        package App::Yath::Command::foo::bar;
+        use parent 'App::Yath::Command';
+    }
+    is(App::Yath::Command::foo::bar->name, 'foo-bar', 'nested namespace uses hyphen separator');
+
+    my $obj = CLASS->new();
+    is($obj->name, 'App::Yath::Command', 'name() works on instance');
+};
+
+subtest 'group()' => sub {
+    is(CLASS->group, 'Z-FIXME', 'base class returns Z-FIXME when no prefix');
+
+    {
+        package App::Yath::Command::sub::cmd;
+        use parent 'App::Yath::Command';
+    }
+    is(App::Yath::Command::sub::cmd->group, undef, 'subcommand (contains hyphen in name) returns undef');
+};
+
+subtest 'default metadata' => sub {
+    is(CLASS->summary,     'No Summary',     'default summary');
+    is(CLASS->description, 'No Description', 'default description');
+};
+
+subtest 'boolean flags default to 0' => sub {
+    is(CLASS->accepts_dot_args,   0, 'accepts_dot_args defaults to 0');
+    is(CLASS->args_include_tests, 0, 'args_include_tests defaults to 0');
+    is(CLASS->internal_only,      0, 'internal_only defaults to 0');
+    is(CLASS->load_plugins,       0, 'load_plugins defaults to 0');
+    is(CLASS->load_resources,     0, 'load_resources defaults to 0');
+    is(CLASS->load_renderers,     0, 'load_renderers defaults to 0');
+};
+
+subtest 'cli_args and cli_dot return undef by default' => sub {
+    is(CLASS->cli_args, undef, 'cli_args returns undef');
+    is(CLASS->cli_dot,  undef, 'cli_dot returns undef');
+};
+
+subtest 'run() warns and returns 1' => sub {
+    my $obj = CLASS->new();
+    my $warned = 0;
+    local $SIG{__WARN__} = sub { $warned++ };
+    my $ret = $obj->run();
+    is($ret,    1, 'run() returns 1');
+    is($warned, 1, 'run() emits a warning');
+};
+
+subtest 'set_dot_args() croaks' => sub {
+    my $obj = CLASS->new();
+    like(
+        dies { $obj->set_dot_args() },
+        qr/set_dot_args is not implemented/,
+        'set_dot_args croaks with expected message',
+    );
+};
+
+subtest 'constructor attributes' => sub {
+    my $obj = CLASS->new(
+        settings     => { foo => 1 },
+        args         => [qw/a b/],
+        env_vars     => { PATH => '/usr/bin' },
+        option_state => {},
+        plugins      => [],
+    );
+    is($obj->settings,     { foo => 1 },   'settings set via constructor');
+    is($obj->args,         [qw/a b/],      'args set via constructor');
+    is($obj->env_vars,     { PATH => '/usr/bin' }, 'env_vars set via constructor');
+    is($obj->option_state, {},             'option_state set via constructor');
+    is($obj->plugins,      [],             'plugins set via constructor');
+};
 
 done_testing;
diff --git a/t/unit/App/Yath/Command/failed.t b/t/unit/App/Yath/Command/failed.t
@@ -1,5 +1,135 @@
 use Test2::V0 -target => 'App::Yath::Command::failed';
 
-skip_all "write me";
+use File::Temp qw/tempdir/;
+use Test2::Harness::Util::File::JSONL;
+use Getopt::Yath::Settings;
+
+my $dir = tempdir(CLEANUP => 1);
+
+sub make_log {
+    my (@events) = @_;
+    my $file = "$dir/test_$$.jsonl";
+    my $log = Test2::Harness::Util::File::JSONL->new(name => $file);
+    $log->write(@events);
+    return $file;
+}
+
+sub make_settings {
+    my (%opts) = @_;
+    return Getopt::Yath::Settings->new({
+        failed => { brief => $opts{brief} // 0 },
+    });
+}
+
+subtest 'run() with no failures' => sub {
+    my $logfile = make_log(
+        {
+            stamp      => 1,
+            job_id     => 'job1',
+            facet_data => {
+                harness_job_end => { rel_file => 't/pass.t', fail => 0 },
+            },
+        },
+    );
+
+    my $obj = CLASS->new(
+        settings => make_settings(),
+        args     => [$logfile],
+    );
+
+    my $ret;
+    my $out = intercept { $ret = $obj->run() };
+    is($ret, 0, 'run() returns 0');
+};
+
+subtest 'run() detects failed tests' => sub {
+    my $logfile = make_log(
+        {
+            stamp      => 1,
+            job_id     => 'job1',
+            facet_data => {
+                harness_job_end => { rel_file => 't/fail.t', fail => 1 },
+            },
+        },
+        {
+            stamp      => 2,
+            job_id     => 'job2',
+            facet_data => {
+                harness_job_end => { rel_file => 't/pass.t', fail => 0 },
+            },
+        },
+    );
+
+    my $obj = CLASS->new(
+        settings => make_settings(),
+        args     => [$logfile],
+    );
+
+    my $ret;
+    my $stdout = '';
+    {
+        local *STDOUT;
+        open(STDOUT, '>', \$stdout) or die $!;
+        $ret = $obj->run();
+    }
+
+    is($ret, 0, 'run() returns 0');
+    like($stdout, qr/fail\.t/, 'output includes the failed test file');
+    unlike($stdout, qr/pass\.t/, 'output does not include the passing test file');
+};
+
+subtest 'run() brief mode prints only failed filenames' => sub {
+    my $logfile = make_log(
+        {
+            stamp      => 1,
+            job_id     => 'job1',
+            facet_data => {
+                harness_job_end => { rel_file => 't/fail.t', fail => 1 },
+            },
+        },
+    );
+
+    my $obj = CLASS->new(
+        settings => make_settings(brief => 1),
+        args     => [$logfile],
+    );
+
+    my $ret;
+    my $stdout = '';
+    {
+        local *STDOUT;
+        open(STDOUT, '>', \$stdout) or die $!;
+        $ret = $obj->run();
+    }
+
+    is($ret, 0, 'run() returns 0');
+    like($stdout, qr{t/fail\.t}, 'brief mode prints the failed filename');
+};
+
+subtest 'run() dies without a log file argument' => sub {
+    my $obj = CLASS->new(
+        settings => make_settings(),
+        args     => [],
+    );
+
+    like(
+        dies { $obj->run() },
+        qr/must specify a log file/i,
+        'dies with helpful message when no log file given',
+    );
+};
+
+subtest 'run() dies for invalid log file' => sub {
+    my $obj = CLASS->new(
+        settings => make_settings(),
+        args     => ['/nonexistent/file.jsonl'],
+    );
+
+    like(
+        dies { $obj->run() },
+        qr/not a valid log file/,
+        'dies for nonexistent log file',
+    );
+};
 
 done_testing;
diff --git a/t/unit/App/Yath/Command/help.t b/t/unit/App/Yath/Command/help.t
@@ -1,5 +1,46 @@
 use Test2::V0 -target => 'App::Yath::Command::help';
 
-skip_all "write me";
+use Getopt::Yath::Settings;
+
+subtest 'run() returns 0 and produces command listing' => sub {
+    my $settings = Getopt::Yath::Settings->new({
+        help => { verbose => 0 },
+        yath => { script => 'yath' },
+    });
+
+    my $obj = CLASS->new(
+        settings => $settings,
+        args     => [],
+    );
+
+    my $ret;
+    my $stdout = '';
+    {
+        local *STDOUT;
+        open(STDOUT, '>', \$stdout) or die $!;
+        $ret = $obj->run();
+    }
+
+    is($ret, 0, 'run() returns 0');
+    like($stdout, qr/Usage:/, 'output includes Usage line');
+    like($stdout, qr/COMMANDS:/i, 'output includes COMMANDS section');
+    like($stdout, qr/help/, 'output lists the help command itself');
+};
+
+subtest 'command_table returns formatted string' => sub {
+    my $settings = Getopt::Yath::Settings->new({
+        help => { verbose => 0 },
+        yath => { script => 'yath' },
+    });
+
+    my $obj = CLASS->new(
+        settings => $settings,
+        args     => [],
+    );
+
+    my $table = $obj->command_table;
+    ok(defined $table, 'command_table returns a value');
+    like($table, qr/COMMANDS:/i, 'table contains COMMANDS heading');
+};
 
 done_testing;
diff --git a/t/unit/App/Yath/Command/init.t b/t/unit/App/Yath/Command/init.t
diff --git a/t/unit/App/Yath/Command/times.t b/t/unit/App/Yath/Command/times.t
diff --git a/t/unit/Test2/Harness/Scheduler.t b/t/unit/Test2/Harness/Scheduler.t

Original file line number	Diff line number	Diff line change
`@@ -150,7 +150,7 @@ my %WriteMakefileArgs = (`
`150`	`150`	`},`
`151`	`151`	`"VERSION" => "2.000010",`
`152`	`152`	`"test" => {`
`153`		- "TESTS" => "t/.t t/JUnit/.t t/UI/.t t/database/.t t/integration/.t t/integration/signals/.t t/unit/App/.t t/unit/App/Yath/.t t/unit/App/Yath/Command/.t t/unit/App/Yath/Command/client/.t t/unit/App/Yath/Command/db/.t t/unit/App/Yath/Options/.t t/unit/App/Yath/Plugin/.t t/unit/App/Yath/Renderer/.t t/unit/App/Yath/Renderer/Default/.t t/unit/App/Yath/Resource/.t t/unit/App/Yath/Resource/SharedJobSlots/.t t/unit/App/Yath/Schema/.t t/unit/App/Yath/Schema/MariaDB/.t t/unit/App/Yath/Schema/MySQL/.t t/unit/App/Yath/Schema/Overlay/.t t/unit/App/Yath/Schema/Percona/.t t/unit/App/Yath/Schema/PostgreSQL/.t t/unit/App/Yath/Schema/Result/.t t/unit/App/Yath/Schema/SQLite/.t t/unit/App/Yath/Server/.t t/unit/App/Yath/Server/Controller/.t t/unit/App/Yath/Server/Util/.t t/unit/App/Yath/Theme/.t t/unit/TAP/Harness/.t t/unit/TAP/Harness/Yath/.t t/unit/Test2/.t t/unit/Test2/EventFacet/.t t/unit/Test2/Formatter/.t t/unit/Test2/Harness/.t t/unit/Test2/Harness/Collector/.t t/unit/Test2/Harness/Collector/Auditor/.t t/unit/Test2/Harness/Collector/IOParser/.t t/unit/Test2/Harness/IPC/.t t/unit/Test2/Harness/IPC/Protocol/.t t/unit/Test2/Harness/IPC/Protocol/AtomicPipe/.t t/unit/Test2/Harness/IPC/Protocol/IPSocket/.t t/unit/Test2/Harness/IPC/Protocol/UnixSocket/.t t/unit/Test2/Harness/Instance/.t t/unit/Test2/Harness/Log/.t t/unit/Test2/Harness/Log/CoverageAggregator/.t t/unit/Test2/Harness/Preload/.t t/unit/Test2/Harness/Reloader/.t t/unit/Test2/Harness/Resource/.t t/unit/Test2/Harness/Run/.t t/unit/Test2/Harness/Runner/.t t/unit/Test2/Harness/Runner/Preloading/.t t/unit/Test2/Harness/Scheduler/.t t/unit/Test2/Harness/Util/.t t/unit/Test2/Harness/Util/File/.t t/unit/Test2/Tools/.t"
	`153`	+ "TESTS" => "t/.t t/JUnit/.t t/UI/.t t/database/.t t/integration/.t t/integration/signals/.t t/unit/App/.t t/unit/App/Yath/.t t/unit/App/Yath/Command/.t t/unit/App/Yath/Command/client/.t t/unit/App/Yath/Command/db/.t t/unit/App/Yath/Options/.t t/unit/App/Yath/Plugin/.t t/unit/App/Yath/Renderer/.t t/unit/App/Yath/Renderer/Default/.t t/unit/App/Yath/Resource/.t t/unit/App/Yath/Resource/SharedJobSlots/.t t/unit/App/Yath/Schema/.t t/unit/App/Yath/Schema/MariaDB/.t t/unit/App/Yath/Schema/MySQL/.t t/unit/App/Yath/Schema/Overlay/.t t/unit/App/Yath/Schema/Percona/.t t/unit/App/Yath/Schema/PostgreSQL/.t t/unit/App/Yath/Schema/Result/.t t/unit/App/Yath/Schema/SQLite/.t t/unit/App/Yath/Server/.t t/unit/App/Yath/Server/Controller/.t t/unit/App/Yath/Server/Util/.t t/unit/App/Yath/Theme/.t t/unit/Getopt/Yath/.t t/unit/Getopt/Yath/Option/.t t/unit/Getopt/Yath/Settings/.t t/unit/TAP/Harness/.t t/unit/TAP/Harness/Yath/.t t/unit/Test2/.t t/unit/Test2/EventFacet/.t t/unit/Test2/Formatter/.t t/unit/Test2/Harness/.t t/unit/Test2/Harness/Collector/.t t/unit/Test2/Harness/Collector/Auditor/.t t/unit/Test2/Harness/Collector/IOParser/.t t/unit/Test2/Harness/IPC/.t t/unit/Test2/Harness/IPC/Protocol/.t t/unit/Test2/Harness/IPC/Protocol/AtomicPipe/.t t/unit/Test2/Harness/IPC/Protocol/IPSocket/.t t/unit/Test2/Harness/IPC/Protocol/UnixSocket/.t t/unit/Test2/Harness/Instance/.t t/unit/Test2/Harness/Log/.t t/unit/Test2/Harness/Log/CoverageAggregator/.t t/unit/Test2/Harness/Preload/.t t/unit/Test2/Harness/Reloader/.t t/unit/Test2/Harness/Resource/.t t/unit/Test2/Harness/Run/.t t/unit/Test2/Harness/Runner/.t t/unit/Test2/Harness/Runner/Preloading/.t t/unit/Test2/Harness/Scheduler/.t t/unit/Test2/Harness/Util/.t t/unit/Test2/Harness/Util/File/.t t/unit/Test2/Tools/*.t"
`154`	`154`	`}`
`155`	`155`	`);`
`156`	`156`
Original file line number	Diff line number	Diff line change
`@@ -307,6 +307,9 @@ sub abort {`
`307`	`307`	`CORE::kill('TERM', $pid);`
`308`	`308`	`$job->{killed} = 1;`
`309`	`309`	`}`
	`310`	`+`
	`311`	`+ # Also terminate the scheduler itself, as BAIL_OUT means we should exit`
	`312`	`+ $self->terminate(1);`
`310`	`313`	`}`
`311`	`314`
`312`	`315`	`sub kill {`