Skip to content

Commit d512fba

Browse files
Koan-BotKoan-Bot
committed
rebase: apply review feedback on #330
ly tests with `run()` behavior tests** for 6 subclass commands that have simple, mockable `run()` methods: - **abort.t, kill.t, stop.t** — mock `App::Yath::Client`, verify the correct client method (`abort()`, `kill()`, `stop()`) is called and return values are correct - **reload.t** — mock `App::Yath::Client`, verify `reload()` is called, returns 0, prints status messages - **do.t** — verify `run()` dies with "This should not be reachable" (stub command) - **which.t** — mock `App::Yath::IPC`, test both "no daemon found" and "daemon found" paths with output verification - **Reverted 26 subclass tests to `skip_all` stubs** — commands requiring complex infrastructure (forking, infinite loops, database/web server deps, log file fixtures) cannot be meaningfully unit-tested for `run()` behavior, and their metadata-only tests provided false coverage - **`Carp::Always` removal** (inline review comments on `server.pm` and `cpanfile`) — already resolved by the previous rebase onto `2.0`
1 parent 318117f commit d512fba

32 files changed

Lines changed: 118 additions & 706 deletions

‎t/unit/App/Yath/Command/abort.t‎

Lines changed: 11 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,17 @@
11
use Test2::V0 -target => 'App::Yath::Command::abort';
22

3-
subtest 'metadata' => sub {
4-
is(CLASS->name, 'abort', 'name');
5-
is(CLASS->group, 'daemon', 'group');
6-
ok(CLASS->summary, 'summary is non-empty');
7-
ok(CLASS->description, 'description is non-empty');
8-
};
9-
10-
subtest 'flags' => sub {
11-
is(CLASS->accepts_dot_args, 0, 'accepts_dot_args is 0');
12-
is(CLASS->args_include_tests, 0, 'args_include_tests is 0');
13-
is(CLASS->load_plugins, 0, 'load_plugins is 0');
14-
is(CLASS->load_resources, 0, 'load_resources is 0');
15-
is(CLASS->load_renderers, 0, 'load_renderers is 0');
16-
};
17-
18-
subtest 'cli_args' => sub {
19-
is(CLASS->cli_args, '', 'cli_args is empty string');
20-
};
3+
subtest 'run() calls client->abort()' => sub {
4+
my $called = 0;
5+
my $mock = mock 'App::Yath::Client' => (
6+
override => [
7+
new => sub { bless {}, 'App::Yath::Client' },
8+
abort => sub { $called++; return },
9+
],
10+
);
2111

22-
subtest 'inheritance' => sub {
23-
ok(CLASS->isa('App::Yath::Command'), 'is a App::Yath::Command');
12+
my $obj = CLASS->new(settings => {});
13+
$obj->run();
14+
is($called, 1, 'run() invokes abort() on the client');
2415
};
2516

2617
done_testing;

‎t/unit/App/Yath/Command/client/publish.t‎

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,5 @@
11
use Test2::V0 -target => 'App::Yath::Command::client::publish';
22

3-
subtest 'metadata' => sub {
4-
is(CLASS->name, 'client-publish', 'name');
5-
my $group = CLASS->group;
6-
ok(ref($group) eq 'ARRAY', 'group is an arrayref (multiple groups)');
7-
ok((grep { $_ eq 'web client' } @$group), 'group includes web client');
8-
ok((grep { $_ eq 'log parsing' } @$group), 'group includes log parsing');
9-
ok(CLASS->summary, 'summary is non-empty');
10-
ok(CLASS->description, 'description is non-empty');
11-
};
12-
13-
subtest 'flags' => sub {
14-
is(CLASS->accepts_dot_args, 0, 'accepts_dot_args is 0');
15-
is(CLASS->args_include_tests, 0, 'args_include_tests is 0');
16-
is(CLASS->load_plugins, 0, 'load_plugins is 0');
17-
is(CLASS->load_resources, 0, 'load_resources is 0');
18-
is(CLASS->load_renderers, 0, 'load_renderers is 0');
19-
};
20-
21-
subtest 'inheritance' => sub {
22-
ok(CLASS->isa('App::Yath::Command'), 'is a App::Yath::Command');
23-
};
3+
skip_all "write me";
244

255
done_testing;

‎t/unit/App/Yath/Command/client/recent.t‎

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,5 @@
11
use Test2::V0 -target => 'App::Yath::Command::client::recent';
22

3-
subtest 'metadata' => sub {
4-
is(CLASS->name, 'client-recent', 'name');
5-
my $group = CLASS->group;
6-
ok(ref($group) eq 'ARRAY', 'group is an arrayref (multiple groups)');
7-
ok((grep { $_ eq 'web client' } @$group), 'group includes web client');
8-
ok((grep { $_ eq 'history' } @$group), 'group includes history');
9-
ok(CLASS->summary, 'summary is non-empty');
10-
ok(CLASS->description, 'description is non-empty');
11-
};
12-
13-
subtest 'flags' => sub {
14-
is(CLASS->accepts_dot_args, 0, 'accepts_dot_args is 0');
15-
is(CLASS->args_include_tests, 0, 'args_include_tests is 0');
16-
};
17-
18-
subtest 'cli_args' => sub {
19-
is(CLASS->cli_args, '', 'cli_args is empty string');
20-
};
21-
22-
subtest 'inheritance' => sub {
23-
ok(CLASS->isa('App::Yath::Command'), 'is a App::Yath::Command');
24-
ok(CLASS->isa('App::Yath::Command::recent'), 'is a App::Yath::Command::recent');
25-
};
3+
skip_all "write me";
264

275
done_testing;

‎t/unit/App/Yath/Command/db.t‎

Lines changed: 2 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,5 @@
1-
use Test2::V0;
1+
use Test2::V0 -target => 'App::Yath::Command::db';
22

3-
BEGIN {
4-
eval { require App::Yath::Command::db };
5-
if ($@) {
6-
my ($missing) = $@ =~ m{Can't locate (\S+\.pm)};
7-
$missing //= 'a required module';
8-
$missing =~ s{/}{::}g; $missing =~ s{\.pm$}{};
9-
skip_all("App::Yath::Command::db requires $missing");
10-
}
11-
}
12-
13-
my $CLASS = 'App::Yath::Command::db';
14-
15-
subtest 'metadata' => sub {
16-
is($CLASS->name, 'db', 'name');
17-
is($CLASS->group, 'database', 'group');
18-
ok($CLASS->summary, 'summary is non-empty');
19-
ok($CLASS->description, 'description is non-empty');
20-
};
21-
22-
subtest 'flags' => sub {
23-
is($CLASS->accepts_dot_args, 0, 'accepts_dot_args is 0');
24-
is($CLASS->args_include_tests, 0, 'args_include_tests is 0');
25-
is($CLASS->load_plugins, 0, 'load_plugins is 0');
26-
is($CLASS->load_resources, 0, 'load_resources is 0');
27-
is($CLASS->load_renderers, 0, 'load_renderers is 0');
28-
};
29-
30-
subtest 'inheritance' => sub {
31-
ok($CLASS->isa('App::Yath::Command'), 'is a App::Yath::Command');
32-
};
3+
skip_all "write me";
334

345
done_testing;

‎t/unit/App/Yath/Command/db/importer.t‎

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,5 @@
11
use Test2::V0 -target => 'App::Yath::Command::db::importer';
22

3-
subtest 'metadata' => sub {
4-
is(CLASS->name, 'db-importer', 'name');
5-
is(CLASS->group, 'database', 'group');
6-
ok(CLASS->summary, 'summary is non-empty');
7-
ok(CLASS->description, 'description is non-empty');
8-
};
9-
10-
subtest 'flags' => sub {
11-
is(CLASS->accepts_dot_args, 0, 'accepts_dot_args is 0');
12-
is(CLASS->args_include_tests, 0, 'args_include_tests is 0');
13-
is(CLASS->load_plugins, 0, 'load_plugins is 0');
14-
is(CLASS->load_resources, 0, 'load_resources is 0');
15-
is(CLASS->load_renderers, 0, 'load_renderers is 0');
16-
};
17-
18-
subtest 'inheritance' => sub {
19-
ok(CLASS->isa('App::Yath::Command'), 'is a App::Yath::Command');
20-
};
3+
skip_all "write me";
214

225
done_testing;

‎t/unit/App/Yath/Command/db/publish.t‎

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,5 @@
11
use Test2::V0 -target => 'App::Yath::Command::db::publish';
22

3-
subtest 'metadata' => sub {
4-
is(CLASS->name, 'db-publish', 'name');
5-
my $group = CLASS->group;
6-
ok(ref($group) eq 'ARRAY', 'group is an arrayref (multiple groups)');
7-
ok((grep { $_ eq 'database' } @$group), 'group includes database');
8-
ok((grep { $_ eq 'log parsing' } @$group), 'group includes log parsing');
9-
ok(CLASS->summary, 'summary is non-empty');
10-
ok(CLASS->description, 'description is non-empty');
11-
};
12-
13-
subtest 'flags' => sub {
14-
is(CLASS->accepts_dot_args, 0, 'accepts_dot_args is 0');
15-
is(CLASS->args_include_tests, 0, 'args_include_tests is 0');
16-
is(CLASS->load_plugins, 0, 'load_plugins is 0');
17-
is(CLASS->load_resources, 0, 'load_resources is 0');
18-
is(CLASS->load_renderers, 0, 'load_renderers is 0');
19-
};
20-
21-
subtest 'cli_args' => sub {
22-
like(CLASS->cli_args, qr/event_log/, 'cli_args mentions event_log');
23-
};
24-
25-
subtest 'inheritance' => sub {
26-
ok(CLASS->isa('App::Yath::Command'), 'is a App::Yath::Command');
27-
};
3+
skip_all "write me";
284

295
done_testing;

‎t/unit/App/Yath/Command/db/recent.t‎

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,5 @@
11
use Test2::V0 -target => 'App::Yath::Command::db::recent';
22

3-
subtest 'metadata' => sub {
4-
is(CLASS->name, 'db-recent', 'name');
5-
my $group = CLASS->group;
6-
ok(ref($group) eq 'ARRAY', 'group is an arrayref (multiple groups)');
7-
ok((grep { $_ eq 'database' } @$group), 'group includes database');
8-
ok((grep { $_ eq 'history' } @$group), 'group includes history');
9-
ok(CLASS->summary, 'summary is non-empty');
10-
ok(CLASS->description, 'description is non-empty');
11-
};
12-
13-
subtest 'flags' => sub {
14-
is(CLASS->accepts_dot_args, 0, 'accepts_dot_args is 0');
15-
is(CLASS->args_include_tests, 0, 'args_include_tests is 0');
16-
};
17-
18-
subtest 'cli_args' => sub {
19-
is(CLASS->cli_args, '', 'cli_args is empty string');
20-
};
21-
22-
subtest 'inheritance' => sub {
23-
ok(CLASS->isa('App::Yath::Command'), 'is a App::Yath::Command');
24-
ok(CLASS->isa('App::Yath::Command::recent'), 'is a App::Yath::Command::recent');
25-
};
3+
skip_all "write me";
264

275
done_testing;

‎t/unit/App/Yath/Command/db/sweeper.t‎

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,5 @@
11
use Test2::V0 -target => 'App::Yath::Command::db::sweeper';
22

3-
subtest 'metadata' => sub {
4-
is(CLASS->name, 'db-sweeper', 'name');
5-
is(CLASS->group, 'database', 'group');
6-
ok(CLASS->summary, 'summary is non-empty');
7-
ok(CLASS->description, 'description is non-empty');
8-
};
9-
10-
subtest 'flags' => sub {
11-
is(CLASS->accepts_dot_args, 0, 'accepts_dot_args is 0');
12-
is(CLASS->args_include_tests, 0, 'args_include_tests is 0');
13-
is(CLASS->load_plugins, 0, 'load_plugins is 0');
14-
is(CLASS->load_resources, 0, 'load_resources is 0');
15-
is(CLASS->load_renderers, 0, 'load_renderers is 0');
16-
};
17-
18-
subtest 'inheritance' => sub {
19-
ok(CLASS->isa('App::Yath::Command'), 'is a App::Yath::Command');
20-
};
3+
skip_all "write me";
214

225
done_testing;

‎t/unit/App/Yath/Command/do.t‎

Lines changed: 6 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,11 @@
11
use Test2::V0 -target => 'App::Yath::Command::do';
22

3-
subtest 'metadata' => sub {
4-
is(CLASS->name, 'do', 'name');
5-
is(CLASS->group, ' main', 'group');
6-
ok(CLASS->summary, 'summary is non-empty');
7-
ok(CLASS->description, 'description is non-empty');
8-
};
9-
10-
subtest 'flags' => sub {
11-
is(CLASS->accepts_dot_args, 1, 'accepts_dot_args is 1');
12-
is(CLASS->args_include_tests, 1, 'args_include_tests is 1');
13-
is(CLASS->load_plugins, 1, 'load_plugins is 1');
14-
is(CLASS->load_resources, 1, 'load_resources is 1');
15-
is(CLASS->load_renderers, 1, 'load_renderers is 1');
16-
};
17-
18-
subtest 'cli_args' => sub {
19-
is(CLASS->cli_args, '[run or test args]', 'cli_args');
20-
};
21-
22-
subtest 'inheritance' => sub {
23-
ok(CLASS->isa('App::Yath::Command'), 'is a App::Yath::Command');
24-
ok(CLASS->isa('App::Yath::Command::test'), 'is a App::Yath::Command::test');
3+
subtest 'run() dies (stub command)' => sub {
4+
like(
5+
dies { CLASS->run() },
6+
qr/This should not be reachable/,
7+
'run() dies with expected message',
8+
);
259
};
2610

2711
done_testing;

‎t/unit/App/Yath/Command/failed.t‎

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,5 @@
11
use Test2::V0 -target => 'App::Yath::Command::failed';
22

3-
subtest 'metadata' => sub {
4-
is(CLASS->name, 'failed', 'name');
5-
is(CLASS->group, 'log parsing', 'group');
6-
ok(CLASS->summary, 'summary is non-empty');
7-
ok(CLASS->description, 'description is non-empty');
8-
};
9-
10-
subtest 'flags' => sub {
11-
is(CLASS->accepts_dot_args, 0, 'accepts_dot_args is 0');
12-
is(CLASS->args_include_tests, 0, 'args_include_tests is 0');
13-
is(CLASS->load_plugins, 0, 'load_plugins is 0');
14-
is(CLASS->load_resources, 0, 'load_resources is 0');
15-
is(CLASS->load_renderers, 0, 'load_renderers is 0');
16-
};
17-
18-
subtest 'cli_args' => sub {
19-
like(CLASS->cli_args, qr/event_log/, 'cli_args mentions event_log');
20-
};
21-
22-
subtest 'inheritance' => sub {
23-
ok(CLASS->isa('App::Yath::Command'), 'is a App::Yath::Command');
24-
};
3+
skip_all "write me";
254

265
done_testing;

0 commit comments

Comments
 (0)