Cleaned up code - some adjustments to selected files

The following adjustments were made:
- Files should end with a newline (PHP:S113)
- Mergeable "if" statements should be combined (PHP:S1066)
- Boolean literals should not be redundant (PHP:S1125)
- Lines should not end with trailing whitespaces (PHP:S1131)
- Use empty() to check whether the array is empty or not (PHP:S1155)
- Unused local variables should be removed (PHP:S1481)
- PHP keywords and constants "true", "false", "null" should be lower
case (PHP:S1781)
- "elseif" keyword should be used in place of "else if" keywords
(PHP:S1793)
- Unused assignments should be removed (PHP:S1854)
- "require_once" and "include_once" should be used instead of "require"
and "include" (PHP:S2003)

Author: DanProgs

lib/plan/buildEdit.php

@@ -7,7 +7,7 @@
  *
  *
  */
-require '../../config.inc.php';
+require_once '../../config.inc.php';
 require_once 'common.php';
 require_once 'web_editor.php';
 $editorCfg = getWebEditorCfg('build');

lib/plan/buildView.php

@@ -8,7 +8,7 @@
  *
  *
  */
-require '../../config.inc.php';
+require_once '../../config.inc.php';
 require_once 'common.php';
 testlinkInitPage($db,false,false);
 
@@ -94,11 +94,10 @@ function initEnv(&$dbHandler)
     if ($hasCF) {
       $cfields = (array)$build_mgr->getCustomFieldsValues($idk,$gui->tproject_id);
       foreach ($cfields as $cfd) {
-        if ($initCFCol) {
-          if (!isset($col2hide[$cfd['name']])) {
+        if ($initCFCol && !isset($col2hide[$cfd['name']]))
+        {
             $gui->cfieldsColumns[] = $cfd['label'];
             $gui->cfieldsType[] = $cfd['type'];
-          }
         }
         $gui->buildSet[$idk][$cfd['label']] = ['value' => $cfd['value'], 'data-order' => $cfd['value']];
         if ($cfd['type'] == 'date') {

lib/plan/newest_tcversions.php

@@ -6,7 +6,7 @@
  *
  *
  */
-require '../../config.inc.php';
+require_once '../../config.inc.php';
 require_once 'common.php';
 
 testlinkInitPage($db,false,false);

lib/plan/planAddTCNavigator.php

@@ -18,7 +18,7 @@
  *
  */
 
-require '../../config.inc.php';
+require_once '../../config.inc.php';
 require_once 'common.php';
 require_once 'treeMenu.inc.php';
 

lib/plan/planImport.php

@@ -19,7 +19,7 @@
  * @internal revisions
  *
  **/
-require '../../config.inc.php';
+require_once '../../config.inc.php';
 require_once 'common.php';
 require_once 'xml.inc.php';
 
@@ -219,7 +219,7 @@ function importTestPlanLinksFromXML(&$dbHandler,&$tplanMgr,$targetFile,$contextO
   }
 
   $xml = @simplexml_load_file_wrapper($targetFile);
-  if($xml !== FALSE)
+  if($xml !== false)
   {
     $tcaseMgr = new testcase($dbHandler);
     $tcaseSet = array();
@@ -252,7 +252,7 @@ function importTestPlanLinksFromXML(&$dbHandler,&$tplanMgr,$targetFile,$contextO
     {
       $tables = tlObjectWithDB::getDBTables(array('testplan_tcversions'));
       $platformSet = $tplanMgr->getPlatforms($contextObj->tplan_id,array('outputFormat' => 'mapAccessByName'));
-      $targetHasPlatforms = (count($platformSet) > 0);
+      $targetHasPlatforms = (!empty($platformSet));
 
       $xmlLinks = $xml->executables->children();
       $loops2do = count($xmlLinks);
@@ -337,7 +337,7 @@ function importTestPlanLinksFromXML(&$dbHandler,&$tplanMgr,$targetFile,$contextO
             $dummy = $tcaseMgr->get_basic_info($tcaseSet[$externalID],
                                                array('number' => $version));
 
-            if( count($dummy) > 0 )
+            if(!empty($dummy))
             {
               // Check :
               // for same test plan there is a different version already linked ?
@@ -468,7 +468,7 @@ function processPlatforms(&$platMgr,&$tplanMgr,$universe,$xmlSubset,$lbl,$tplanI
     $targetName = trim((string)$children[$idx]->name);
     if( isset($universe[$targetName]) )
     {
-      $status_ok = $status_ok && true;
+      $status_ok = true;
       $idSet[$universe[$targetName]] = $targetName;
     }
     else

lib/plan/planMilestonesCommands.class.php

@@ -18,14 +18,14 @@ class planMilestonesCommands
   private $auditContext;
   private $viewAction = 'lib/plan/planMilestonesView.php';
 
-  function __construct(&$db)
+  public function __construct(&$db)
   {
       $this->db = $db;
       $this->milestone_mgr = new milestone_mgr($db);
     $this->submit_button_label = lang_get('btn_save');
   }
 
-  function setAuditContext($auditContext)
+  private function setAuditContext($auditContext)
   {
       $this->auditContext = $auditContext;
   }
@@ -38,7 +38,7 @@ function: create
     returns:
 
   */
-  function create(&$argsObj)
+  private function create(&$argsObj)
   {
       $guiObj = new stdClass();
     $guiObj->main_descr = lang_get('testplan') . TITLE_SEP;
@@ -62,7 +62,7 @@ function: edit
     returns:
 
   */
-  function edit(&$argsObj)
+  private function edit(&$argsObj)
   {
     $guiObj = new stdClass();
     $dummy = $this->milestone_mgr->get_by_id($argsObj->id);
@@ -100,7 +100,7 @@ function: doCreate
     returns:
 
   */
-  function doCreate(&$argsObj,$basehref)
+  public function doCreate(&$argsObj,$basehref)
   {
     $date_format_cfg = config_get('date_format');
     $guiObj = new stdClass();
@@ -190,7 +190,7 @@ function: doUpdate
     returns:
 
   */
-  function doUpdate(&$argsObj,$basehref)
+  public function doUpdate(&$argsObj,$basehref)
   {
     $date_format_cfg = config_get('date_format');
     $obj=new stdClass();
@@ -289,7 +289,7 @@ function: doDelete
     returns: object with info useful to manage user interface
 
   */
-  function doDelete(&$argsObj,$basehref)
+  public function doDelete(&$argsObj,$basehref)
   {
     $dummy = $this->milestone_mgr->get_by_id($argsObj->id);
       $milestone = $dummy[$argsObj->id];

lib/platforms/platformsAssign.php

@@ -1,13 +1,13 @@
 <?php
  /**
- * TestLink Open Source Project - http://testlink.sourceforge.net/ 
- * This script is distributed under the GNU General Public License 2 or later. 
+ * TestLink Open Source Project - http://testlink.sourceforge.net/
+ * This script is distributed under the GNU General Public License 2 or later.
  *
  * Platform link/unlink from a test plan
- * 
+ *
  * @package     TestLink
  * @author      eloff
- * @copyright   2005-2022, TestLink community 
+ * @copyright   2005-2022, TestLink community
  * @filesource  platformsAssign.php
  * @link        http://www.testlink.org
  *
@@ -93,41 +93,30 @@
 $smarty->display($templateCfg->template_dir . $templateCfg->default_template);
 
 /**
- * Initializes option transfer items, by appending a text with number linked TC:s 
+ * Initializes option transfer items, by appending a text with number linked TC:s
  * for every assigned platform.
- * It also builds a js map platform_name => linked_count. 
- * This map is used to show warning dialog only when trying to unlink 
+ * It also builds a js map platform_name => linked_count.
+ * This map is used to show warning dialog only when trying to unlink
  * platforms with assigned TCs
  */
-function init_option_panels(&$tplan_mgr, &$platform_mgr, 
-                            &$opt_cfg, &$args)
+function init_option_panels(&$tplan_mgr, &$platform_mgr,&$opt_cfg, &$args)
 {
-
-  /*
-  $opx = [
-    'enable_on_design' => false, 
-    'enable_on_execution' => true,
-    'is_open' => true
-  ];
-  */
-  
   $opt_cfg->from->map = $platform_mgr->getAllAsMap(config_get('platforms')->allowedOnAssign);
 
   $optLTT = null;
   $map = $platform_mgr->getLinkedToTestplanAsMap($args->tplan_id,
                                                  $optLTT);
   $platform_count_js = "platform_count_map = new Array();\n";
-  if (!is_null($map)) {     
+  if (!is_null($map)) {
     foreach ($map as $plat_id => &$plat_name) {
       $count = $tplan_mgr->count_testcases($args->tplan_id,
                                            $plat_id);
-      $plat_name .= sprintf(lang_get('platform_linked_count'), 
+      $plat_name .= sprintf(lang_get('platform_linked_count'),
                             $count);
-      $platform_count_js .= 
-        "platform_count_map['$plat_name'] = $count;\n";
+      $platform_count_js .= "platform_count_map['$plat_name'] = $count;\n";
 
-      // Removal of duplicates is NOT handled 
-      // automatically since we just have modified 
+      // Removal of duplicates is NOT handled
+      // automatically since we just have modified
       // their names adding a usage counter.
       unset($opt_cfg->from->map[$plat_id]);
     }
@@ -138,7 +127,7 @@ function init_option_panels(&$tplan_mgr, &$platform_mgr,
 }
 
 /**
- * 
+ *
  *
  */
 function init_args(&$opt_cfg)
@@ -166,7 +155,7 @@ function init_args(&$opt_cfg)
      $args->platformsToAdd = explode(",", $pParams[$added]);
   }
 
-  if( $pParams[$removed] != "" ) 
+  if( $pParams[$removed] != "" )
   {
     $args->platformsToRemove = explode(",", $pParams[$removed]);
   }