Cleaned up code - some files were refactored with refactor

The following adjustments were made:
- Split multiple inline assigns to each own lines default value, to
prevent undefined array issues (SplitDoubleAssignRector)
- Assign outcome of ternary condition to variable, where applicable
(TernaryConditionVariableAssignmentRector)
- Change array_push() to direct variable assign
(ChangeArrayPushToArrayAssignRector)
- Switch negated ternary condition rector (SwitchNegatedTernaryRector)
- Change count() in for function to own variable
(ForRepeatedCountToOwnVariableRector)
- Make if conditions more explicit (ExplicitBoolCompareRector)

Author: DanProgs

config.inc.php

@@ -2248,7 +2248,7 @@
 /**
  * Converted and derived variables (Users should not modify this section)
  */
-define('REFRESH_SPEC_TREE', $tlCfg->spec_cfg->automatic_tree_refresh ? 1 : 0);
+define('REFRESH_SPEC_TREE', $tlCfg->spec_cfg->automatic_tree_refresh !== 0 ? 1 : 0);
 define('TL_SORT_TABLE_ENGINE', $g_sort_table_engine);
 define("TL_REPOSITORY_MAXFILESIZE",
     1024 * 1024 * $tlCfg->repository_max_filesize);

firstLogin.php

@@ -33,7 +33,7 @@
 
 $message = '';
 if (! is_null($args->doEditUser)) {
-    if (strcmp($args->password, $args->password2)) {
+    if (strcmp($args->password, $args->password2) !== 0) {
         $message = lang_get('passwd_dont_match');
     } else {
         $user = new tlUser();

install/installNewDB.php

@@ -474,7 +474,7 @@
     }
 }
 
-if ($update_pwd) {
+if ($update_pwd !== 0) {
     echo "Password Conversion ...";
     // @author Francisco Mancardi - 20050918
     // Found error upgrading from 1.0.4 to 1.6 on RH

lib/api/rest/v1/tlRestApi.class.php

@@ -362,7 +362,7 @@ public function getProjectTestPlans($idCard)
 
         if (! is_null($tproject)) {
             $items = $this->tprojectMgr->get_all_testplans($tproject[0]['id']);
-            $op['items'] = (! empty($items)) ? $items : null;
+            $op['items'] = (empty($items)) ? null : $items;
         } else {
             $op['message'] = "No Test Project identified by '" . $idCard . "'!";
             $op['status'] = 'error';

lib/api/rest/v2/tlRestApi.class.php

@@ -479,7 +479,7 @@ public function getProjectTestPlans($idCard)
 
         if (! is_null($tproject)) {
             $items = $this->tprojectMgr->get_all_testplans($tproject['id']);
-            $op['items'] = (! empty($items)) ? $items : null;
+            $op['items'] = (empty($items)) ? null : $items;
         } else {
             $op['message'] = "No Test Project identified by '" . $idCard . "'!";
             $op['status'] = 'error';
@@ -1513,7 +1513,7 @@ public function getPlanBuilds($idCard)
 
         if (! is_null($tplan)) {
             $items = $this->tplanMgr->get_builds($tplan['id']);
-            $op['items'] = (! empty($items)) ? $items : null;
+            $op['items'] = (empty($items)) ? null : $items;
         } else {
             $op['message'] = "No Test Plan identified by '" . $idCard . "'!";
             $op['status'] = 'error';
@@ -1692,7 +1692,7 @@ public function updateBuild($id)
                     $oio = intval($build['is_open']);
                     $nio = intval($item->is_open);
                     if ($oio != $nio) {
-                        if ($nio) {
+                        if ($nio !== 0) {
                             $this->buildMgr->setOpen($id);
                         } else {
                             $this->buildMgr->setClosed($id);

lib/api/rest/v3/RestApi.class.php

@@ -440,7 +440,7 @@ public function getProjectTestPlans(Response $response, $idCard)
 
         if (! is_null($tproj)) {
             $items = $this->tprojectMgr->get_all_testplans($tproj['id']);
-            $op['items'] = (! empty($items)) ? $items : null;
+            $op['items'] = (empty($items)) ? null : $items;
         } else {
             $op['message'] = "No Test Project identified by '" . $idCard . "'!";
             $op['status'] = 'error';
@@ -466,7 +466,7 @@ public function getPlanBuilds(Response $response, $idCard)
 
         if (! is_null($tplan)) {
             $items = $this->tplanMgr->get_builds($tplan['id']);
-            $op['items'] = (! empty($items)) ? $items : null;
+            $op['items'] = (empty($items)) ? null : $items;
         } else {
             $op['message'] = "No Test Plan identified by API KEY:" .
                 $idCard['tplanApiKey'] . "";
@@ -836,7 +836,7 @@ public function updateBuild(Request $request, Response $response, $args)
                     $oio = intval($build['is_open']);
                     $nio = intval($item->is_open);
                     if ($oio != $nio) {
-                        if ($nio) {
+                        if ($nio !== 0) {
                             $this->buildMgr->setOpen($id);
                         } else {
                             $this->buildMgr->setClosed($id);

lib/api/xmlrpc/v1/sample_clients/php/clientTestSuiteTestCaseStepsManagement.php

@@ -31,7 +31,7 @@
 for ($idx = 1; $idx < $qtySteps; $idx ++) {
     $action = 'FULL STOP NOW!!!! - intensity=';
     $expected_results = '%s Red Lights ON';
-    if ($idx & 1) {
+    if (($idx & 1) !== 0) {
         $action = 'Start Server with power=';
         $expected_results = 'GREEN Lantern %s ON';
     }

lib/api/xmlrpc/v1/xmlrpc.class.php

@@ -591,7 +591,7 @@ protected function userHasRight($rightToCheck,
         }
 
         $tprojectid = intval($tprojectid);
-        $tplanid = ! is_null($tplanid) ? intval($tplanid) : - 1;
+        $tplanid = is_null($tplanid) ? - 1 : intval($tplanid);
 
         if ($tprojectid <= 0 && $tplanid > 0) {
             // get test project from test plan
@@ -1577,7 +1577,7 @@ protected function _checkTCIDAndTPIDValid($platformInfo = null,
     {
         $tplan_id = $this->args[self::$testPlanIDParamName];
         $tcase_id = $this->args[self::$testCaseIDParamName];
-        $platform_id = ! is_null($platformInfo) ? key($platformInfo) : null;
+        $platform_id = is_null($platformInfo) ? null : key($platformInfo);
 
         $filters = [
             'exec_status' => "ALL",
@@ -1882,7 +1882,7 @@ public function getLastExecutionResult($args)
                     $targetID;
                 $resultInfo[0] = $this->dbObj->fetchFirstRow($sql);
 
-                if ($options->getBugs) {
+                if ($options->getBugs !== 0) {
                     $resultInfo[0]['bugs'] = [];
                     $sql = " SELECT DISTINCT bug_id FROM {$this->tables['execution_bugs']} " .
                         " WHERE execution_id = " . $targetID;
@@ -2029,7 +2029,7 @@ public function getAllExecutionsResults($args)
                     $sql = "SELECT * FROM {$this->tables['executions']} WHERE id=" .
                         $tcExecId;
                     $resultInfo[$tcExecId] = $this->dbObj->fetchFirstRow($sql);
-                    if ($options->getBugs) {
+                    if ($options->getBugs !== 0) {
                         $resultInfo[$tcExecId]['bugs'] = [];
                         $sql = " SELECT DISTINCT bug_id FROM
                        {$this->tables['execution_bugs']}
@@ -4052,8 +4052,9 @@ public function addTestCaseToTestPlan($args)
                     // Other version than requested done is already linked
                     $doLink = false;
                     if ($this->_isParamPresent(self::$overwriteParamName) &&
-                        $this->args[self::$overwriteParamName]) {
-                        $doLink = $doDeleteLinks = true;
+                        $this->args[self::$overwriteParamName]) {
+                        $doLink = true;
+                        $doDeleteLinks = true;
                     }
 
                     reset($rs);
@@ -5480,15 +5481,15 @@ protected function checkPlatformIdentity($tplanID, $platformInfo = null,
             $messagePrefix);
         $status = $name_exists | $id_exists;
 
-        if (! $status) {
+        if ($status === 0) {
             $pname = self::$platformNameParamName . ' OR ' .
                 self::$platformIDParamName;
             $msg = $messagePrefix .
                 sprintf(MISSING_REQUIRED_PARAMETER_STR, $pname);
             $this->errors[] = new IXR_Error(MISSING_REQUIRED_PARAMETER, $msg);
         }
 
-        if ($status) {
+        if ($status !== 0) {
             // get test plan name is useful for error messages
             $tplanInfo = $this->tplanMgr->get_by_id($tplanID);
             if (is_null($platformInfo)) {
@@ -9099,17 +9100,15 @@ public function updateBuildCustomFieldsValues($args)
                     $cfieldMgr->design_values_to_db($hash,
                         $args[self::$buildIDParamName], null, null, 'build');
                     // Add the result for each custom field to the returned array
-                    array_push($ret,
-                        [
-                            'status' => 'ok',
-                            'msg' => 'Custom Field:' . $cfName . ' processed '
-                        ]);
+                    $ret[] = [
+                        'status' => 'ok',
+                        'msg' => 'Custom Field:' . $cfName . ' processed '
+                    ];
                 } else {
-                    array_push($ret,
-                        [
-                            'status' => 'ko',
-                            'msg' => 'Custom Field:' . $cfName . ' skipped '
-                        ]);
+                    $ret[] = [
+                        'status' => 'ko',
+                        'msg' => 'Custom Field:' . $cfName . ' skipped '
+                    ];
                 }
             }
             // Return the result after all of the fields have been processed
@@ -9663,7 +9662,7 @@ public function getExecutionSet($args)
             $sql .= ")";
 
             $sql .= " ORDER BY id ";
-            $sql .= ($opt->getOrderDescending) ? " DESC" : " ASC";
+            $sql .= ($opt->getOrderDescending !== 0) ? " DESC" : " ASC";
 
             $rs = $this->dbObj->fetchRowsIntoMap($sql, 'id');
             if (is_null($rs)) {

lib/cfields/cfieldsEdit.php

@@ -63,7 +63,7 @@
         break;
 }
 
-if ($do_control_combo_display) {
+if ($do_control_combo_display !== 0) {
     $keys2loop = $cfield_mgr->get_application_areas();
     foreach ($keys2loop as $ui_mode) {
         $cfieldCfg->cf_enable_on[$ui_mode]['value'] = 0;

lib/cfields/cfieldsExport.php

@@ -24,7 +24,7 @@
 $gui->page_title = lang_get('export_cfields');
 $gui->do_it = 1;
 $gui->nothing_todo_msg = '';
-$gui->goback_url = ! is_null($args->goback_url) ? $args->goback_url : '';
+$gui->goback_url = is_null($args->goback_url) ? '' : $args->goback_url;
 $gui->export_filename = is_null($args->export_filename) ? 'customFields.xml' : $args->export_filename;
 $gui->exportTypes = [
     'XML' => 'XML'