Skip to content

Commit 929f0d4

Browse files
committed
Cleaned up code - some adjustments to selected files
The following adjustments were made: - Files should end with a newline (PHP:S113) - Control structures should use curly braces (PHP:S121) - Sections of code should not be commented out (PHP:S125) - Redundant pairs of parentheses should be removed (PHP:1110) - Mergeable "if" statements should be combined (PHP:S1066) - Empty statements should be removed (PHP:S1116) - Modifiers should be declared in the correct order (PHP:S1124) - Boolean literals should not be redundant (PHP:S1125) - Lines should not end with trailing whitespaces (PHP:S1131) - Use empty() to check whether the array is empty or not (PHP:S1155) - Unused local variables should be removed (PHP:S1481) - Identical expressions should not be used on both sides of a binary operator (PHP:S1764) - PHP keywords and constants "true", "false", "null" should be lower case (PHP:S1781) - Method visibility should be explicitly declared (PHP:S1784) - "elseif" keyword should be used in place of "else if" keywords (PHP:S1793) - "&&" and "||" should be used (PHP:S2010)
1 parent 5191885 commit 929f0d4

28 files changed

Lines changed: 1213 additions & 1304 deletions

lib/ajax/gettprojectnodes.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
* @param database $dbHandler
5151
* @param int $root_node
5252
* @param int $parent
53-
* @param $filter_node
53+
* @param string $filter_node
5454
* @param string $tcprefix
5555
* @param number $show_tcases
5656
* @param string $operation

lib/functions/assignment_mgr.class.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ function __construct(&$db)
3131
/**
3232
*
3333
* @param string $key_field contains the filename that has to be used as the key of the returned hash.
34-
* @return unknown
34+
* @return array
3535
*/
3636
public function get_available_types($key_field='description')
3737
{
@@ -48,9 +48,9 @@ public function get_available_types($key_field='description')
4848
/**
4949
*
5050
* @param string $key_field contains the name column that has to be used as the key of the returned hash.
51-
* @return unknown
51+
* @return array
5252
*/
53-
function get_available_status($key_field='description')
53+
public function get_available_status($key_field='description')
5454
{
5555
static $hash_types;
5656
if (!$hash_types)

0 commit comments

Comments
 (0)