Skip to content

Commit babdfe3

Browse files
committed
FIX: Deprecated: Optional parameter $options declared before required
parameter $platforms is implicitly treated as a required parameter in neverRunByPP.php on line 331 (buildMatrix)
1 parent 8ef43ce commit babdfe3

1 file changed

Lines changed: 11 additions & 16 deletions

File tree

lib/results/neverRunByPP.php

Lines changed: 11 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,13 @@
1212
*
1313
*
1414
*/
15-
require('../../config.inc.php');
16-
17-
// Must be included BEFORE common.php
18-
require_once('../../third_party/codeplex/PHPExcel.php');
19-
20-
require_once('common.php');
21-
require_once('displayMgr.php');
22-
require_once('users.inc.php');
23-
require_once('exttable.class.php');
24-
require_once('exec.inc.php'); // used for bug string lookup
15+
require_once '../../config.inc.php';
16+
require_once '../../third_party/codeplex/PHPExcel.php'; // Must be included BEFORE common.php
17+
require_once 'common.php';
18+
require_once 'displayMgr.php';
19+
require_once 'users.inc.php';
20+
require_once 'exttable.class.php';
21+
require_once 'exec.inc.php'; // used for bug string lookup
2522

2623
// IMPORTANT NOTICE/WARNING about XLS generation
2724
// Seams that \n are not liked
@@ -151,8 +148,7 @@
151148
array('format' => $args->format,
152149
'show_platforms' => $gui->show_platforms);
153150

154-
$gui->tableSet[] = buildMatrix($gui->dataSet, $args, $tableOpt ,
155-
$gui->platformSet,$cfSet);
151+
$gui->tableSet[] = buildMatrix($gui->dataSet, $args, $gui->platformSet, $tableOpt , $cfSet);
156152
break;
157153
}
158154
}
@@ -328,9 +324,8 @@ function buildMailCfg(&$guiObj) {
328324
* return tlExtTable
329325
*
330326
*/
331-
function buildMatrix($dataSet, &$args, $options = array(), $platforms,$customFieldColumns=null) {
332-
$default_options =
333-
array('show_platforms' => false,'format' => FORMAT_HTML);
327+
function buildMatrix($dataSet, &$args, $platforms, $options = array(), $customFieldColumns=null) {
328+
$default_options = array('show_platforms' => false,'format' => FORMAT_HTML);
334329
$options = array_merge($default_options, $options);
335330

336331
$l18n = init_labels(array('platform' => null));
@@ -539,4 +534,4 @@ function xlsStepOne($oj,$style,$lbl,$gui) {
539534
->applyFromArray($style['ReportContext']);
540535

541536
return $lines2write;
542-
}
537+
}

0 commit comments

Comments
 (0)