Skip to content

Commit d23f0b9

Browse files
committed
Authenticated SQL injection in lib/execute/execSetResults.php via the step_notes #327
1 parent 8c5516b commit d23f0b9

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

lib/functions/testcase.class.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9562,8 +9562,11 @@ public function getStepsPartialExec($stepsIds,$context) {
95629562
*
95639563
*/
95649564
public function deleteStepsPartialExec($stepsIds,$context) {
9565-
$inClause = implode(",",$stepsIds);
95669565
if( count($stepsIds) > 0 ) {
9566+
// https://github.com/TestLinkOpenSourceTRMS/testlink-code/pull/327
9567+
// Security
9568+
$inClause = $this->db->prepare_string(implode(",",$stepsIds));
9569+
95679570
$sql = " DELETE FROM {$this->tables['execution_tcsteps_wip']}
95689571
WHERE tcstep_id IN (" . $inClause . ") " .
95699572
" AND testplan_id = " .

0 commit comments

Comments
 (0)