Cleaned up code - some adjustments to selected files

The following adjustments were made:
- Files should end with a newline (PHP:S113)
- Lines should not end with trailing whitespaces (PHP:S1131)
- Unused local variables should be removed (PHP:S1481)
- The "var" keyword should not be used (PHP:S1765)
- Method visibility should be explicitly declared (PHP:S1784)

Author: DanProgs

lib/cfields/cfieldsEdit.php

@@ -15,8 +15,6 @@
 $args = init_args();
 $gui = initializeGui($cfield_mgr);
 
-
-$result_msg = null;
 $do_control_combo_display = 1;
 $cfMix = getCFCfg($args,$cfield_mgr);
 $cfieldCfg = $cfMix->cfieldCfg;
@@ -285,7 +283,7 @@ function edit(&$argsObj,&$cfieldMgr)
 
 /**
  *
- * @param unknown $hash_request
+ * @param array $hash_request
  * @param cfield_mgr $cfieldMgr
  * @param stdClass $argsObj
  * @return stdClass

lib/functions/assignment_mgr.class.php

@@ -22,7 +22,7 @@
 class assignment_mgr extends tlObjectWithDB
 {
 
-  function __construct(&$db)
+  public function __construct(&$db)
   {
     parent::__construct($db);
   }
@@ -31,7 +31,7 @@ function __construct(&$db)
   /**
    *
    * @param string $key_field contains the filename that has to be used as the key of the returned hash.
-   * @return array 
+   * @return array
    */
   public function get_available_types($key_field='description')
   {
@@ -48,7 +48,7 @@ public function get_available_types($key_field='description')
   /**
    *
    * @param string $key_field contains the name column that has to be used as the key of the returned hash.
-   * @return array 
+   * @return array
    */
   public function get_available_status($key_field='description')
   {
@@ -67,7 +67,7 @@ public function get_available_status($key_field='description')
    *
    * @param int or array $feature_id
    */
-  function delete_by_feature_id($feature_id)
+  public function delete_by_feature_id($feature_id)
   {
     if( is_array($feature_id) )
     {
@@ -90,7 +90,7 @@ function delete_by_feature_id($feature_id)
    * @param boolean $delete_all_types If true, all assignments regardless of type will be deleted,
    *                              else (default) only tester assignments.
    */
-  function delete_by_build_id($build_id, $delete_all_types = false)
+  public function delete_by_build_id($build_id, $delete_all_types = false)
   {
     $type_sql = "";
 
@@ -113,7 +113,7 @@ function delete_by_build_id($build_id, $delete_all_types = false)
    *
    * @param array $feature_map
    */
-  function delete_by_feature_id_and_build_id($feature_map)
+  public function delete_by_feature_id_and_build_id($feature_map)
   {
     $feature_id_list = implode(",",array_keys($feature_map));
     $where_clause = " WHERE feature_id IN ($feature_id_list) ";
@@ -245,7 +245,7 @@ public function assign($feature_map)
    *
    * @internal revisions
    */
-  function update($feature_map)
+  public function update($feature_map)
   {
     foreach($feature_map as $feature_id => $elem)
     {
@@ -312,7 +312,7 @@ public function get_count_of_assignments_for_build_id($build_id, $count_all_type
    *
    * @internal revisions
    */
-  function get_not_run_tc_count_per_build($build_id, $all_types = false, $user_id = 0)
+  public function get_not_run_tc_count_per_build($build_id, $all_types = false, $user_id = 0)
   {
     $count = 0;
 
@@ -414,7 +414,7 @@ public function copy_assignments($source_build_id, $target_build_id,
    * @param mixed $buildID can be single value or array of build ID.
    * @return unknown
    */
-  function getExecAssignmentsCountByBuild($buildID)
+  private function getExecAssignmentsCountByBuild($buildID)
   {
     $debugMsg = 'Class:' . __CLASS__ . ' - Method: ' . __FUNCTION__;
     $rs = null;
@@ -441,7 +441,7 @@ function getExecAssignmentsCountByBuild($buildID)
    * @param mixed $buildID can be single value or array of build ID.
    * @return unknown
    */
-  function getNotRunAssignmentsCountByBuild($buildID)
+  private function getNotRunAssignmentsCountByBuild($buildID)
   {
     $debugMsg = 'Class:' . __CLASS__ . ' - Method: ' . __FUNCTION__;
     $rs = null;