fix: resolve E2E failures, CodeQL warnings, and debug cleanup (#216)

* fix: resolve CodeQL quality warnings

- Remove useless comparison (i > 0 always true in loop body)
- Remove unused editorNode variable in SlashCommand onUpdate
- Add type import for ExtendedIntegration
- Fix bare string expressions in test stubs (missing return)
- Remove redundant open={var !== null} in 39 admin modal guards
- Remove redundant null check after early return in health score calc
- Remove redundant open checks in AddTestRunModal useEffect

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* refactor: apply consistent formatting and improve readability in various worker scripts

- Standardized console log messages for tenant configuration loading and error handling across multiple worker files.
- Enhanced readability by restructuring long lines and ensuring consistent indentation.
- Updated error messages to provide clearer context for failures in tenant configuration loading and Elasticsearch operations.

This refactor aims to improve code maintainability and clarity without altering functionality.

* refactor: improve loading state handling in Select components

- Fix session cache not invalidated after user profile update
- Fix folder duplicate name error detection for ZenStack error format
- Disable submit buttons until async data loads (sessions, milestones,
  test cases) to prevent race condition with undefined template/workflow
- Scope combobox pagination "Next" button selector to avoid wizard
  button ambiguity in E2E test
- Apply prettier formatting to files from main merge

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* refactor: streamline parent and connection handling in milestone and session modals

- Simplified the connection logic for parent milestones in AddMilestoneModal.
- Enhanced the AddSessionModal by using spread operators for conditional connections, improving readability and maintainability.
- Added logging for error responses in the API route handler to aid debugging during create/upsert operations.

These changes improve code clarity and error tracking without altering existing functionality.

* refactor: apply consistent formatting and improve readability in various worker scripts

- Remove debug console.log statements from automationImports,
  magic-select-cases, test-results import, aiExportActions,
  testmoImportWorker, and syncWorker
- Remove temporary MODEL API ERROR logging from model handler
- Fix pagination E2E tests: navigate directly via URL params
  (?node=ID&pageSize=10) instead of flaky folder-tree clicks
- Fix search-filter pagination tests with same URL param approach

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* fix: update E2E tests for prompt config features and step creation

- Add missing generate_from_url and generate_from_url_app features to
  prompt config test data (form validation requires all features to have
  non-empty systemPrompt)
- Switch ACL-06 step creation test from scalar FK to relation connect
  syntax for ZenStack policy evaluation

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* refactor: remove unnecessary console.log statements from syncWorker and testmoImportWorker

- Eliminated debug logging related to issue creation and update in syncWorker.
- Removed verbose logging for multiple Testmo cases mapping in testmoImportWorker to streamline output and improve code clarity.

These changes enhance the maintainability of the worker scripts by reducing clutter in the logs.

* fix: resolve session form reset race and step creation policy

- Consolidate AddSessionModal form init into single guarded useEffect
  with formInitRef to prevent async data loading from wiping user input
  (fixes "Name must be at least 2 characters" on session create with
  config+milestone)
- Add steps to fast-path create models with indirect project resolution
  via testCase lookup (bypasses ZenStack policy evaluation bug for
  deep relation chains during create operations)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: therealbrad

testplanit/app/[locale]/admin/app-config/page.tsx

@@ -215,14 +215,14 @@ function AppConfigs() {
       {editingConfig && (
         <EditAppConfig
           config={editingConfig}
-          open={editingConfig !== null}
+          open={true}
           onClose={() => setEditingConfig(null)}
         />
       )}
       {deletingConfig && (
         <DeleteAppConfig
           config={deletingConfig}
-          open={deletingConfig !== null}
+          open={true}
           onClose={() => setDeletingConfig(null)}
         />
       )}

testplanit/app/[locale]/admin/configurations/Categories.tsx

@@ -557,7 +557,7 @@ function ConfigCategoriesList() {
       {variantToEdit && (
         <EditVariantModal
           variant={variantToEdit}
-          open={variantToEdit !== null}
+          open={true}
           onClose={() => setVariantToEdit(null)}
           onSave={handleVariantUpdate}
         />
@@ -566,22 +566,22 @@ function ConfigCategoriesList() {
       {variantToDelete && (
         <DeleteVariantModal
           variant={variantToDelete}
-          open={variantToDelete !== null}
+          open={true}
           onClose={() => setVariantToDelete(null)}
           onDelete={handleVariantDelete}
         />
       )}
       {editingCategory && (
         <EditCategory
           category={editingCategory}
-          open={editingCategory !== null}
+          open={true}
           onClose={() => setEditingCategory(null)}
         />
       )}
       {deletingCategory && (
         <DeleteConfigCategory
           category={deletingCategory}
-          open={deletingCategory !== null}
+          open={true}
           onClose={() => setDeletingCategory(null)}
         />
       )}

testplanit/app/[locale]/admin/configurations/Configurations.tsx

@@ -253,14 +253,14 @@ function Configurations(): React.ReactElement | null {
         {editingConfiguration && (
           <EditConfiguration
             configuration={editingConfiguration}
-            open={editingConfiguration !== null}
+            open={true}
             onClose={() => setEditingConfiguration(null)}
           />
         )}
         {deletingConfiguration && (
           <DeleteConfiguration
             configuration={deletingConfiguration}
-            open={deletingConfiguration !== null}
+            open={true}
             onClose={() => setDeletingConfiguration(null)}
           />
         )}

testplanit/app/[locale]/admin/fields/CaseFields.tsx

@@ -173,14 +173,14 @@ export default function CaseFields() {
         {editingCaseField && (
           <EditCaseField
             casefield={editingCaseField}
-            open={editingCaseField !== null}
+            open={true}
             onClose={() => setEditingCaseField(null)}
           />
         )}
         {deletingCaseField && (
           <DeleteCaseField
             casefield={deletingCaseField}
-            open={deletingCaseField !== null}
+            open={true}
             onClose={() => setDeletingCaseField(null)}
           />
         )}

testplanit/app/[locale]/admin/fields/ResultFields.tsx

@@ -173,14 +173,14 @@ export default function ResultFields() {
         {editingResultField && (
           <EditResultField
             resultfield={editingResultField}
-            open={editingResultField !== null}
+            open={true}
             onClose={() => setEditingResultField(null)}
           />
         )}
         {deletingResultField && (
           <DeleteResultField
             resultfield={deletingResultField}
-            open={deletingResultField !== null}
+            open={true}
             onClose={() => setDeletingResultField(null)}
           />
         )}

testplanit/app/[locale]/admin/fields/Templates.tsx

@@ -263,14 +263,14 @@ export default function TemplateComponent() {
         {editingTemplate && (
           <EditTemplate
             template={editingTemplate as any}
-            open={editingTemplate !== null}
+            open={true}
             onClose={() => setEditingTemplate(null)}
           />
         )}
         {deletingTemplate && (
           <DeleteTemplate
             template={deletingTemplate}
-            open={deletingTemplate !== null}
+            open={true}
             onClose={() => setDeletingTemplate(null)}
           />
         )}

testplanit/app/[locale]/admin/groups/page.tsx

@@ -298,14 +298,14 @@ function GroupList() {
         {editingGroup && (
           <EditGroup
             group={editingGroup}
-            open={editingGroup !== null}
+            open={true}
             onClose={() => setEditingGroup(null)}
           />
         )}
         {deletingGroup && (
           <DeleteGroup
             group={deletingGroup}
-            open={deletingGroup !== null}
+            open={true}
             onClose={() => setDeletingGroup(null)}
           />
         )}

testplanit/app/[locale]/admin/integrations/page.tsx

@@ -40,7 +40,7 @@ import {
   usePagination,
 } from "~/lib/contexts/PaginationContext";
 import { useRouter } from "~/lib/navigation";
-import { ExtendedIntegration, getColumns } from "./columns";
+import { type ExtendedIntegration, getColumns } from "./columns";
 
 type PageSizeOption = number | "All";
 

testplanit/app/[locale]/admin/issues/page.tsx

@@ -433,14 +433,14 @@ function IssueList() {
       {editingIssue && (
         <EditIssue
           issue={editingIssue}
-          open={editingIssue !== null}
+          open={true}
           onClose={() => setEditingIssue(null)}
         />
       )}
       {deletingIssue && (
         <DeleteIssue
           issue={deletingIssue}
-          open={deletingIssue !== null}
+          open={true}
           onClose={() => setDeletingIssue(null)}
         />
       )}

testplanit/app/[locale]/admin/llm/page.tsx

@@ -469,14 +469,14 @@ function LlmIntegrationList() {
           currentSpend={
             usageByIntegrationIdRef.current.get(editingIntegration.id) ?? 0
           }
-          open={editingIntegration !== null}
+          open={true}
           onClose={() => setEditingIntegration(null)}
         />
       )}
       {deletingIntegration && (
         <DeleteLlmIntegration
           integration={deletingIntegration}
-          open={deletingIntegration !== null}
+          open={true}
           onClose={() => setDeletingIntegration(null)}
         />
       )}