Refactoring BaseFileSystemNodeAnalyzer.cs

Author: inyutin-maxim

System.IO.Abstractions.Analyzers/Analyzers/BaseFileSystemNodeAnalyzer.cs

@@ -10,7 +10,7 @@ public abstract class BaseFileSystemNodeAnalyzer : BaseFileSystemAnalyzer
 		protected override void AnalyzeCompilation(CompilationStartAnalysisContext compilationStartContext,
 													FileSystemContext fileSystemContext)
 		{
-			if (typeof(Path).Namespace != GetFileSystemType().Namespace)
+			if (IsNotUsedSystemIo())
 			{
 				return;
 			}
@@ -19,7 +19,7 @@ protected override void AnalyzeCompilation(CompilationStartAnalysisContext compi
 				{
 					var invocation = (InvocationExpressionSyntax) syntaxContext.Node;
 
-					if (invocation.Expression.NormalizeWhitespace().ToFullString().StartsWith(GetFileSystemType().Name + "."))
+					if (IsStaticInvocationStartWith(invocation))
 					{
 						Analyze(syntaxContext, invocation);
 					}
@@ -28,11 +28,11 @@ protected override void AnalyzeCompilation(CompilationStartAnalysisContext compi
 
 			compilationStartContext.RegisterSyntaxNodeAction(syntaxContext =>
 				{
-					var invocation = (ObjectCreationExpressionSyntax) syntaxContext.Node;
+					var creationExpressionSyntax = (ObjectCreationExpressionSyntax) syntaxContext.Node;
 
-					if (invocation.Type.NormalizeWhitespace().ToFullString() == GetFileSystemType().Name)
+					if (IsTypesEquals(creationExpressionSyntax.Type))
 					{
-						Analyze(syntaxContext, invocation);
+						Analyze(syntaxContext, creationExpressionSyntax);
 					}
 				},
 				SyntaxKind.ObjectCreationExpression);
@@ -41,5 +41,13 @@ protected override void AnalyzeCompilation(CompilationStartAnalysisContext compi
 		protected abstract void Analyze(SyntaxNodeAnalysisContext context, ExpressionSyntax invocation);
 
 		protected abstract Type GetFileSystemType();
+
+		private bool IsNotUsedSystemIo() => typeof(Path).Namespace != GetFileSystemType().Namespace;
+
+		private bool IsTypesEquals(TypeSyntax type) => type.NormalizeWhitespace().ToFullString() == GetFileSystemType().Name;
+
+		private bool IsStaticInvocationStartWith(InvocationExpressionSyntax invocation) => invocation.Expression.NormalizeWhitespace()
+			.ToFullString()
+			.StartsWith(GetFileSystemType().Name + ".");
 	}
 }