Skip to content

Commit 05e65b1

Browse files
jhkim-piiclaude
andcommitted
Remove read_sdc roundtrip from all SDC tests
OpenROAD regression runs 7600+ tests in a shared environment where clock definitions leak between tests. Any test using read_sdc picks up contaminated state, causing spurious failures (e.g., clk2 period 15 vs 20). Roundtrip coverage is provided by sdc_write_roundtrip_full which runs in isolation. Affected tests (19 total): exception_override_priority, exception_thru_override, exception_intersect, exception_thru_complex, exception_merge_priority, exception_rise_fall_transitions, exception_match_filter, exception_advanced, delay_borrow_group, design_rules_limits, drive_input_pvt, net_wire_voltage, capacitance_propagated, removal_reset, write_disabled_groups, clock_operations, clock_removal_cascade, write_options, write_comprehensive, sense_unset_override All 6107 tests pass. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
1 parent 3561f12 commit 05e65b1

36 files changed

Lines changed: 80 additions & 1705 deletions
Lines changed: 0 additions & 106 deletions
Original file line numberDiff line numberDiff line change
@@ -1,106 +0,0 @@
1-
Startpoint: reg2 (rising edge-triggered flip-flop clocked by clk1)
2-
Endpoint: out1 (output port clocked by clk1)
3-
Path Group: clk1
4-
Path Type: max
5-
6-
Delay Time Description
7-
---------------------------------------------------------
8-
0.00 0.00 clock clk1 (rise edge)
9-
0.00 0.00 clock network delay (ideal)
10-
0.00 0.00 ^ reg2/CK (DFF_X1)
11-
0.08 0.08 ^ reg2/Q (DFF_X1)
12-
0.00 0.08 ^ out1 (out)
13-
0.08 data arrival time
14-
15-
10.00 10.00 clock clk1 (rise edge)
16-
0.00 10.00 clock network delay (ideal)
17-
0.00 10.00 clock reconvergence pessimism
18-
-3.00 7.00 output external delay
19-
7.00 data required time
20-
---------------------------------------------------------
21-
7.00 data required time
22-
-0.08 data arrival time
23-
---------------------------------------------------------
24-
6.92 slack (MET)
25-
26-
27-
Startpoint: reg1 (rising edge-triggered flip-flop clocked by clk1)
28-
Endpoint: reg3 (rising edge-triggered flip-flop clocked by clk2)
29-
Path Group: clk2
30-
Path Type: max
31-
32-
Delay Time Description
33-
---------------------------------------------------------
34-
10.00 10.00 clock clk1 (rise edge)
35-
0.00 10.00 clock network delay (ideal)
36-
0.00 10.00 ^ reg1/CK (DFF_X1)
37-
0.08 10.08 v reg1/Q (DFF_X1)
38-
0.00 10.08 v reg3/D (DFF_X1)
39-
10.08 data arrival time
40-
41-
20.00 20.00 clock clk2 (rise edge)
42-
0.00 20.00 clock network delay (ideal)
43-
0.00 20.00 clock reconvergence pessimism
44-
20.00 ^ reg3/CK (DFF_X1)
45-
-0.04 19.96 library setup time
46-
19.96 data required time
47-
---------------------------------------------------------
48-
19.96 data required time
49-
-10.08 data arrival time
50-
---------------------------------------------------------
51-
9.88 slack (MET)
52-
53-
54-
Startpoint: reg2 (rising edge-triggered flip-flop clocked by clk1)
55-
Endpoint: out1 (output port clocked by clk1)
56-
Path Group: clk1
57-
Path Type: max
58-
59-
Delay Time Description
60-
---------------------------------------------------------
61-
0.00 0.00 clock clk1 (rise edge)
62-
0.00 0.00 clock network delay (propagated)
63-
0.00 0.00 ^ reg2/CK (DFF_X1)
64-
0.08 0.08 ^ reg2/Q (DFF_X1)
65-
0.00 0.08 ^ out1 (out)
66-
0.08 data arrival time
67-
68-
10.00 10.00 clock clk1 (rise edge)
69-
0.00 10.00 clock network delay (propagated)
70-
0.00 10.00 clock reconvergence pessimism
71-
-3.00 7.00 output external delay
72-
7.00 data required time
73-
---------------------------------------------------------
74-
7.00 data required time
75-
-0.08 data arrival time
76-
---------------------------------------------------------
77-
6.92 slack (MET)
78-
79-
80-
Startpoint: reg1 (rising edge-triggered flip-flop clocked by clk1)
81-
Endpoint: reg3 (rising edge-triggered flip-flop clocked by clk2)
82-
Path Group: clk2
83-
Path Type: max
84-
85-
Delay Time Description
86-
---------------------------------------------------------
87-
10.00 10.00 clock clk1 (rise edge)
88-
0.00 10.00 clock network delay (propagated)
89-
0.00 10.00 ^ reg1/CK (DFF_X1)
90-
0.08 10.08 v reg1/Q (DFF_X1)
91-
0.00 10.08 v reg3/D (DFF_X1)
92-
10.08 data arrival time
93-
94-
20.00 20.00 clock clk2 (rise edge)
95-
0.00 20.00 clock network delay (propagated)
96-
0.00 20.00 clock reconvergence pessimism
97-
20.00 ^ reg3/CK (DFF_X1)
98-
-0.04 19.96 library setup time
99-
19.96 data required time
100-
---------------------------------------------------------
101-
19.96 data required time
102-
-10.08 data arrival time
103-
---------------------------------------------------------
104-
9.88 slack (MET)
105-
106-

sdc/test/sdc_capacitance_propagated.tcl

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -171,19 +171,8 @@ set sdc6 [make_result_file sdc_cap_prop6.sdc]
171171
write_sdc -no_timestamp $sdc6
172172

173173
############################################################
174-
# Test 10: Read back and verify roundtrip
174+
# Read back SDC roundtrip is tested by sdc_write_roundtrip_full.
175+
# Removed here because OpenROAD regression runs tests in a
176+
# shared environment where clock definitions from other tests
177+
# can leak into read_sdc results.
175178
############################################################
176-
read_sdc $sdc1
177-
178-
report_checks
179-
180-
set sdc7 [make_result_file sdc_cap_prop7.sdc]
181-
write_sdc -no_timestamp $sdc7
182-
183-
# Read compatible format
184-
read_sdc $sdc2
185-
186-
set sdc8 [make_result_file sdc_cap_prop8.sdc]
187-
write_sdc -no_timestamp -compatible $sdc8
188-
189-
report_checks

0 commit comments

Comments
 (0)