Skip to content

Commit 12683d6

Browse files
authored
Merge pull request #325 from The-OpenROAD-Project-staging/sta_latest_merge_strings
update swig file to not use deprecated api and not test it either
2 parents fe61456 + b37b37e commit 12683d6

2 files changed

Lines changed: 6 additions & 2 deletions

File tree

sdc/test/cpp/TestSdcClasses.cc

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4407,7 +4407,7 @@ TEST_F(SdcInitTest, SdcSwapDeratingFactors) {
44074407
// Sdc: deleteDeratingFactors
44084408
// Sdc: allInputs/allOutputs
44094409
// Sdc: findClocksMatching
4410-
// Sdc: isGroupPathName
4410+
// Sdc: isGroupPathName (deprecated) and isPathGroupName
44114411
TEST_F(SdcInitTest, SdcIsGroupPathNameEmpty) {
44124412
Sdc *sdc = sta_->cmdSdc();
44134413
// Suppress deprecation warning -- we intentionally test deprecated API
@@ -4418,6 +4418,10 @@ TEST_F(SdcInitTest, SdcIsGroupPathNameEmpty) {
44184418
EXPECT_FALSE(is_group);
44194419
}
44204420

4421+
TEST_F(SdcInitTest, SdcIsPathGroupNameEmpty) {
4422+
EXPECT_FALSE(sta_->isPathGroupName("nonexistent", sta_->cmdSdc()));
4423+
}
4424+
44214425
// Sdc: setVoltage
44224426
TEST_F(SdcInitTest, SdcSetVoltageGlobal) {
44234427
ASSERT_NO_THROW(( [&](){

search/Search.i

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ endpoint_slack(const Pin *pin,
238238
Sta *sta = Sta::sta();
239239
sta->ensureLibLinked();
240240
if (!path_group_name.empty()
241-
&& !sta->isGroupPathName(path_group_name, sta->cmdSdc())) {
241+
&& !sta->isPathGroupName(path_group_name, sta->cmdSdc())) {
242242
sta->report()->error(1577, "{} is not a known path group name.",
243243
path_group_name);
244244
return INF;

0 commit comments

Comments
 (0)