Skip to content

Commit cf1db11

Browse files
jhkim-piiclaude
andcommitted
Remove dead re-add constraint blocks from SDC tests
removeConstraints was removed upstream in STA 3.0 (MCMM refactor). The "Re-add constraints" blocks were originally preceded by remove_constraints calls; without them, the re-adds are no-ops. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
1 parent bc7639b commit cf1db11

3 files changed

Lines changed: 2 additions & 107 deletions

File tree

sdc/test/sdc_exception_merge_priority.ok

Lines changed: 0 additions & 81 deletions
Original file line numberDiff line numberDiff line change
@@ -1094,86 +1094,5 @@ Path Type: max
10941094
7.89 slack (MET)
10951095

10961096

1097-
Startpoint: reg2 (rising edge-triggered flip-flop clocked by clk1)
1098-
Endpoint: out1 (output port clocked by clk1)
1099-
Path Group: grp1
1100-
Path Type: max
1101-
1102-
Delay Time Description
1103-
---------------------------------------------------------
1104-
0.00 0.00 clock clk1 (rise edge)
1105-
0.00 0.00 clock network delay (ideal)
1106-
0.00 0.00 ^ reg2/CK (DFF_X1)
1107-
0.08 0.08 ^ reg2/Q (DFF_X1)
1108-
0.00 0.08 ^ out1 (out)
1109-
0.08 data arrival time
1110-
1111-
20.00 20.00 clock clk1 (rise edge)
1112-
0.00 20.00 clock network delay (ideal)
1113-
0.00 20.00 clock reconvergence pessimism
1114-
-3.00 17.00 output external delay
1115-
17.00 data required time
1116-
---------------------------------------------------------
1117-
17.00 data required time
1118-
-0.08 data arrival time
1119-
---------------------------------------------------------
1120-
16.92 slack (MET)
1121-
1122-
1123-
Startpoint: reg3 (rising edge-triggered flip-flop clocked by clk2)
1124-
Endpoint: out2 (output port clocked by clk2)
1125-
Path Group: grp3
1126-
Path Type: max
1127-
1128-
Delay Time Description
1129-
---------------------------------------------------------
1130-
0.00 0.00 clock clk2 (rise edge)
1131-
0.00 0.00 clock network delay (ideal)
1132-
0.00 0.00 ^ reg3/CK (DFF_X1)
1133-
0.08 0.08 ^ reg3/Q (DFF_X1)
1134-
0.00 0.08 ^ out2 (out)
1135-
0.08 data arrival time
1136-
1137-
20.00 20.00 clock clk2 (rise edge)
1138-
0.00 20.00 clock network delay (ideal)
1139-
0.00 20.00 clock reconvergence pessimism
1140-
-3.00 17.00 output external delay
1141-
17.00 data required time
1142-
---------------------------------------------------------
1143-
17.00 data required time
1144-
-0.08 data arrival time
1145-
---------------------------------------------------------
1146-
16.92 slack (MET)
1147-
1148-
1149-
Startpoint: in3 (input port clocked by clk2)
1150-
Endpoint: reg2 (rising edge-triggered flip-flop clocked by clk1)
1151-
Path Group: clk1
1152-
Path Type: max
1153-
1154-
Delay Time Description
1155-
---------------------------------------------------------
1156-
0.00 0.00 clock clk2 (rise edge)
1157-
0.00 0.00 clock network delay (ideal)
1158-
2.00 2.00 v input external delay
1159-
0.00 2.00 v in3 (in)
1160-
0.05 2.05 v or1/ZN (OR2_X1)
1161-
0.03 2.07 ^ nor1/ZN (NOR2_X1)
1162-
0.00 2.07 ^ reg2/D (DFF_X1)
1163-
2.07 data arrival time
1164-
1165-
10.00 10.00 clock clk1 (rise edge)
1166-
0.00 10.00 clock network delay (ideal)
1167-
0.00 10.00 clock reconvergence pessimism
1168-
10.00 ^ reg2/CK (DFF_X1)
1169-
-0.03 9.97 library setup time
1170-
9.97 data required time
1171-
---------------------------------------------------------
1172-
9.97 data required time
1173-
-2.07 data arrival time
1174-
---------------------------------------------------------
1175-
7.89 slack (MET)
1176-
1177-
11781097
--- write_sdc with exceptions ---
11791098
--- write_sdc compatible with exceptions ---

sdc/test/sdc_exception_merge_priority.tcl

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Targets: ExceptionPath.cc exception merging, priority, matches,
44
# overrides, through-pin matching, ExceptionThru matching,
55
# Sdc.cc addException, findException, isPathGroupName,
6-
# pathGroupNames, removeConstraints, constraintsChanged,
6+
# pathGroupNames,
77
# makeExceptionFrom/Thru/To, checkExceptionFromPins,
88
# checkExceptionToPins, deleteExceptionFrom/Thru/To,
99
# WriteSdc.cc writeExceptions (various exception types)
@@ -115,21 +115,6 @@ puts "--- exception override: false path then max_delay ---"
115115
set_max_delay -from [get_ports in3] -to [get_ports out2] 5.0
116116
report_checks
117117

118-
# Re-add constraints for write_sdc
119-
create_clock -name clk1 -period 10 [get_ports clk1]
120-
create_clock -name clk2 -period 20 [get_ports clk2]
121-
set_input_delay -clock clk1 2.0 [get_ports in1]
122-
set_input_delay -clock clk1 2.0 [get_ports in2]
123-
set_input_delay -clock clk2 2.0 [get_ports in3]
124-
set_output_delay -clock clk1 3.0 [get_ports out1]
125-
set_output_delay -clock clk2 3.0 [get_ports out2]
126-
127-
set_false_path -from [get_clocks clk1] -to [get_clocks clk2]
128-
set_multicycle_path -setup 2 -from [get_ports in1] -to [get_ports out1]
129-
set_max_delay -from [get_ports in2] -to [get_ports out1] 8.0
130-
group_path -name grp1 -from [get_clocks clk1]
131-
report_checks
132-
133118
# Write SDC with all exception types
134119
puts "--- write_sdc with exceptions ---"
135120
set sdc1 [make_result_file sdc_exception_merge1.sdc]

sdc/test/sdc_filter_query.tcl

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@
44
# Sdc.cc: allInputs, allOutputs, isConstrained (pin, instance, net),
55
# findClocksMatching, sortedClocks, findClock,
66
# isClockSrc, isClock, isIdealClock,
7-
# clkThruTristateEnabled, setClkThruTristateEnabled,
8-
# removeConstraints
7+
# clkThruTristateEnabled, setClkThruTristateEnabled
98
# Sdc.i: all_inputs_cmd, all_outputs_cmd, filter_ports, filter_insts,
109
# filter_pins, filter_clocks, filter_lib_cells, filter_lib_pins,
1110
# filter_liberty_libraries, filter_nets, filter_timing_arcs,
@@ -179,14 +178,6 @@ diff_files sdc_filter_query1.sdcok $sdc1
179178
unset_case_analysis [get_ports in1]
180179
unset_case_analysis [get_ports in2]
181180

182-
############################################################
183-
# Re-apply constraints for final write
184-
############################################################
185-
create_clock -name clk1 -period 10 [get_ports clk1]
186-
create_clock -name clk2 -period 20 [get_ports clk2]
187-
set_input_delay -clock clk1 2.0 [get_ports in1]
188-
set_output_delay -clock clk1 3.0 [get_ports out1]
189-
190181
set sdc2 [make_result_file sdc_filter_query2.sdc]
191182
write_sdc -no_timestamp $sdc2
192183
diff_files sdc_filter_query2.sdcok $sdc2

0 commit comments

Comments
 (0)