banClients: Use arrays instead of collections, like everywhere else

I don't really like this, to be honest. Collections would be far
superior to accepting arrays as parameters. However, alea iacta est,
and having just one or two API methods with a different method layout
would be kind of weird.

Perhaps we can do some kind of an "Array 2.0" at some point in time.

Author: rogermb

src/main/java/com/github/theholywaffle/teamspeak3/TS3Api.java

@@ -36,7 +36,6 @@
 
 import java.io.InputStream;
 import java.io.OutputStream;
-import java.util.Collection;
 import java.util.List;
 import java.util.Map;
 import java.util.regex.Pattern;
@@ -614,7 +613,7 @@ public int[] banClient(int clientId, String reason) {
 	 * @see Client#getId()
 	 * @see #addBan(String, String, String, long, String)
 	 */
-	public int[] banClients(Collection<Integer> clientIds, long timeInSeconds, String reason, boolean continueOnError) {
+	public int[] banClients(int[] clientIds, long timeInSeconds, String reason, boolean continueOnError) {
 		return asyncApi.banClients(clientIds, timeInSeconds, reason, continueOnError).getUninterruptibly();
 	}
 

src/main/java/com/github/theholywaffle/teamspeak3/TS3ApiAsync.java

@@ -600,7 +600,7 @@ public CommandFuture<int[]> banClient(int clientId, long timeInSeconds) {
 	 * @see #addBan(String, String, String, long, String)
 	 */
 	public CommandFuture<int[]> banClient(int clientId, long timeInSeconds, String reason) {
-		Command cmd = BanCommands.banClient(Collections.singletonList(clientId), timeInSeconds, reason, false);
+		Command cmd = BanCommands.banClient(new int[] {clientId}, timeInSeconds, reason, false);
 		return executeAndReturnIntArray(cmd, "banid");
 	}
 
@@ -663,7 +663,10 @@ public CommandFuture<int[]> banClient(int clientId, String reason) {
 	 * @see Client#getId()
 	 * @see #addBan(String, String, String, long, String)
 	 */
-	public CommandFuture<int[]> banClients(Collection<Integer> clientIds, long timeInSeconds, String reason, boolean continueOnError) {
+	public CommandFuture<int[]> banClients(int[] clientIds, long timeInSeconds, String reason, boolean continueOnError) {
+		if (clientIds == null) throw new IllegalArgumentException("Client ID array was null");
+		if (clientIds.length == 0) return CommandFuture.immediate(new int[0]); // Success
+
 		Command cmd = BanCommands.banClient(clientIds, timeInSeconds, reason, continueOnError);
 		return executeAndReturnIntArray(cmd, "banid");
 	}

src/main/java/com/github/theholywaffle/teamspeak3/commands/BanCommands.java

@@ -30,8 +30,6 @@
 import com.github.theholywaffle.teamspeak3.commands.parameter.KeyValueParam;
 import com.github.theholywaffle.teamspeak3.commands.parameter.OptionParam;
 
-import java.util.Collection;
-
 public final class BanCommands {
 
 	private BanCommands() {
@@ -53,14 +51,13 @@ public static Command banAdd(String ip, String name, String uid, String myTSId,
 		return builder.build();
 	}
 
-	public static Command banClient(Collection<Integer> clientIds, long timeInSeconds,
-	                                String reason, boolean continueOnError) {
+	public static Command banClient(int[] clientIds, long timeInSeconds, String reason, boolean continueOnError) {
 		CommandBuilder builder = new CommandBuilder("banclient", 4);
 		builder.addIf(timeInSeconds > 0, new KeyValueParam("time", timeInSeconds));
 		builder.addIf(reason != null, new KeyValueParam("banreason", reason));
 		builder.addIf(continueOnError, new OptionParam("continueonerror"));
 
-		ArrayParameter clients = new ArrayParameter(clientIds.size());
+		ArrayParameter clients = new ArrayParameter(clientIds.length);
 		for (int clientId : clientIds) {
 			clients.add(new KeyValueParam("clid", clientId));
 		}