Fix toLowerCase producing locale-dependent results.

We're using Locale.ROOT for all internal case conversions now.

Author: rogermb

src/main/java/com/github/theholywaffle/teamspeak3/TS3Api.java

@@ -36,6 +36,7 @@
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.regex.Pattern;
 
@@ -1312,12 +1313,12 @@ public List<Binding> getBindings() {
 	 * @see #getChannelsByName(String)
 	 */
 	public Channel getChannelByNameExact(String name, final boolean ignoreCase) {
-		final String caseName = ignoreCase ? name.toLowerCase() : name;
+		final String caseName = ignoreCase ? name.toLowerCase(Locale.ROOT) : name;
 		final List<Channel> allChannels = getChannels();
 		if (allChannels == null) return null;
 
 		for (final Channel channel : allChannels) {
-			final String channelName = ignoreCase ? channel.getName().toLowerCase() : channel.getName();
+			final String channelName = ignoreCase ? channel.getName().toLowerCase(Locale.ROOT) : channel.getName();
 			if (caseName.equals(channelName)) {
 				return channel;
 			}
@@ -1603,12 +1604,12 @@ public List<Channel> getChannels() {
 	 * @see #getClientsByName(String)
 	 */
 	public Client getClientByNameExact(String name, final boolean ignoreCase) {
-		final String caseName = ignoreCase ? name.toLowerCase() : name;
+		final String caseName = ignoreCase ? name.toLowerCase(Locale.ROOT) : name;
 		final List<Client> allClients = getClients();
 		if (allClients == null) return null;
 
 		for (final Client client : allClients) {
-			final String clientName = ignoreCase ? client.getNickname().toLowerCase() : client.getNickname();
+			final String clientName = ignoreCase ? client.getNickname().toLowerCase(Locale.ROOT) : client.getNickname();
 			if (caseName.equals(clientName)) {
 				return client;
 			}

src/main/java/com/github/theholywaffle/teamspeak3/TS3ApiAsync.java

@@ -37,6 +37,7 @@
 import java.util.Collection;
 import java.util.Collections;
 import java.util.List;
+import java.util.Locale;
 import java.util.Map;
 import java.util.concurrent.TimeUnit;
 import java.util.regex.Pattern;
@@ -1331,13 +1332,13 @@ public void handle() {
 	 */
 	public CommandFuture<Channel> getChannelByNameExact(String name, final boolean ignoreCase) {
 		final CommandFuture<Channel> future = new CommandFuture<>();
-		final String caseName = ignoreCase ? name.toLowerCase() : name;
+		final String caseName = ignoreCase ? name.toLowerCase(Locale.ROOT) : name;
 
 		getChannels().onSuccess(new CommandFuture.SuccessListener<List<Channel>>() {
 			@Override
 			public void handleSuccess(final List<Channel> allChannels) {
 				for (final Channel c : allChannels) {
-					final String channelName = ignoreCase ? c.getName().toLowerCase() : c.getName();
+					final String channelName = ignoreCase ? c.getName().toLowerCase(Locale.ROOT) : c.getName();
 					if (caseName.equals(channelName)) {
 						future.set(c);
 						return;
@@ -1686,13 +1687,13 @@ public void handle() {
 	 */
 	public CommandFuture<Client> getClientByNameExact(String name, final boolean ignoreCase) {
 		final CommandFuture<Client> future = new CommandFuture<>();
-		final String caseName = ignoreCase ? name.toLowerCase() : name;
+		final String caseName = ignoreCase ? name.toLowerCase(Locale.ROOT) : name;
 
 		getClients().onSuccess(new CommandFuture.SuccessListener<List<Client>>() {
 			@Override
 			public void handleSuccess(final List<Client> allClients) {
 				for (final Client c : allClients) {
-					final String clientName = ignoreCase ? c.getNickname().toLowerCase() : c.getNickname();
+					final String clientName = ignoreCase ? c.getNickname().toLowerCase(Locale.ROOT) : c.getNickname();
 					if (caseName.equals(clientName)) {
 						future.set(c);
 						return;

src/main/java/com/github/theholywaffle/teamspeak3/api/ChannelProperty.java

@@ -26,6 +26,8 @@
  * #L%
  */
 
+import java.util.Locale;
+
 public enum ChannelProperty implements Property {
 
 	CHANNEL_CODEC(true),
@@ -66,7 +68,7 @@ public enum ChannelProperty implements Property {
 	}
 
 	public String getName() {
-		return name().toLowerCase();
+		return name().toLowerCase(Locale.ROOT);
 	}
 
 	public boolean isChangeable() {

src/main/java/com/github/theholywaffle/teamspeak3/api/ClientProperty.java

@@ -26,6 +26,8 @@
  * #L%
  */
 
+import java.util.Locale;
+
 public enum ClientProperty implements Property {
 
 	CID(false),
@@ -92,7 +94,7 @@ public enum ClientProperty implements Property {
 	}
 
 	public String getName() {
-		return name().toLowerCase();
+		return name().toLowerCase(Locale.ROOT);
 	}
 
 	public boolean isChangeable() {

src/main/java/com/github/theholywaffle/teamspeak3/api/ServerInstanceProperty.java

@@ -26,6 +26,8 @@
  * #L%
  */
 
+import java.util.Locale;
+
 public enum ServerInstanceProperty implements Property {
 
 	CONNECTION_BANDWIDTH_RECEIVED_LAST_MINUTE_TOTAL(false),
@@ -68,7 +70,7 @@ public enum ServerInstanceProperty implements Property {
 
 	@Override
 	public String getName() {
-		return name().toLowerCase();
+		return name().toLowerCase(Locale.ROOT);
 	}
 
 	public boolean isChangeable() {

src/main/java/com/github/theholywaffle/teamspeak3/api/VirtualServerProperty.java

@@ -26,6 +26,8 @@
  * #L%
  */
 
+import java.util.Locale;
+
 public enum VirtualServerProperty implements Property {
 
 	CONNECTION_BANDWIDTH_RECEIVED_LAST_MINUTE_TOTAL(false),
@@ -130,7 +132,7 @@ public enum VirtualServerProperty implements Property {
 
 	@Override
 	public String getName() {
-		return name().toLowerCase();
+		return name().toLowerCase(Locale.ROOT);
 	}
 
 	public boolean isChangeable() {