Improve tweening

Author: TheMatiaz0

Assets/Scripts/Popup/PopupManager.cs

@@ -18,7 +18,7 @@ public class PopupManager : MonoBehaviour
     [SerializeField]
     private TweenData closeAnimation;
 
-    private List<Popup> openedPopups = new();
+    private readonly List<Popup> openedPopups = new();
 
     public static PopupManager Instance { get; private set; }
 
@@ -31,7 +31,7 @@ private void Start()
     {
         foreach (var popup in allPopups)
         {
-            ClosePopup(popup);
+            popup.CanvasGroup.transform.localScale = Vector2.zero;
             popup.OnClose += ClosePopup;
         }
     }
@@ -68,7 +68,7 @@ public void OpenPopup(Popup popup)
         openedPopups.Add(popup);
         popup.OpenTween = popup.transform.DOScale(Vector2.one, openAnimation.Duration)
             .SetEase(openAnimation.Ease)
-            .SetTarget(this);
+            .SetLink(popup.gameObject);
     }
 
     public void ClosePopup(PopupType type)
@@ -81,7 +81,7 @@ public void ClosePopup(Popup popup)
     {
         popup.OpenTween?.Kill();
         int previousIndex = openedPopups.FindIndex(x => x == popup) - 1;
-        if (previousIndex > -1 && openedPopups.Count > previousIndex)
+        if (previousIndex >= 0 && openedPopups.Count > previousIndex)
         {
             openedPopups[previousIndex].CanvasGroup.blocksRaycasts = true;
         }
@@ -90,7 +90,7 @@ public void ClosePopup(Popup popup)
         popup.CloseTween = popup.transform.DOScale(Vector2.zero, closeAnimation.Duration * popup.transform.localScale.x)
             .SetEase(closeAnimation.Ease)
             .OnComplete(() => FinalizePopup(popup))
-            .SetTarget(this);
+            .SetLink(popup.gameObject);
     }
 
     private void FinalizePopup(Popup popup)

Assets/Scripts/Utility/Extensions/TMPTweenExtension.cs

@@ -1,10 +1,7 @@
 using DG.Tweening;
 using DG.Tweening.Core;
 using DG.Tweening.Plugins.Options;
-using System.Collections;
-using System.Collections.Generic;
 using TMPro;
-using UnityEngine;
 
 public static class TMPTweenExtension
 {
@@ -17,7 +14,7 @@ public static TweenerCore<string, string, StringOptions> DOType(this TMP_Text ta
         }
 
         var t = DOTween.To(() => target.text, x => target.text = x, endValue, endValue.Length / duration);
-        t.SetTarget(target);
+        t.SetLink(target.gameObject);
         return t;
     }
 
@@ -30,7 +27,7 @@ public static TweenerCore<string, string, StringOptions> DOType(this TMP_InputFi
         }
 
         var t = DOTween.To(() => target.text, x => target.text = x, endValue, endValue.Length / duration);
-        t.SetTarget(target);
+        t.SetLink(target.gameObject);
         return t;
     }
 }