Ensure account attributes appear in login/logout errors.

Author: io7m

palace-books-controller/src/main/java/org/nypl/simplified/books/controller/ProfileAccountLoginTask.kt

@@ -101,6 +101,9 @@ class ProfileAccountLoginTask(
         return this.steps.finishSuccess(Unit)
       }
 
+      this.steps.addAttribute("AccountProviderName", this.account.provider.displayName)
+      this.steps.addAttribute("AccountProviderID", this.account.provider.id.toString())
+
       if (!this.validateRequest()) {
         this.debug("account does not support the given authentication")
         this.steps.currentStepFailed(

palace-books-controller/src/main/java/org/nypl/simplified/books/controller/ProfileAccountLogoutTask.kt

@@ -116,6 +116,9 @@ class ProfileAccountLogoutTask(
       }
 
     return try {
+      this.steps.addAttribute("AccountProviderName", this.account.provider.displayName)
+      this.steps.addAttribute("AccountProviderID", this.account.provider.id.toString())
+
       this.runLogoutURLIfNecessary()
       this.runFCMTokenDeletion()
       this.runDeviceDeactivation()

palace-tests/src/test/java/org/nypl/simplified/tests/books/controller/FakeAccounts.kt

@@ -14,6 +14,8 @@ object FakeAccounts {
 
     Mockito.`when`(provider.id)
       .thenReturn(URI.create("urn:fake"))
+    Mockito.`when`(provider.displayName)
+      .thenReturn("Fake Provider")
 
     return provider
   }