Skip to content

Commit b1fb2d0

Browse files
committed
chore: refactor serializers to remove type hints for compatibility with pyrefly
1 parent 2793509 commit b1fb2d0

9 files changed

Lines changed: 25 additions & 27 deletions

src/api/serializers/article_serializer.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
from rest_framework import serializers
22

3-
from api.models import Article, NewsSite
3+
from api.models import Article
44
from api.serializers.author_serializer import AuthorSerializer
55
from api.serializers.event_serializer import EventSerializer
66
from api.serializers.launch_serializer import LaunchSerializer
77

88

9-
class ArticleSerializer(serializers.ModelSerializer[Article]):
10-
news_site: "serializers.StringRelatedField[NewsSite]" = serializers.StringRelatedField()
9+
class ArticleSerializer(serializers.ModelSerializer):
10+
news_site = serializers.StringRelatedField()
1111
launches = LaunchSerializer(many=True)
1212
events = EventSerializer(many=True)
1313
authors = AuthorSerializer(many=True)
1414

15-
class Meta:
15+
class Meta: # pyrefly: ignore[bad-override]
1616
model = Article
1717
fields = [
1818
"id",

src/api/serializers/author_serializer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
from api.serializers.socials_serializer import SocialsSerializer
55

66

7-
class AuthorSerializer(serializers.ModelSerializer[Author]):
7+
class AuthorSerializer(serializers.ModelSerializer):
88
socials = SocialsSerializer(required=False)
99

10-
class Meta:
10+
class Meta: # pyrefly: ignore[bad-override]
1111
model = Author
1212
fields = ["name", "socials"]

src/api/serializers/blog_serializer.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
from rest_framework import serializers
22

3-
from api.models import Blog, NewsSite
3+
from api.models import Blog
44
from api.serializers.author_serializer import AuthorSerializer
55
from api.serializers.event_serializer import EventSerializer
66
from api.serializers.launch_serializer import LaunchSerializer
77

88

99
class BlogSerializer(serializers.ModelSerializer[Blog]):
10-
news_site: "serializers.StringRelatedField[NewsSite]" = serializers.StringRelatedField()
10+
news_site = serializers.StringRelatedField()
1111
launches = LaunchSerializer(many=True)
1212
events = EventSerializer(many=True)
1313
authors = AuthorSerializer(many=True)
1414

15-
class Meta:
15+
class Meta: # pyrefly: ignore[bad-override]
1616
model = Blog
1717
fields = [
1818
"id",
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
from rest_framework import serializers
22

3-
from api.models import Event, Provider
3+
from api.models import Event
44

55

66
class EventSerializer(serializers.ModelSerializer[Event]):
7-
provider: "serializers.StringRelatedField[Provider]" = serializers.StringRelatedField()
7+
provider = serializers.StringRelatedField()
88

9-
class Meta:
9+
class Meta: # pyrefly: ignore[bad-override]
1010
model = Event
1111
fields = ["event_id", "provider"]
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
from rest_framework import serializers
22

3-
from api.models import Launch, Provider
3+
from api.models import Launch
44

55

6-
class LaunchSerializer(serializers.ModelSerializer[Launch]):
7-
provider: "serializers.StringRelatedField[Provider]" = serializers.StringRelatedField()
6+
class LaunchSerializer(serializers.ModelSerializer):
7+
provider = serializers.StringRelatedField()
88

9-
class Meta:
9+
class Meta: # pyrefly: ignore[bad-override]
1010
model = Launch
1111
fields = ["launch_id", "provider"]

src/api/serializers/news_site_serializer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from api.models import NewsSite
44

55

6-
class NewsSiteSerializer(serializers.ModelSerializer[NewsSite]):
7-
class Meta:
6+
class NewsSiteSerializer(serializers.ModelSerializer):
7+
class Meta: # pyrefly: ignore[bad-override]
88
model = NewsSite
99
fields = ["id", "name"]

src/api/serializers/report_serializer.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
from rest_framework import serializers
22

3-
from api.models import NewsSite, Report
3+
from api.models import Report
44
from api.serializers.author_serializer import AuthorSerializer
55

66

77
class ReportSerializer(serializers.ModelSerializer[Report]):
8-
news_site: "serializers.StringRelatedField[NewsSite]" = serializers.StringRelatedField()
8+
news_site = serializers.StringRelatedField()
99
authors = AuthorSerializer(many=True)
1010

11-
class Meta:
11+
class Meta: # pyrefly: ignore[bad-override]
1212
model = Report
1313
fields = [
1414
"id",

src/api/serializers/socials_serializer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
from api.models.socials import Socials
44

55

6-
class SocialsSerializer(serializers.ModelSerializer[Socials]):
7-
class Meta:
6+
class SocialsSerializer(serializers.ModelSerializer):
7+
class Meta: # pyrefly: ignore[bad-override]
88
model = Socials
99
fields = ["x", "youtube", "instagram", "linkedin", "mastodon", "bluesky"]

src/snapy/settings.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,14 @@
1010
"""
1111

1212
from pathlib import Path
13+
from typing import Any
1314

14-
import django_stubs_ext
1515
from environs import Env
1616
from snapy import __version__
1717

1818
env = Env()
1919
env.read_env()
2020

21-
# Extensions for Django Stubs
22-
django_stubs_ext.monkeypatch()
2321

2422
VERSION = __version__
2523

@@ -187,7 +185,7 @@
187185

188186
DEFAULT_AUTO_FIELD = "django.db.models.BigAutoField"
189187

190-
REST_FRAMEWORK = {
188+
REST_FRAMEWORK: dict[str, Any] = { # quick hack because type hint is not correct for the "DEFAULT_THROTTLE_RATES"
191189
"DEFAULT_PAGINATION_CLASS": "api.utils.pagination.CustomLimitOffsetPagination",
192190
"PAGE_SIZE": 10,
193191
"DEFAULT_FILTER_BACKENDS": ["django_filters.rest_framework.DjangoFilterBackend"],

0 commit comments

Comments
 (0)