Skip to content

Commit 024e4e1

Browse files
committed
Update tests where needed
1 parent 7322a71 commit 024e4e1

2 files changed

Lines changed: 5 additions & 15 deletions

File tree

tests/check_buffer.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,6 @@ extern void *ctx;
1010
void setup(void);
1111
void teardown(void);
1212

13-
START_TEST(test_gpu_error) {
14-
const char *msg;
15-
msg = gpucontext_error(NULL, -1);
16-
msg = gpucontext_error(NULL, 99);
17-
msg = gpucontext_error(NULL, GA_NO_ERROR);
18-
ck_assert_str_eq(msg, "No error");
19-
}
20-
END_TEST
21-
2213
static unsigned int refcnt(gpudata *b) {
2314
unsigned int res;
2415
int err;
@@ -189,7 +180,6 @@ Suite *get_suite(void) {
189180
Suite *s = suite_create("buffer");
190181
TCase *tc = tcase_create("API");
191182
tcase_add_checked_fixture(tc, setup, teardown);
192-
tcase_add_test(tc, test_gpu_error);
193183
tcase_add_test(tc, test_buffer_alloc);
194184
tcase_add_test(tc, test_buffer_retain_release);
195185
tcase_add_test(tc, test_buffer_share);

tests/check_buffer_collectives.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ TEST_REDUCE_FAIL(optype, SIZE / sizeof(int), GA_INT, -1, 0, GA_INVALID_ERROR)
193193
TEST_REDUCE_FAIL(src_offset, SIZE / sizeof(int), GA_INT, GA_SUM,
194194
SIZE - sizeof(int), GA_VALUE_ERROR)
195195
TEST_REDUCE_FAIL(elemcount, (size_t)INT_MAX + 1, GA_INT, GA_SUM, 0,
196-
GA_UNSUPPORTED_ERROR)
196+
GA_XLARGE_ERROR)
197197

198198
#define TEST_ALL_REDUCE(systype, gatype, mpitype, coloptype, epsilon, print) \
199199
START_TEST(test_gpucomm_all_reduce_##gatype##_##coloptype) { \
@@ -289,7 +289,7 @@ TEST_ALL_REDUCE_FAIL(src_offset, SIZE / sizeof(int), GA_INT, GA_SUM,
289289
TEST_ALL_REDUCE_FAIL(dest_offset, SIZE / sizeof(int), GA_INT, GA_SUM, 0,
290290
SIZE - sizeof(int), GA_VALUE_ERROR)
291291
TEST_ALL_REDUCE_FAIL(elemcount, (size_t)INT_MAX + 1, GA_INT, GA_SUM, 0, 0,
292-
GA_UNSUPPORTED_ERROR)
292+
GA_XLARGE_ERROR)
293293

294294
#define TEST_REDUCE_SCATTER(systype, gatype, mpitype, coloptype, epsilon, \
295295
print) \
@@ -392,7 +392,7 @@ TEST_REDUCE_SCATTER_FAIL(src_offset, outcount, GA_INT, GA_SUM,
392392
TEST_REDUCE_SCATTER_FAIL(dest_offset, outcount, GA_INT, GA_SUM, 0,
393393
SIZE / comm_ndev - sizeof(int), GA_VALUE_ERROR)
394394
TEST_REDUCE_SCATTER_FAIL(elemcount, (size_t)INT_MAX + 1, GA_INT, GA_SUM, 0, 0,
395-
GA_UNSUPPORTED_ERROR)
395+
GA_XLARGE_ERROR)
396396

397397
#define TEST_BROADCAST(systype, gatype, mpitype, epsilon, print) \
398398
START_TEST(test_gpucomm_broadcast_##gatype) { \
@@ -459,7 +459,7 @@ TEST_BROADCAST_FAIL(datatype, SIZE / sizeof(int), -1, 0, GA_INVALID_ERROR)
459459
TEST_BROADCAST_FAIL(src_offset, SIZE / sizeof(int), GA_INT, SIZE - sizeof(int),
460460
GA_VALUE_ERROR)
461461
TEST_BROADCAST_FAIL(elemcount, (size_t)INT_MAX + 1, GA_INT, 0,
462-
GA_UNSUPPORTED_ERROR)
462+
GA_XLARGE_ERROR)
463463

464464
#define TEST_ALL_GATHER(systype, gatype, mpitype, epsilon, print) \
465465
START_TEST(test_gpucomm_all_gather_##gatype) { \
@@ -533,7 +533,7 @@ TEST_ALL_GATHER_FAIL(src_offset, incount, GA_INT,
533533
TEST_ALL_GATHER_FAIL(dest_offset, incount, GA_INT, 0, SIZE - sizeof(int),
534534
GA_VALUE_ERROR)
535535
TEST_ALL_GATHER_FAIL(elemcount, (size_t)INT_MAX + 1, GA_INT, 0, 0,
536-
GA_UNSUPPORTED_ERROR)
536+
GA_XLARGE_ERROR)
537537

538538
Suite* get_suite(void) {
539539
Suite* s = suite_create("buffer_collectives_API");

0 commit comments

Comments
 (0)