Errors all around.

Author: abergeron

src/gpuarray_buffer.c

@@ -6,6 +6,7 @@
 #include "gpuarray/buffer_collectives.h"
 #include "gpuarray/error.h"
 
+#include "util/error.h"
 #include "private.h"
 
 extern const gpuarray_buffer_ops cuda_ops;
@@ -22,7 +23,7 @@ const gpuarray_buffer_ops *gpuarray_get_ops(const char *name) {
 int gpu_get_platform_count(const char* name, unsigned int* platcount) {
   const gpuarray_buffer_ops* ops = gpuarray_get_ops(name);
   if (ops == NULL) {
-    return GA_INVALID_ERROR;
+    return error_set(&global_err, GA_INVALID_ERROR, "Invalid platform");
   }
   return ops->get_platform_count(platcount);
 }
@@ -31,7 +32,7 @@ int gpu_get_device_count(const char* name, unsigned int platform,
                          unsigned int* devcount) {
   const gpuarray_buffer_ops* ops = gpuarray_get_ops(name);
   if (ops == NULL) {
-    return GA_INVALID_ERROR;
+    return error_set(&global_err, GA_INVALID_ERROR, "Invalid platform");
   }
   return ops->get_device_count(platform, devcount);
 }
@@ -121,7 +122,7 @@ int gpudata_transfer(gpudata *dst, size_t dstoff, gpudata *src, size_t srcoff,
   /* Fallback to host copy */
   tmp = malloc(sz);
   if (tmp == NULL)
-    return GA_MEMORY_ERROR;
+    return error_sys(ctx->err, "malloc");
   res = src_ctx->ops->buffer_read(tmp, src, srcoff, sz);
   if (res != GA_NO_ERROR) {
     free(tmp);

src/gpuarray_buffer_opencl.c

@@ -808,14 +808,6 @@ static int cl_check_extensions(const char **preamble, unsigned int *count,
   if (flags & GA_USE_COMPLEX) {
     return error_set(ctx->err, GA_UNSUPPORTED_ERROR, "Complex are not supported yet");
   }
-  // GA_USE_HALF should always work
-  /*
-  if (flags & GA_USE_HALF) {
-    if (check_ext(ctx, CL_HALF)) return GA_DEVSUP_ERROR;
-    preamble[*count] = PRAGMA CL_HALF ENABLE;
-    (*count)++;
-  }
-  */
   if (flags & GA_USE_CUDA) {
     return error_set(ctx->err, GA_DEVSUP_ERROR, "Cuda kernels not supported on opencl devices");
   }