Merge pull request #414 from tsirif/fix/float_16_collectives

nouiz · web-flow · commit e8e6f87c241e · 2017-05-02T15:35:54.000-04:00
Fix float 16 for cuda collectives
diff --git a/src/gpuarray_collectives_cuda_nccl.c b/src/gpuarray_collectives_cuda_nccl.c
@@ -175,11 +175,12 @@ static inline ncclDataType_t convert_data_type(int typecode) {
   switch (typecode) {
   case GA_BYTE: return ncclChar;
   case GA_INT: return ncclInt;
-  case GA_HALF: return ncclHalf;
   case GA_FLOAT: return ncclFloat;
   case GA_DOUBLE: return ncclDouble;
   case GA_LONG: return ncclInt64;
   case GA_ULONG: return ncclUint64;
+  case GA_HALF: return ncclHalf;
+  case GA_FLOAT16: return ncclHalf;
   }
   return nccl_NUM_TYPES;
 }

Original file line number	Diff line number	Diff line change
`@@ -175,11 +175,12 @@ static inline ncclDataType_t convert_data_type(int typecode) {`
`175`	`175`	`switch (typecode) {`
`176`	`176`	`case GA_BYTE: return ncclChar;`
`177`	`177`	`case GA_INT: return ncclInt;`
`178`		`- case GA_HALF: return ncclHalf;`
`179`	`178`	`case GA_FLOAT: return ncclFloat;`
`180`	`179`	`case GA_DOUBLE: return ncclDouble;`
`181`	`180`	`case GA_LONG: return ncclInt64;`
`182`	`181`	`case GA_ULONG: return ncclUint64;`
	`182`	`+ case GA_HALF: return ncclHalf;`
	`183`	`+ case GA_FLOAT16: return ncclHalf;`
`183`	`184`	`}`
`184`	`185`	`return nccl_NUM_TYPES;`
`185`	`186`	`}`