-
Notifications
You must be signed in to change notification settings - Fork 2
Expand file tree
/
Copy pathchecks.json
More file actions
2887 lines (2887 loc) · 137 KB
/
Copy pathchecks.json
File metadata and controls
2887 lines (2887 loc) · 137 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
{
"$id": "https://raw.githubusercontent.com/ThreeMoonsLab/agents-shipgate/main/docs/checks.json",
"checks": [
{
"autofix_safe": false,
"category": "skill_lint",
"default_severity": "medium",
"description": "Skill body lacks a step-by-step procedure.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#lint-body-001",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"sections"
],
"fires_when": "A SKILL.md body lacks a Procedure, Steps, or Workflow section and does not contain a numbered multi-step procedure.",
"floor_severity": null,
"id": "LINT-BODY-001",
"mvp_tier": "hygiene",
"rationale": "Agents need explicit operational steps to apply a skill consistently.",
"recommendation": "Add a Procedure, Steps, or Workflow section with ordered actions an agent can follow.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_lint",
"default_severity": "medium",
"description": "Skill body lacks an output contract.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#lint-body-003",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"sections"
],
"fires_when": "A SKILL.md body lacks an Output, Deliverable, Result, or Final Response section.",
"floor_severity": null,
"id": "LINT-BODY-003",
"mvp_tier": "hygiene",
"rationale": "Without an output contract, agents and reviewers cannot tell what artifact, response shape, or completion criteria the skill requires.",
"recommendation": "Add an Output section defining the expected artifact, response shape, or completion criteria.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_lint",
"default_severity": "medium",
"description": "Skill body lacks verification criteria.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#lint-body-004",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"sections"
],
"fires_when": "A SKILL.md body lacks Verification, Quality, Tests, or Acceptance Criteria guidance.",
"floor_severity": null,
"id": "LINT-BODY-004",
"mvp_tier": "hygiene",
"rationale": "Verification guidance lets an agent check whether the workflow was applied correctly before reporting completion.",
"recommendation": "Add verification or acceptance criteria for successful skill execution.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_lint",
"default_severity": "high",
"description": "Skill description is too vague to route reliably.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#lint-desc-001",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"description_length",
"generic_phrase"
],
"fires_when": "A skill description is very short or contains generic assistant language instead of concrete trigger conditions.",
"floor_severity": null,
"id": "LINT-DESC-001",
"mvp_tier": "hygiene",
"rationale": "The skill description is the primary routing surface agents inspect before loading the full skill body.",
"recommendation": "Rewrite the description with concrete trigger conditions, domain nouns, and when-to-use guidance.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_lint",
"default_severity": "medium",
"description": "Skill description is overbroad and may false-trigger.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#lint-desc-003",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"description_length",
"overbroad_phrase"
],
"fires_when": "A skill description uses broad trigger terms or exceeds the configured description length.",
"floor_severity": null,
"id": "LINT-DESC-003",
"mvp_tier": "hygiene",
"rationale": "Broad skill descriptions can cause agents to load a skill for tasks outside its intended behavior boundary.",
"recommendation": "Narrow the description to the specific workflow, files, or domain where this skill should activate.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_lint",
"default_severity": "medium",
"description": "Skill script lacks documented --help usage.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#lint-script-001",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"script_path"
],
"fires_when": "A script is bundled with a skill but neither the script nor SKILL.md documents a `--help` usage path.",
"floor_severity": null,
"id": "LINT-SCRIPT-001",
"mvp_tier": "hygiene",
"rationale": "Agent-invoked scripts need discoverable usage text so agents can run them non-interactively and safely.",
"recommendation": "Document safe script invocation in SKILL.md and provide a `--help` mode for agent users.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_lint",
"default_severity": "medium",
"description": "Stateful skill script lacks dry-run support.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#lint-script-004",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"script_path"
],
"fires_when": "A bundled script appears stateful or destructive and does not expose dry-run support.",
"floor_severity": null,
"id": "LINT-SCRIPT-004",
"mvp_tier": "hygiene",
"rationale": "Scripts that mutate files or external state should expose a preview path before agents perform the stateful action.",
"recommendation": "Add `--dry-run` support or document a non-mutating preview path before stateful script execution.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_lint",
"default_severity": "high",
"description": "Skill has invalid YAML frontmatter.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#lint-spec-002",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"error"
],
"fires_when": "A SKILL.md frontmatter block cannot be parsed as a YAML mapping.",
"floor_severity": null,
"id": "LINT-SPEC-002",
"mvp_tier": "hygiene",
"rationale": "Agents use SKILL.md frontmatter for discovery; malformed frontmatter makes the routing surface ambiguous or unreadable.",
"recommendation": "Fix SKILL.md YAML frontmatter so it is a valid mapping.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_lint",
"default_severity": "high",
"description": "Skill is missing required name frontmatter.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#lint-spec-003",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"missing_field"
],
"fires_when": "A SKILL.md frontmatter block lacks a non-empty `name` field.",
"floor_severity": null,
"id": "LINT-SPEC-003",
"mvp_tier": "hygiene",
"rationale": "A stable skill name is required for discovery and unambiguous review.",
"recommendation": "Add a non-empty `name` field to SKILL.md frontmatter.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_lint",
"default_severity": "high",
"description": "Skill is missing required description frontmatter.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#lint-spec-004",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"missing_field"
],
"fires_when": "A SKILL.md frontmatter block lacks a non-empty `description` field.",
"floor_severity": null,
"id": "LINT-SPEC-004",
"mvp_tier": "hygiene",
"rationale": "A clear description tells agents when to select the skill before loading the full body.",
"recommendation": "Add a clear `description` explaining exactly when agents should use the skill.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_security",
"default_severity": "medium",
"description": "Skill lacks data and instruction separation guidance.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#sec-flow-004",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"untrusted_content",
"outbound_or_secret_access"
],
"fires_when": "A skill references untrusted content plus outbound or secret-access behavior without data/instruction separation guidance.",
"floor_severity": null,
"id": "SEC-FLOW-004",
"mvp_tier": "core",
"rationale": "Skills that combine untrusted content with outbound channels or secret access need explicit guidance that untrusted content is data, not agent instructions.",
"recommendation": "Add guidance that untrusted content is data only and must not supply agent instructions.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_security",
"default_severity": "high",
"description": "Skill declares read-only behavior but bundled scripts mutate state.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#sec-mismatch-001",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"mutating_scripts"
],
"fires_when": "A skill description says it is read-only, analytical, or review-only but a bundled script contains stateful or destructive behavior.",
"floor_severity": null,
"id": "SEC-MISMATCH-001",
"mvp_tier": "core",
"rationale": "Reviewers and agents rely on the skill description to understand the behavior boundary before loading scripts and references.",
"recommendation": "Update the declared purpose to include state changes or remove mutating script behavior.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_security",
"default_severity": "critical",
"description": "Skill artifact contains instruction override language.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#sec-pi-001",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"source_path",
"line",
"matched"
],
"fires_when": "Skill, instruction, reference, asset, or script text matches instruction-override language.",
"floor_severity": null,
"id": "SEC-PI-001",
"mvp_tier": "core",
"rationale": "Skill and instruction artifacts are loaded into agent context and must not tell agents to ignore higher-priority instructions.",
"recommendation": "Remove instructions that tell agents to ignore, override, or replace higher-priority instructions.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_security",
"default_severity": "high",
"description": "Skill artifact tells the agent to hide behavior.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#sec-pi-003",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"source_path",
"line",
"matched"
],
"fires_when": "Skill, instruction, reference, asset, or script text tells an agent not to disclose or log behavior.",
"floor_severity": null,
"id": "SEC-PI-003",
"mvp_tier": "core",
"rationale": "Instructions to conceal behavior from users, reviewers, or logs are unsafe in agent behavior surfaces.",
"recommendation": "Remove instructions to hide behavior from users, reviewers, or logs.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_security",
"default_severity": "high",
"description": "Third-party skill lacks provenance metadata.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#sec-prov-001",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"third_party"
],
"fires_when": "A skill declares itself third-party but lacks metadata.shipgate.source provenance.",
"floor_severity": null,
"id": "SEC-PROV-001",
"mvp_tier": "core",
"rationale": "Third-party skills are supply-chain artifacts and need source, owner, version, and review metadata.",
"recommendation": "Add metadata.shipgate.source, source_ref, owner, and review metadata for third-party skills.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_security",
"default_severity": "medium",
"description": "Skill fetches remote instruction content.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#sec-remote-001",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"source_path",
"line"
],
"fires_when": "A skill or bundled artifact fetches remote prompt, instruction, or skill content at runtime.",
"floor_severity": null,
"id": "SEC-REMOTE-001",
"mvp_tier": "core",
"rationale": "Mutable remote prompt or instruction content can change skill behavior after review.",
"recommendation": "Avoid fetching mutable remote instructions at runtime or document source trust and pinning.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_security",
"default_severity": "critical",
"description": "Remote content is fetched and executed.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#sec-remote-002",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"source_path",
"line"
],
"fires_when": "A skill artifact sources or executes content fetched from a remote URL.",
"floor_severity": null,
"id": "SEC-REMOTE-002",
"mvp_tier": "core",
"rationale": "Runtime remote-code execution lets mutable external content change the behavior of a skill after review.",
"recommendation": "Remove runtime remote-code execution or pin, verify, and sandbox the content explicitly.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_security",
"default_severity": "critical",
"description": "Remote content is piped to a shell or interpreter.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#sec-script-001",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"source_path",
"line"
],
"fires_when": "A script, instruction, or command block matches curl/wget piped to shell or interpreter execution.",
"floor_severity": null,
"id": "SEC-SCRIPT-001",
"mvp_tier": "core",
"rationale": "Piping remote content to an interpreter executes mutable external code in the agent environment.",
"recommendation": "Vendor the script or pin and verify remote content instead of piping it directly to an interpreter.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_security",
"default_severity": "critical",
"description": "Destructive or stateful command lacks guardrails.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#sec-script-002",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"source_path",
"line"
],
"fires_when": "A skill artifact contains destructive or stateful command patterns without nearby dry-run or confirmation guidance.",
"floor_severity": null,
"id": "SEC-SCRIPT-002",
"mvp_tier": "core",
"rationale": "Skills that drive destructive commands need dry-run, confirmation, or path validation before an agent can invoke them safely.",
"recommendation": "Add dry-run, confirmation, path validation, or remove destructive commands from the skill workflow.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_security",
"default_severity": "critical",
"description": "Skill artifact contains a hardcoded secret-like value.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#sec-secret-001",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"source_path",
"line",
"secret_kind"
],
"fires_when": "Skill, instruction, reference, asset, or script text matches known token patterns or labeled secret values.",
"floor_severity": null,
"id": "SEC-SECRET-001",
"mvp_tier": "core",
"rationale": "Secrets in skill artifacts can leak into prompts, reports, logs, or agent execution environments.",
"recommendation": "Remove the secret from the skill artifact and rotate the exposed credential.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_security",
"default_severity": "high",
"description": "Skill artifact instructs credential or secret-file access.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#sec-secret-003",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"source_path",
"line",
"credential_reference"
],
"fires_when": "Skill, instruction, reference, asset, or script text references credential files or secret-bearing environment variables.",
"floor_severity": null,
"id": "SEC-SECRET-003",
"mvp_tier": "core",
"rationale": "Skills should not direct agents to inspect broad credential files or environment secrets unless the workflow explicitly scopes and protects them.",
"recommendation": "Remove broad credential-file access or replace it with explicit placeholder-based credential guidance.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "skill_security",
"default_severity": "high",
"description": "Skill pre-approves shell or bash without justification.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#sec-tool-001",
"dynamic_default": false,
"evidence_fields": [
"artifact_path",
"allowed_tools"
],
"fires_when": "SKILL.md frontmatter allows shell/bash-like tools without reviewed script, sandbox, or justification language.",
"floor_severity": null,
"id": "SEC-TOOL-001",
"mvp_tier": "core",
"rationale": "Shell preapproval removes an important confirmation step before an agent runs commands from a skill.",
"recommendation": "Remove shell/bash preapproval or add reviewed-script and sandbox justification.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "action_surface",
"default_severity": "critical",
"description": "Action approval policy was removed.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-action-approval-removed",
"dynamic_default": false,
"evidence_fields": [
"change"
],
"fires_when": "Base action approval.required was true and head no longer requires approval.",
"floor_severity": "high",
"id": "SHIP-ACTION-APPROVAL-REMOVED",
"mvp_tier": "lifecycle",
"rationale": "Removing approval weakens the release boundary for an existing action.",
"recommendation": "Restore action_surface.actions[].approval.required: true or document the reviewed exception under action_surface.actions[].evidence.approval_ticket.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "action_surface",
"default_severity": "high",
"description": "Action declaration weakens an inherited approval or safeguard control.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-action-control-downgrade",
"dynamic_default": false,
"evidence_fields": [
"action_id",
"path",
"inherited",
"declared"
],
"fires_when": "action_surface.actions.approval or safeguards sets an inherited true control to false.",
"floor_severity": null,
"id": "SHIP-ACTION-CONTROL-DOWNGRADE",
"mvp_tier": "lifecycle",
"rationale": "Manifest-wide approval and safeguard controls are governance requirements; per-action metadata should not silently weaken them.",
"recommendation": "Keep the inherited action_surface.actions[] approval/safeguard control enabled or remove the weakening declaration.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "action_surface",
"default_severity": "critical",
"description": "New destructive action lacks approval or rollback controls.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-action-destructive-rollback-missing",
"dynamic_default": false,
"evidence_fields": [
"action_id",
"missing"
],
"fires_when": "An added destructive action lacks approval.required or safeguards.rollback.",
"floor_severity": "high",
"id": "SHIP-ACTION-DESTRUCTIVE-ROLLBACK-MISSING",
"mvp_tier": "lifecycle",
"rationale": "Destructive actions need explicit approval and rollback evidence before release.",
"recommendation": "Declare approval.required and safeguards.rollback or remove the destructive action.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "action_surface",
"default_severity": "high",
"description": "Action declaration weakens the inferred effect.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-action-effect-downgrade-declared",
"dynamic_default": false,
"evidence_fields": [
"action_id",
"inferred_effect",
"declared_effect"
],
"fires_when": "action_surface.actions.effect is lower risk than the effect inferred from the loaded tool metadata.",
"floor_severity": null,
"id": "SHIP-ACTION-EFFECT-DOWNGRADE-DECLARED",
"mvp_tier": "lifecycle",
"rationale": "Per-action metadata should not be able to declare away a higher-risk operation inferred from the tool surface.",
"recommendation": "Set action_surface.actions[].effect to the inferred operation effect or remove the weaker declaration.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "action_surface",
"default_severity": "critical",
"description": "Action effect escalated compared with the base surface.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-action-effect-escalated",
"dynamic_default": false,
"evidence_fields": [
"change"
],
"fires_when": "An action changes to a higher-risk effect such as read to write or write to destructive.",
"floor_severity": "high",
"id": "SHIP-ACTION-EFFECT-ESCALATED",
"mvp_tier": "lifecycle",
"rationale": "Effect escalation changes what the agent can do in the real world and needs explicit review.",
"recommendation": "Review action_surface.actions[].effect; restore the prior effect or document approval/evidence for the escalation.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "action_surface",
"default_severity": "high",
"description": "New external communication action lacks audit evidence.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-action-external-communication-audit-missing",
"dynamic_default": false,
"evidence_fields": [
"action_id",
"missing"
],
"fires_when": "An added external_communication action lacks safeguards.audit_log.",
"floor_severity": null,
"id": "SHIP-ACTION-EXTERNAL-COMMUNICATION-AUDIT-MISSING",
"mvp_tier": "lifecycle",
"rationale": "External communication changes agent blast radius and should be auditable.",
"recommendation": "Declare safeguards.audit_log for the external communication action.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "action_surface",
"default_severity": "critical",
"description": "New financial write action lacks required controls.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-action-financial-write-control-missing",
"dynamic_default": false,
"evidence_fields": [
"action_id",
"missing"
],
"fires_when": "An added action is financial_write and lacks approval.required, safeguards.audit_log, or safeguards.idempotency.",
"floor_severity": "high",
"id": "SHIP-ACTION-FINANCIAL-WRITE-CONTROL-MISSING",
"mvp_tier": "lifecycle",
"rationale": "Financial write actions need approval, audit, and idempotency evidence before release.",
"recommendation": "Declare approval.required, safeguards.audit_log, and safeguards.idempotency.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "action_surface",
"default_severity": "high",
"description": "An action-surface policy requirement is not satisfied.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-action-policy-violation",
"dynamic_default": true,
"evidence_fields": [
"policy_id",
"action_id",
"missing"
],
"fires_when": "A user-declared action_surface.policies rule matches an action and one or more required dot-path values are absent or different.",
"floor_severity": "medium",
"id": "SHIP-ACTION-POLICY-VIOLATION",
"mvp_tier": "lifecycle",
"rationale": "Action Surface Diff policies are the reviewer-facing release boundary for external action capability.",
"recommendation": "Satisfy the action-surface policy requirements or remove/narrow the action.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "action_surface",
"default_severity": "high",
"description": "Action safeguard was removed.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-action-safeguard-removed",
"dynamic_default": false,
"evidence_fields": [
"change"
],
"fires_when": "A previously true action safeguard is false or absent in the head surface.",
"floor_severity": null,
"id": "SHIP-ACTION-SAFEGUARD-REMOVED",
"mvp_tier": "lifecycle",
"rationale": "Removing audit, idempotency, rollback, or dry-run safeguards expands blast radius.",
"recommendation": "Restore the removed action_surface.actions[].safeguards field or document the reviewed exception under action_surface.actions[].evidence.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "action_surface",
"default_severity": "high",
"description": "A loaded tool lacks explicit action-surface metadata.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-action-undeclared",
"dynamic_default": false,
"evidence_fields": [
"action_id",
"tool_name"
],
"fires_when": "action_surface.require_explicit_actions is true and a loaded tool has no matching action_surface.actions entry.",
"floor_severity": null,
"id": "SHIP-ACTION-UNDECLARED",
"mvp_tier": "lifecycle",
"rationale": "Action Surface Diff depends on reviewer-visible action metadata for release decisions.",
"recommendation": "Add action_surface.actions metadata for the tool or disable require_explicit_actions.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "action_surface",
"default_severity": "critical",
"description": "Action surface includes a wildcard or admin-like scope.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-action-wildcard-scope",
"dynamic_default": false,
"evidence_fields": [
"action_id",
"scopes",
"change"
],
"fires_when": "An added action declares a broad scope, or a modified action expands into a broad scope.",
"floor_severity": "high",
"id": "SHIP-ACTION-WILDCARD-SCOPE",
"mvp_tier": "lifecycle",
"rationale": "Wildcard scopes make action blast radius too broad for deterministic release review.",
"recommendation": "Replace action_surface.actions[].scopes with operation-specific scopes; remove wildcard/admin scopes.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "adk",
"default_severity": "high",
"description": "Google ADK toolset cannot be statically enumerated.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-adk-dynamic-toolset-not-enumerable",
"dynamic_default": false,
"evidence_fields": [
"toolset",
"explicit_inventory"
],
"fires_when": "A Google ADK toolset is dynamic or unresolved and no explicit MCP/OpenAPI/tool inventory input is declared.",
"floor_severity": null,
"id": "SHIP-ADK-DYNAMIC-TOOLSET-NOT-ENUMERABLE",
"mvp_tier": "adapter",
"rationale": "Release review needs an explicit tool inventory; ADK MCP/OpenAPI toolsets may resolve tools dynamically at runtime.",
"recommendation": "Provide explicit MCP/OpenAPI/tool inventory inputs for dynamic ADK toolsets.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "adk",
"default_severity": "medium",
"description": "Google ADK eval coverage is not declared.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-adk-eval-coverage-missing",
"dynamic_default": false,
"evidence_fields": [
"agent_count",
"eval_file_count"
],
"fires_when": "Google ADK inputs target production_like or production and no eval files are declared.",
"floor_severity": null,
"id": "SHIP-ADK-EVAL-COVERAGE-MISSING",
"mvp_tier": "adapter",
"rationale": "ADK releases should include response and tool-trajectory eval evidence before promotion.",
"recommendation": "Declare ADK eval files for expected responses and tool-use trajectories.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "adk",
"default_severity": "medium",
"description": "Google ADK function tool lacks static metadata.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-adk-function-tool-metadata-missing",
"dynamic_default": false,
"evidence_fields": [
"missing",
"source_type"
],
"fires_when": "A Google ADK function/config tool lacks description or parameter metadata.",
"floor_severity": null,
"id": "SHIP-ADK-FUNCTION-TOOL-METADATA-MISSING",
"mvp_tier": "adapter",
"rationale": "Static review depends on descriptions and parameter schemas because user ADK code is not imported.",
"recommendation": "Add docstrings, annotations, or explicit local inventory metadata.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "adk",
"default_severity": "high",
"description": "High-risk Google ADK tools lack static guardrail evidence.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-adk-guardrail-evidence-missing",
"dynamic_default": false,
"evidence_fields": [
"tools"
],
"fires_when": "High-risk ADK tools are present without callbacks, plugins, or equivalent manifest policy evidence.",
"floor_severity": null,
"id": "SHIP-ADK-GUARDRAIL-EVIDENCE-MISSING",
"mvp_tier": "adapter",
"rationale": "Callbacks and plugins are the static ADK surface where release reviewers can see guardrail intent.",
"recommendation": "Attach ADK callbacks/plugins or manifest policies that document guardrails.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "adk",
"default_severity": "high",
"description": "Google ADK long-running tool lacks an operation contract.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-adk-longrunning-contract-missing",
"dynamic_default": false,
"evidence_fields": [
"output_schema"
],
"fires_when": "A LongRunningFunctionTool lacks structured status/progress and operation id output evidence.",
"floor_severity": null,
"id": "SHIP-ADK-LONGRUNNING-CONTRACT-MISSING",
"mvp_tier": "adapter",
"rationale": "Long-running tools need explicit status and operation-id semantics for safe continuation.",
"recommendation": "Document operation id, status/progress fields, and completion behavior.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "adk",
"default_severity": "high",
"description": "Google ADK McpToolset lacks a static tool filter.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-adk-mcp-toolset-unfiltered",
"dynamic_default": false,
"evidence_fields": [
"source_ref",
"agent_name",
"inventory_path"
],
"fires_when": "A Google ADK McpToolset has no static tool_filter.",
"floor_severity": null,
"id": "SHIP-ADK-MCP-TOOLSET-UNFILTERED",
"mvp_tier": "adapter",
"rationale": "Unfiltered MCP toolsets can expose more tools than reviewers expect.",
"recommendation": "Declare a tool_filter and provide a local MCP tool inventory.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "api",
"default_severity": "high",
"description": "OpenAI API function schema is not strict enough for reliable tool calls.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-api-function-schema-strictness",
"dynamic_default": false,
"evidence_fields": [
"issues",
"risk_tags"
],
"fires_when": "An OpenAI API function lacks strict=true, object parameters, additionalProperties=false, complete required fields, or bounded risky fields.",
"floor_severity": null,
"id": "SHIP-API-FUNCTION-SCHEMA-STRICTNESS",
"mvp_tier": "adapter",
"rationale": "Strict schemas reduce ambiguous tool arguments and downstream side-effect risk.",
"recommendation": "Use strict function schemas with explicit required fields and constrained risky parameters.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "api",
"default_severity": "medium",
"description": "Deprecated compatibility alias for the v0.3 OpenAI API operational readiness bundle.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-api-operational-readiness",
"dynamic_default": false,
"evidence_fields": [
"legacy_check_id"
],
"fires_when": "Not emitted by v0.4 scans; matching configuration expands to the v0.4 atomic OpenAI API operational readiness checks.",
"floor_severity": null,
"id": "SHIP-API-OPERATIONAL-READINESS",
"mvp_tier": "adapter",
"rationale": "v0.4 emits atomic OpenAI API readiness check IDs, but this ID remains available for existing suppressions, severity overrides, baselines, SARIF consumers, and explain/list-checks workflows during the deprecation window.",
"recommendation": "Migrate suppressions, severity overrides, and baselines to the specific v0.4 SHIP-API-* readiness check IDs.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "api",
"default_severity": "high",
"description": "Prompt scope contradicts enabled OpenAI API tools.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-api-prompt-tool-scope-mismatch",
"dynamic_default": false,
"evidence_fields": [
"tools"
],
"fires_when": "Prompt text says read-only/advice-only while write tools are enabled, or high-risk tools lack approval/confirmation instructions.",
"floor_severity": null,
"id": "SHIP-API-PROMPT-TOOL-SCOPE-MISMATCH",
"mvp_tier": "adapter",
"rationale": "Prompt instructions should match the actual write/high-risk tool surface.",
"recommendation": "Align prompt scope with enabled tools and add approval/confirmation instructions.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "api",
"default_severity": "medium",
"description": "OpenAI API high-risk flow lacks retry policy metadata.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-api-retry-policy-missing",
"dynamic_default": false,
"evidence_fields": [
"high_risk_tools"
],
"fires_when": "High-risk OpenAI API tools exist and no retry_policy is declared.",
"floor_severity": null,
"id": "SHIP-API-RETRY-POLICY-MISSING",
"mvp_tier": "adapter",
"rationale": "Retries need explicit policy metadata so reviewers can reason about duplicate side effects.",
"recommendation": "Declare retry_policy in openai_api.policy_rules or model_config.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "api",
"default_severity": "high",
"description": "OpenAI API write tool may be retried without idempotency evidence.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-api-retry-without-idempotency",
"dynamic_default": false,
"evidence_fields": [
"retry_policy",
"risk_tags"
],
"fires_when": "Retry policy is declared and a risky write tool lacks idempotency evidence.",
"floor_severity": null,
"id": "SHIP-API-RETRY-WITHOUT-IDEMPOTENCY",
"mvp_tier": "core",
"rationale": "Retries against non-idempotent writes can duplicate financial, destructive, or external side effects.",
"recommendation": "Add idempotency evidence for retried risky OpenAI API tools or avoid retrying those side effects.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "api",
"default_severity": "medium",
"description": "OpenAI API structured output schema is missing or under-specified.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-api-structured-output-readiness",
"dynamic_default": false,
"evidence_fields": [
"path",
"issues",
"high_risk_tools"
],
"fires_when": "No response format exists, a response schema is too broad, decision/status fields lack enums, or refusal/needs_review/error modeling is absent.",
"floor_severity": null,
"id": "SHIP-API-STRUCTURED-OUTPUT-READINESS",
"mvp_tier": "adapter",
"rationale": "Downstream release decisions need explicit, structured success/refusal/review modeling.",
"recommendation": "Declare a strict response format with decision/status enums, needs_review/refusal/error fields, and critical fields.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "api",
"default_severity": "medium",
"description": "OpenAI API high-risk flow lacks test case metadata.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-api-test-cases-missing",
"dynamic_default": false,
"evidence_fields": [
"high_risk_tools"
],
"fires_when": "High-risk OpenAI API tools exist and no test cases are declared.",
"floor_severity": null,
"id": "SHIP-API-TEST-CASES-MISSING",
"mvp_tier": "adapter",
"rationale": "High-risk tool-call flows should have release evidence before promotion.",
"recommendation": "Add simple OpenAI API test cases for high-risk tool-call flows.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,
"suggested_patch_kind": "manual"
},
{
"autofix_safe": false,
"category": "api",
"default_severity": "medium",
"description": "OpenAI API high-risk flow lacks timeout metadata.",
"docs_url": "https://github.com/ThreeMoonsLab/agents-shipgate/blob/main/docs/checks.md#ship-api-timeout-missing",
"dynamic_default": false,
"evidence_fields": [
"high_risk_tools"
],
"fires_when": "High-risk OpenAI API tools exist and no timeout metadata is declared.",
"floor_severity": null,
"id": "SHIP-API-TIMEOUT-MISSING",
"mvp_tier": "adapter",
"rationale": "Timeouts define failure behavior and reduce ambiguous tool-call continuation.",
"recommendation": "Declare tool-call timeout metadata for high-risk OpenAI API flows.",
"requires_human_review": true,
"requires_human_review_regardless_of_patch": false,