feat: make DuckDB support opt-in#68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tinycloud-core/duckdbfeaturetinycloud-nodeduckdbfeature and gate DuckDB service setup,/infoadvertisement, invoke handling, and hook subscription validationinclude_duckdb, using-duckdbimage tag suffixesdstack duckdbare passed as one Cargo feature valueValidation
cargo check -p tinycloud-node --features dstackcargo check -p tinycloud-node --features "dstack duckdb"cargo tree -p tinycloud-node --features dstack | rg -n "(^| )duckdb|(^| )arrow" || trueproduced no matchescargo clippy -p tinycloud-node -- -D warningscargo clippy -p tinycloud-node --features "dstack duckdb" -- -D warningscargo test -p tinycloud-node --libcargo test -p tinycloud-node --lib --features "dstack duckdb"cargo test -p tinycloud-core --features duckdb duckdb::go run github.com/rhysd/actionlint/cmd/actionlint@latest -oneline .github/workflows/docker.ymlNote: I did not run a full Docker image build locally because it recreates the long compile this PR is removing from the default path.