TC-1371 fix: canonicalize PKH DID addresses#71
Merged
Conversation
Refs TC-1371
skgbafa
added a commit
to TinyCloudLabs/js-sdk
that referenced
this pull request
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
TC-1371 surfaced a production
no_delegationloop where delegation status and backend access checks could disagree. The public symptom was a user appearing signed in while API calls still returnedNo delegation found. One class of failure here is treating EVM addresses and PKH DIDs as raw strings: lowercase addresses, EIP-55 checksum addresses, and DID URLs with fragments can identify the same principal but fail equality checks.Summary
tinycloud-authidentity helpers for canonical EIP-155 PKH DIDs.Tests
cargo fmtcargo test -p tinycloud-authcargo test -p tinycloud-coreInternal reference: TC-1371.