Add GitHub Actions workflow for publishing NuGet packages and extend semaphore functionality

Author: Alexr03

.github/workflows/publish-nuget.yml

@@ -0,0 +1,73 @@
+name: Publish NuGet Packages
+
+on:
+  push:
+    tags:
+      - 'v*'
+  workflow_dispatch:
+    inputs:
+      version:
+        description: 'Package version (e.g. 3.1.0, 3.1.0-preview.1). Leave empty to derive from tag or branch.'
+        required: false
+
+permissions:
+  packages: write
+  contents: read
+
+jobs:
+  publish:
+    runs-on: windows-latest
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+
+      - name: Setup .NET
+        uses: actions/setup-dotnet@v4
+        with:
+          dotnet-version: |
+            6.0.x
+            8.0.x
+
+      - name: Determine version
+        id: version
+        shell: bash
+        run: |
+          if [[ -n "${{ github.event.inputs.version }}" ]]; then
+            VERSION="${{ github.event.inputs.version }}"
+          elif [[ "${{ github.ref_type }}" == "tag" ]]; then
+            # Strip leading 'v' from tag (v3.1.0 -> 3.1.0)
+            VERSION="${{ github.ref_name }}"
+            VERSION="${VERSION#v}"
+          else
+            # Fallback: use VersionPrefix from Global.props + short SHA for pre-release
+            VERSION="3.0.0-dev.${{ github.run_number }}"
+          fi
+          echo "VERSION=$VERSION" >> "$GITHUB_OUTPUT"
+          echo "Resolved version: $VERSION"
+
+      - name: Restore dependencies
+        run: dotnet restore
+
+      - name: Build
+        run: dotnet build --configuration Release --no-restore /p:Version=${{ steps.version.outputs.VERSION }}
+
+      - name: Run tests
+        run: dotnet test --configuration Release --no-build --verbosity normal
+
+      - name: Pack NuGet packages
+        run: dotnet pack --configuration Release --no-build --output ./nupkgs /p:Version=${{ steps.version.outputs.VERSION }}
+
+      - name: Push to GitHub Packages
+        run: dotnet nuget push "./nupkgs/*.nupkg" --source "https://nuget.pkg.github.com/${{ github.repository_owner }}/index.json" --api-key ${{ secrets.GITHUB_TOKEN }} --skip-duplicate
+        env:
+          DOTNET_NOLOGO: true
+
+      - name: Upload packages as artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: nuget-packages
+          path: ./nupkgs/
+          retention-days: 30

src/FubarDev.FtpServer/Networking/PausableFtpService.cs

@@ -71,22 +71,23 @@ public virtual async Task StartAsync(CancellationToken cancellationToken)
                 throw new InvalidOperationException($"Status must be {FtpServiceStatus.ReadyToRun}, but was {Status}.");
             }
 
-            using var semaphore = new SemaphoreSlim(0, 1);
+            using var semaphore = new SemaphoreSlimExt(0, 1);
             _jobPaused = new CancellationTokenSource();
             _task = RunAsync(
                 new Progress<FtpServiceStatus>(
                     status =>
                     {
                         Status = status;
 
-                        if (status == FtpServiceStatus.Running)
+                        if (status == FtpServiceStatus.Running && !semaphore.IsDisposed)
                         {
                             // ReSharper disable once AccessToDisposedClosure
-                            semaphore.Release();
+                            semaphore?.Release();
                         }
                     }));
 
-            await semaphore.WaitAsync(cancellationToken);
+            var res = semaphore.WaitAsync(cancellationToken);
+            res.Wait(cancellationToken);
         }
 
         /// <inheritdoc />

src/FubarDev.FtpServer/SemaphoreSlimExt.cs

@@ -0,0 +1,28 @@
+// <copyright file="SemaphoreSlimExt.cs" company="Fubar Development Junker">
+// Copyright (c) Fubar Development Junker. All rights reserved.
+// </copyright>
+
+using System.Threading;
+
+namespace FubarDev.FtpServer
+{
+    internal class SemaphoreSlimExt : SemaphoreSlim
+    {
+        public SemaphoreSlimExt(int initialCount)
+            : base(initialCount)
+        {
+        }
+        public SemaphoreSlimExt(int initialCount, int maxCount)
+            : base(initialCount, maxCount)
+        {
+        }
+
+        public bool IsDisposed { get; internal set; }
+
+        protected override void Dispose(bool disposing)
+        {
+            base.Dispose(disposing);
+            IsDisposed = true;
+        }
+    }
+}