Merge pull request piquette#13 from piquette/develop

Modules migration and Go 1.13 support.

Author: ackleymi

.travis.yml

@@ -1,8 +1,28 @@
+language: go
+
+matrix:
+  allow_failures:
+    - go: tip
+  fast_finish: true
+  include:
+  - go: 1.11.x
+    env: GO111MODULE=on
+  - go: 1.12.x
+    env: GO111MODULE=on
+  - go: 1.13.x
+  - go: tip
+
 before_install:
-  # Install code coverage / coveralls tooling
-  - go get -u golang.org/x/tools/cmd/cover
-  - go get -u github.com/modocache/gover
-  - go get -u github.com/mattn/goveralls
+  - if [[ "${GO111MODULE}" = "on" ]]; then mkdir "${HOME}/go"; export GOPATH="${HOME}/go"; fi
+  - go mod download
+  - if [[ "${GO111MODULE}" = "on" ]]; then export PATH="${GOPATH}/bin:${GOROOT}/bin:${PATH}"; fi
+
+  # Install lint / code coverage / coveralls tooling
+  - travis_retry go get -u golang.org/x/net/http2
+  - travis_retry go get -u golang.org/x/tools/cmd/cover
+  - travis_retry go get -u github.com/modocache/gover
+  - travis_retry go get -u github.com/mattn/goveralls
+  - travis_retry go get -u golang.org/x/lint/golint
 
   # Unpack and start test server so that the test suite can talk to it
   - |
@@ -23,17 +43,6 @@ env:
   global:
     - FINANCE_MOCK_VERSION=0.0.5
 
-go:
-  - "1.10"
-  - tip
-
-language: go
-
-matrix:
-  allow_failures:
-    - go: tip
-  fast_finish: true
-
 script:
   - make
   - make coverage
@@ -44,4 +53,4 @@ after_script:
   # Send code coverage report to coveralls.io
   - goveralls -service=travis-ci -coverprofile=gover.coverprofile
 
-sudo: false
+sudo: false

Gopkg.lock

@@ -1,11 +1,17 @@
-all: test vet
+all: test bench vet lint check-gofmt
 
 bench:
 	go test -race -bench . -run "Benchmark" ./form
 
 build:
 	go build ./...
 
+check-gofmt:
+	scripts/check_gofmt.sh
+
+lint:
+	golint -set_exit_status ./...
+
 test:
 	go test -v ./...
 
@@ -18,4 +24,4 @@ coverage:
 	go list ./... | xargs -n1 -I {} -P 4 go test -covermode=count -coverprofile=../../../{}/profile.coverprofile {}
 
 clean:
-	find . -name \*.coverprofile -delete
+	find . -name \*.coverprofile -delete

Gopkg.toml

@@ -32,7 +32,7 @@ For now, for details on all the functionality in this library, see the [GoDoc][g
 
 ## Installation
 
-It is best to use a dependency management tool, but if you want to retrieve it manually, use -
+This project supports modules and Go 1.13+. Add `finance-go` to your own project the usual way -
 
 ```sh
 go get github.com/piquette/finance-go

Makefile

@@ -0,0 +1,10 @@
+module github.com/piquette/finance-go
+
+go 1.13
+
+require (
+	github.com/davecgh/go-spew v1.1.1
+	github.com/pmezard/go-difflib v1.0.0
+	github.com/shopspring/decimal v0.0.0-20180709203117-cd690d0c9e24
+	github.com/stretchr/testify v1.2.2
+)

README.md

@@ -0,0 +1,8 @@
+github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
+github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
+github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
+github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
+github.com/shopspring/decimal v0.0.0-20180709203117-cd690d0c9e24 h1:pntxY8Ary0t43dCZ5dqY4YTJCObLY1kIXl0uzMv+7DE=
+github.com/shopspring/decimal v0.0.0-20180709203117-cd690d0c9e24/go.mod h1:M+9NzErvs504Cn4c5DxATwIqPbtswREoFCre64PpcG4=
+github.com/stretchr/testify v1.2.2 h1:bSDNvY7ZPG5RlJ8otE/7V6gMiyenm9RtJ7IUVIAoJ1w=
+github.com/stretchr/testify v1.2.2/go.mod h1:a8OnRcib4nhh0OaRAV+Yts87kKdq0PP7pXfy6kDkUVs=

go.mod

@@ -4,11 +4,11 @@ import (
 	"context"
 	"strings"
 
-	chart "github.com/piquette/finance-go/chart"
 	finance "github.com/piquette/finance-go"
+	chart "github.com/piquette/finance-go/chart"
+	"github.com/piquette/finance-go/datetime"
 	"github.com/piquette/finance-go/form"
 	"github.com/piquette/finance-go/iter"
-	"github.com/piquette/finance-go/datetime"
 )
 
 // Client is used to invoke quote APIs.
@@ -42,14 +42,14 @@ func (i *Iter) Quote() *finance.Quote {
 	return i.Current().(*finance.Quote)
 }
 
-//Gives the Day's Close when you input a historical date
+// GetHistoricalQuote provides a single chart bar for a historical date.
 func GetHistoricalQuote(symbol string, month int, day int, year int) (*finance.ChartBar, error) {
 	p := &chart.Params{
 		Symbol:   symbol,
 		Start:    &datetime.Datetime{Month: month, Day: day, Year: year},
 		End:      &datetime.Datetime{Month: month, Day: day, Year: year},
 		Interval: datetime.OneDay,
-	  }
+	}
 	iter := chart.Get(p)
 	for iter.Next() {
 		b := iter.Bar()

go.sum

@@ -23,9 +23,9 @@ func TestHistoricalQuote(t *testing.T) {
 	TestMonth := 1
 	TestDay := 11
 	TestYear := 2018
-	
+
 	q, err := GetHistoricalQuote(tests.TestEquitySymbol, TestMonth, TestDay, TestYear)
-	
+
 	assert.Nil(t, err)
 	assert.NotNil(t, q)
 	high, _ := q.High.Float64()

quote/client.go

@@ -0,0 +1,16 @@
+#!/bin/bash
+
+find_files() {
+  find . -not \( \
+      \( \
+        -name 'vendor' \
+      \) -prune \
+    \) -name '*.go'
+}
+
+bad_files=$(find_files | xargs gofmt -s -l)
+if [[ -n "${bad_files}" ]]; then
+    echo "!!! gofmt -s needs to be run on the following files: "
+    echo "${bad_files}"
+    exit 1
+fi