improve error logging and close old serial port on reader reconnect

Author: timothywashburn

src/controllers/rfid_reader_controller.py

@@ -1,6 +1,7 @@
 import time
 import socket
 import logging
+from os.path import exists
 from threading import Thread
 
 from PyQt6.QtCore import QTimer
@@ -37,9 +38,12 @@ def _run(self, reader):
             try:
                 in_waiting = reader.get_ser_in_waiting()
             except OSError as e:
-                if not scanner_error:
+                if not exists(reader._usb_id):
                     logging.error("Card reader disconnected, disabling until reconnection: %s", e)
                     scanner_error = True
+                else:
+                    logging.debug("Card reader transient error, retrying: %s", e)
+                    time.sleep(0.2)
                 continue
 
             if in_waiting >= 14:

src/hardware/rfid_reader.py

@@ -32,6 +32,12 @@ def __init__(self, usb_id):
                 time.sleep(attempt * 0.5)
 
     def _init_pn532(self):
+        if self._pn532 is not None:
+            try:
+                self._pn532._uart.close()
+            except Exception as e:
+                logging.warning("Failed to close card reader serial port: %s", e)
+            self._pn532 = None
         uart = serial.Serial(self._usb_id, baudrate=115200, timeout=0.1)
         uart.reset_input_buffer()
         uart.reset_output_buffer()