Workflow fixes and test stability improvements

- Fix NuGetPublish, Release, and Snapshot workflow configs for .NET 10
- Remove redundant test step from NuGetPublish workflow
- Replace System.Random with MersenneTwister for cross-framework determinism
- Add index tiebreaker to SCE sort for stable ordering across .NET versions
- Enable parallel test execution with class-level scope
- Serialize TimeSeriesDownload tests to avoid connection throttling

Author: HadenSmith

.github/workflows/NuGetPublish.yml

@@ -7,6 +7,7 @@ on:
 jobs:
   publish:
     runs-on: windows-latest
+    timeout-minutes: 60
     steps:
       - uses: actions/checkout@v4
         with:
@@ -27,9 +28,6 @@ jobs:
       - name: Build
         run: dotnet build Numerics/Numerics.csproj -c Release -p:Version=${{ steps.version.outputs.VERSION }}
 
-      - name: Test (all frameworks)
-        run: dotnet test -c Release --no-build
-
       - name: Pack
         run: dotnet pack Numerics/Numerics.csproj -c Release --no-build -p:Version=${{ steps.version.outputs.VERSION }}
 

.github/workflows/Release.yml

@@ -9,7 +9,7 @@ jobs:
   build:
     uses: HydrologicEngineeringCenter/dotnet-workflows/.github/workflows/release.yml@main
     with:
-      dotnet-version: '9.0.x'
+      dotnet-version: '10.0.x'
       project-names: 'Numerics'
       run-tests: true
       nuget-source: 'https://www.hec.usace.army.mil/nexus/repository/consequences-nuget-public/'

.github/workflows/Snapshot.yml

@@ -8,9 +8,9 @@ jobs:
   build:
     uses: HydrologicEngineeringCenter/dotnet-workflows/.github/workflows/snapshot.yml@main
     with:
-      dotnet-version: '9.0.x'
+      dotnet-version: '10.0.x'
       project-names: 'Numerics'
-      version: '1.0.0'
+      version: '2.0.0'
       run-tests: true
       nuget-source: 'https://www.hec.usace.army.mil/nexus/repository/consequences-nuget-public/'
     secrets:

Numerics/Distributions/Univariate/VonMises.cs

@@ -34,6 +34,7 @@
 using Numerics.Mathematics.Optimization;
 using Numerics.Mathematics.RootFinding;
 using Numerics.Mathematics.SpecialFunctions;
+using Numerics.Sampling;
 
 namespace Numerics.Distributions
 {
@@ -439,7 +440,7 @@ public override double[] GenerateRandomValues(int sampleSize, int seed = -1)
             if (_parametersValid == false)
                 ValidateParameters([Mu, Kappa], true);
 
-            var rng = seed < 0 ? new Random() : new Random(seed);
+            var rng = seed < 0 ? new MersenneTwister() : new MersenneTwister(seed);
             var values = new double[sampleSize];
 
             if (_kappa < 1e-10)

Numerics/Machine Learning/Supervised/KNearestNeighbors.cs

@@ -30,6 +30,7 @@
 
 using Numerics.Data.Statistics;
 using Numerics.Mathematics.LinearAlgebra;
+using Numerics.Sampling;
 using System;
 using System.Linq;
 using System.Threading.Tasks;
@@ -363,7 +364,7 @@ public KNearestNeighbors(Matrix x, Vector y, int k)
         /// <param name="seed">Optional. The prng seed. If negative or zero, then the computer clock is used as a seed.</param>
         private double[]? kNNBootstrapPredict(Matrix xTrain, Vector yTrain, Matrix xTest, int seed = -1)
         {
-            var rnd = seed > 0 ? new Random(seed) : new Random();
+            var rnd = seed > 0 ? new MersenneTwister(seed) : new MersenneTwister();
             var idxs = rnd.NextIntegers(0, xTrain.NumberOfRows, xTrain.NumberOfRows);
             var bootX = new Matrix(xTrain.NumberOfRows, xTrain.NumberOfColumns);
             var bootY = new Vector(yTrain.Length);
@@ -393,7 +394,7 @@ public KNearestNeighbors(Matrix x, Vector y, int k)
             var output = new double[xTest.NumberOfRows, 4]; // lower, median, upper, mean
 
             var bootResults = new double[xTest.NumberOfRows, realizations];
-            var rnd = seed > 0 ? new Random(seed) : new Random();
+            var rnd = seed > 0 ? new MersenneTwister(seed) : new MersenneTwister();
             var seeds = rnd.NextIntegers(realizations);
 
             // Bootstrap the predictions

Numerics/Mathematics/Integration/MonteCarloIntegration.cs

@@ -28,6 +28,7 @@
 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
 
+using Numerics.Sampling;
 using System;
 using System.Collections.Generic;
 using System.Linq;
@@ -83,7 +84,7 @@ public MonteCarloIntegration(Func<double[], double> function, int dimensions, IL
             Dimensions = dimensions;
             Min = min.ToArray();
             Max = max.ToArray();
-            Random = new Random();
+            Random = new MersenneTwister();
         }
 
         /// <summary>

Numerics/Mathematics/Optimization/Global/ShuffledComplexEvolution.cs

@@ -175,9 +175,9 @@ protected override void Optimize()
 
             // Initialize shuffled complex evolution (SCE) algorithm
             // Create list of complex prngs
-            var complexPRNGs = new List<Random>();
+            var complexPRNGs = new List<MersenneTwister>();
             for (i = 0; i < Complexes; i++)
-                complexPRNGs.Add(new Random(prng.Next()));
+                complexPRNGs.Add(new MersenneTwister(prng.Next()));
 
             // Create trapezoidal cumulative probability for points in complex
             var cdf = Trapezoidal(CCEIterations);
@@ -211,7 +211,7 @@ protected override void Optimize()
                 }
 
                 // Rank the points in terms of fitness (i.e., order of increasing function value).
-                Dpoints.Sort((x, y) => x.ParameterSet.Fitness.CompareTo(y.ParameterSet.Fitness));
+                Dpoints.Sort((x, y) => { int c = x.ParameterSet.Fitness.CompareTo(y.ParameterSet.Fitness); return c != 0 ? c : x.Index.CompareTo(y.Index); });
 
                 // Next reset the indexes, so that i = 0 represents the point With the smallest function value.
                 for (i = 0; i <= Dpoints.Count - 1; i++)
@@ -287,7 +287,7 @@ private void EvolveComplex(int alpha, ref List<PointFitness> Acomplex, double[]
                 {
 
                     // Rank the B points in terms of fitness (i.e., order of increasing function value.
-                    B.Sort((x, y) => x.ParameterSet.Fitness.CompareTo(y.ParameterSet.Fitness));
+                    B.Sort((x, y) => { int c = x.ParameterSet.Fitness.CompareTo(y.ParameterSet.Fitness); return c != 0 ? c : x.Index.CompareTo(y.Index); });
 
                     // Find centroid g excluding worst point and compute reflection of worst point about centroid r = 2g - u(worst)
                     Reflection(ref B, ref g, ref p);
@@ -350,7 +350,7 @@ private void EvolveComplex(int alpha, ref List<PointFitness> Acomplex, double[]
                     }
                 }
 
-                Acomplex.Sort((x, y) => x.ParameterSet.Fitness.CompareTo(y.ParameterSet.Fitness));
+                Acomplex.Sort((x, y) => { int c = x.ParameterSet.Fitness.CompareTo(y.ParameterSet.Fitness); return c != 0 ? c : x.Index.CompareTo(y.Index); });
             }
         }
 

Numerics/Sampling/MCMC/Base/MCMCSampler.cs

@@ -402,7 +402,7 @@ protected virtual ParameterSet[] InitializeChains()
                 return chainStates;
             }
 
-            var prng = new Random(PRNGSeed);
+            var prng = new MersenneTwister(PRNGSeed);
             var rnds = LatinHypercube.Random(InitialIterations, NumberOfParameters, prng.Next());
             var parameters = new double[NumberOfParameters];
             var tempPopulation = new List<ParameterSet>();       
@@ -634,14 +634,14 @@ public void Reset()
             _simulations = 0;
             MAPInitializationFailed = false;
             // Clear old memory and re-instantiate the result storage
-            _masterPRNG = new Random(PRNGSeed);
-            _chainPRNGs = new Random[NumberOfChains];
+            _masterPRNG = new MersenneTwister(PRNGSeed);
+            _chainPRNGs = new MersenneTwister[NumberOfChains];
             PopulationMatrix = new List<ParameterSet>();
             MarkovChains = new List<ParameterSet>[NumberOfChains];
             Output = new List<ParameterSet>[NumberOfChains];
             for (int i = 0; i < NumberOfChains; i++)
             {
-                _chainPRNGs[i] = new Random(_masterPRNG.Next());
+                _chainPRNGs[i] = new MersenneTwister(_masterPRNG.Next());
                 MarkovChains[i] = new List<ParameterSet>();
                 Output[i] = new List<ParameterSet>();
             }

Numerics/Utilities/ExtensionMethods.cs

@@ -337,7 +337,7 @@ public static T[] RandomSubset<T>(this T[] array, int length, int seed = -1, boo
             if (length > array.Length)
                 throw new ArgumentException("The subset length must be less than or equal to the array length.");
 
-            Random random = seed > 0 ? new Random(seed) : new Random();
+            var random = seed > 0 ? new MersenneTwister(seed) : new MersenneTwister();
             var indexes = random.NextIntegers(0, array.Length, length, replace);
             var result = new T[indexes.Length];
             for (int i = 0; i < indexes.Length; i++)
@@ -484,7 +484,7 @@ public static void SetColumn<T>(this T[,] array, int index, T[] values)
             if (length > array.GetLength(0))
                 throw new ArgumentException("The subset length must be less than or equal to the array length.");
 
-            Random random = seed > 0 ? new Random(seed) : new Random();
+            var random = seed > 0 ? new MersenneTwister(seed) : new MersenneTwister();
             var indexes = random.NextIntegers(0, array.GetLength(0), length, replace);
             var result = new T[indexes.Length, array.GetLength(1)];
             for (int i = 0; i < indexes.Length; i++)
@@ -561,7 +561,7 @@ public static Vector RandomSubset(this Vector vector, int length, int seed = -1,
             if (length > vector.Length)
                 throw new ArgumentException("The subset length must be less than or equal to the vector length.");
 
-            Random random = seed > 0 ? new Random(seed) : new Random();
+            var random = seed > 0 ? new MersenneTwister(seed) : new MersenneTwister();
             var indexes = random.NextIntegers(0, vector.Length, length, replace);
             var result = new Vector(indexes.Length);
             for (int i = 0; i < indexes.Length; i++)
@@ -687,7 +687,7 @@ public static Matrix RandomSubset(this Matrix matrix, int length, int seed = -1,
             if (length > matrix.NumberOfRows)
                 throw new ArgumentException("The subset length must be less than or equal to the number of rows in the matrix.");
 
-            Random random = seed > 0 ? new Random(seed) : new Random();
+            var random = seed > 0 ? new MersenneTwister(seed) : new MersenneTwister();
             var indexes = random.NextIntegers(0, matrix.NumberOfRows, length, replace);
             var result = new Matrix(indexes.Length, matrix.NumberOfColumns);
             for (int i = 0; i < indexes.Length; i++)

Test_Numerics/AssemblyAttributes.cs

@@ -1,3 +1,3 @@
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
-[assembly: DoNotParallelize]
+[assembly: Parallelize(Scope = ExecutionScope.ClassLevel)]